chore(node): upgrade to Node 18 LTS

.devcontainer/Dockerfile

@@ -1,5 +1,5 @@
 # See here for image contents: https://github.com/microsoft/vscode-dev-containers/tree/v0.134.1/containers/typescript-node/.devcontainer/base.Dockerfile
-ARG VARIANT="16"
+ARG VARIANT="18"
 FROM mcr.microsoft.com/vscode/devcontainers/typescript-node:0-${VARIANT}
 
 # [Optional] Uncomment this section to install additional OS packages.

.devcontainer/devcontainer.json

@@ -6,13 +6,9 @@
     "dockerfile": "Dockerfile",
     // Update 'VARIANT' to pick a Node version: 10, 12, 14...
     "args": {
-      "VARIANT": "16"
+      "VARIANT": "18"
     }
   },
-  // Set *default* container specific settings.json values on container create.
-  "settings": {
-    "terminal.integrated.shell.linux": "/usr/bin/zsh"
-  },
   // Add the IDs of extensions you want installed when the container is created.
   "extensions": [
     "octref.vetur",

.github/workflows/code_quality.yml

@@ -34,7 +34,7 @@ jobs:
       - name: Setup node environment ⚙️
         uses: actions/setup-node@v3.5.1
         with:
-          node-version: 16
+          node-version: 18
           cache: 'npm'
           check-latest: true
 
@@ -57,7 +57,7 @@ jobs:
       - name: Setup node environment ⚙️
         uses: actions/setup-node@v3.5.1
         with:
-          node-version: 16
+          node-version: 18
           cache: 'npm'
           check-latest: true
 
@@ -143,7 +143,7 @@ jobs:
       - name: Setup node environment ⚙️
         uses: actions/setup-node@v3.5.1
         with:
-          node-version: 16
+          node-version: 18
           cache: 'npm'
           check-latest: true
 

.github/workflows/release.yml

@@ -84,7 +84,7 @@ jobs:
       - name: Setup node environment ⚙️
         uses: actions/setup-node@v3.5.1
         with:
-          node-version: 16
+          node-version: 18
           cache: 'npm'
           check-latest: true
 

.github/workflows/unstable.yml

@@ -90,7 +90,7 @@ jobs:
       - name: Setup node environment ⚙️
         uses: actions/setup-node@v3.5.1
         with:
-          node-version: 16
+          node-version: 18
           cache: 'npm'
           check-latest: true
 

Dockerfile

@@ -1,6 +1,6 @@
 ## This dockerfile builds the client entirely in a Docker context
 
-FROM node:16-alpine AS build
+FROM node:18-alpine AS build
 
 # Set build arguments
 ARG DEFAULT_SERVERS

README.md

@@ -51,8 +51,8 @@ This is an experimental web client for Jellyfin based on Vue.js. We welcome all
 
 ## Dependencies
 
-- [Node.js LTS](https://nodejs.org/en/download) `>=16.13.1 <17.0.0`
-- npm `>=8.1.2` (included in Node.js)
+- [Node.js LTS](https://nodejs.org/en/download) `>=18.12.0 <19.0.0`
+- npm `>=8.19.2` (included in Node.js)
 - Jellyfin Server `>=10.7.0`
 
 ## Getting Started

frontend/package.json

@@ -74,8 +74,8 @@
     "vue-tsc": "0.34.16"
   },
   "engines": {
-    "node": ">=16.13.1 <17.0.0",
-    "npm": ">=8.1.2",
+    "node": ">=18.12.0 <19.0.0",
+    "npm": ">=8.19.2",
     "yarn": "Yarn is not supported. Please use NPM."
   }
 }

frontend/vite.config.ts

@@ -20,9 +20,7 @@ export default defineConfig(async ({ mode }): Promise<UserConfig> => {
       port: 3000
     },
     define: {
-      __COMMIT_HASH__: JSON.stringify(
-        process.env.COMMIT_HASH || process.env.CF_PAGES_COMMIT_SHA || ''
-      )
+      __COMMIT_HASH__: JSON.stringify(process.env.COMMIT_HASH || '')
     },
     plugins: [
       vue(),

package-lock.json

@@ -11,8 +11,8 @@
         "tauri"
       ],
       "engines": {
-        "node": ">=16.13.1 <17.0.0",
-        "npm": ">=8.1.2",
+        "node": ">=18.12.0 <19.0.0",
+        "npm": ">=8.19.2",
         "yarn": "Yarn is not supported. Please use NPM."
       }
     },
@@ -68,8 +68,8 @@
         "vue-tsc": "0.34.16"
       },
       "engines": {
-        "node": ">=16.13.1 <17.0.0",
-        "npm": ">=8.1.2",
+        "node": ">=18.12.0 <19.0.0",
+        "npm": ">=8.19.2",
         "yarn": "Yarn is not supported. Please use NPM."
       }
     },
@@ -12955,8 +12955,8 @@
         "@tauri-apps/tauricon": "1.0.2"
       },
       "engines": {
-        "node": ">=16.13.1 <17.0.0",
-        "npm": ">=8.1.2",
+        "node": ">=18.12.0 <19.0.0",
+        "npm": ">=8.19.2",
         "yarn": "Yarn is not supported. Please use NPM."
       }
     }

package.json

@@ -16,8 +16,8 @@
     "tauri"
   ],
   "engines": {
-    "node": ">=16.13.1 <17.0.0",
-    "npm": ">=8.1.2",
+    "node": ">=18.12.0 <19.0.0",
+    "npm": ">=8.19.2",
     "yarn": "Yarn is not supported. Please use NPM."
   }
 }

tauri/package.json

@@ -17,8 +17,8 @@
     "@tauri-apps/tauricon": "1.0.2"
   },
   "engines": {
-    "node": ">=16.13.1 <17.0.0",
-    "npm": ">=8.1.2",
+    "node": ">=18.12.0 <19.0.0",
+    "npm": ">=8.19.2",
     "yarn": "Yarn is not supported. Please use NPM."
   }
 }