jellyfin/jellyfin-vue
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin-vue.git synced 2024-11-23 05:59:55 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

refactor: address review comments

Browse Source 
Signed-off-by: Fernando Fernández <ferferga@hotmail.com>
This commit is contained in:
Fernando Fernández 2024-09-10 23:43:31 +02:00
parent ff0a5ff0bd
commit 75cea0dc73
1 changed files with 16 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
frontend/src/components/Playback/SubtitleTrack.vue
View File

@ -9,7 +9,7 @@
{{ $t('subtitlePreviewText') }}
</template>
<JSafeHtml
v-else-if="currentSubtitle !== undefined"
v-else-if="!isNil(currentSubtitle?.sub)"
:html="currentSubtitle.sub.text" />
</span>
</div>
@ -39,22 +39,30 @@ const { preview } = defineProps<{
* to find the next one
*/
const predicate = (d: Dialogue) => d.start <= playbackManager.currentTime && d.end >= playbackManager.currentTime;
const findSubtitle = (dialogue: ParsedSubtitleTrack['dialogue'], start = 0) =>
dialogue.slice(start).findIndex(d => predicate(d));
const findSubtitle = (dialogue: ParsedSubtitleTrack['dialogue'], start = 0) => {
const index = dialogue.slice(start).findIndex(d => predicate(d));
return index === -1 ? undefined : index;
};
const dialogue = computed(() => playerElement.currentExternalSubtitleTrack?.parsed?.dialogue);
const currentSubtitle = computed<{ index: number; sub: Dialogue } | undefined>((previous) => {
const currentSubtitle = computed<{ index: number; sub?: Dialogue | undefined } | undefined>((previous) => {
if (!isNil(dialogue.value)) {
const hasPrevious = !isNil(previous);
const isNext = hasPrevious && predicate(dialogue.value[previous.index + 1]);
const nextIndex = hasPrevious ? previous.index + 1 : 0;
const isNext = hasPrevious && predicate(dialogue.value[nextIndex]);
const isCurrent = hasPrevious && predicate(dialogue.value[previous.index]);
if (isCurrent) {
return previous;
} else {
const newIndex = isNext ? previous.index + 1 : findSubtitle(dialogue.value);
const newIndex = isNext ? nextIndex : findSubtitle(dialogue.value, nextIndex);
return { index: newIndex, sub: dialogue.value[newIndex] };
if (!isNil(newIndex)) {
return { index: newIndex, sub: dialogue.value[newIndex] };
} else if (hasPrevious) {
return { index: previous.index };
}
}
}
});
@ -92,8 +100,7 @@ const subtitleStyle = computed<StyleValue>(() => {
<style scoped>
.stroked {
--webkit-text-stroke-color: black;
--webkit-text-stroke-width: 7px;
-webkit-text-stroke: 7px black;
text-shadow: 2px 2px 15px black;
paint-order: stroke fill;
}