jellyfin/jellyfin-vue
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin-vue.git synced 2025-03-01 18:35:43 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix: WebAudio not being properly disposed when reinitiating playback (#2280)

Browse Source 
This could be reproduced by switching tracks initiating new reproductions (for example, by clicking in individual tracks inside an album).

Signed-off-by: Fernando Fernández <ferferga@hotmail.com>
This commit is contained in:
Fernando Fernández 2024-03-30 21:19:46 +01:00 committed by GitHub
parent 55d5d37327
commit 9600525033
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
frontend/src/components/Playback/PlayerElement.vue
View File

@ -166,11 +166,12 @@ watch(
);
watch(mediaElementRef, async () => {
await nextTick();
detachHls();
await detachWebAudio();
if (mediaElementRef.value) {
await nextTick();
if (mediaElementType.value === 'video' && hls) {
hls.attachMedia(mediaElementRef.value);
hls.on(Events.ERROR, onHlsEror);
@ -182,7 +183,10 @@ watch(mediaElementRef, async () => {
);
mediaWebAudio.sourceNode.connect(mediaWebAudio.context.destination);
}
});
/**
* Needed so WebAudio is properly disposed
*/
}, { flush: 'sync' });
watch(
() => playbackManager.currentSourceUrl,