jellyfin/jellyfin-vue
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin-vue.git synced 2024-11-27 00:00:23 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

refactor: replace deprecated getItemImageUrl function (#2488)

Browse Source
This commit is contained in:
Fernando Fernández 2024-11-05 23:28:43 +01:00 committed by GitHub
parent e45a106409
commit a14092aaf4
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 15 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
frontend/src/components/Item/Metadata/MetadataEditor.vue
View File

@ -158,7 +158,7 @@
v-if="item.Id && item.PrimaryImageTag"
:alt="$t('person')"
:src="
remote.sdk.api?.getItemImageUrl(
getItemImageUrl(
item.Id,
ImageType.Primary
)
@ -234,6 +234,7 @@ import { format, formatISO } from 'date-fns';
import { computed, ref } from 'vue';
import { useI18n } from 'vue-i18n';
import { watchImmediate } from '@vueuse/core';
import { getItemImageUrl } from '@/utils/images';
import { isArray } from '@/utils/validation';
import { remote } from '@/plugins/remote';
import { useSnackbar } from '@/composables/use-snackbar';

3
frontend/src/components/Item/Metadata/PersonEditor.vue
View File

@ -14,7 +14,7 @@
class="ml-2">
<JImg
:src="
person?.Id && $remote.sdk.api?.getItemImageUrl(person.Id, ImageType.Primary)
person?.Id && getItemImageUrl(person.Id, ImageType.Primary)
"
:alt="$t('person')">
<template #placeholder>
@ -82,6 +82,7 @@ import { computed, ref } from 'vue';
import { useI18n } from 'vue-i18n';
import { type BaseItemPerson, ImageType } from '@jellyfin/sdk/lib/generated-client';
import { watchImmediate } from '@vueuse/core';
import { getItemImageUrl } from '@/utils/images';
const { person } = defineProps<{ person: BaseItemPerson | undefined }>();

13
frontend/src/utils/images.ts
View File

@ -8,6 +8,8 @@ import {
type BaseItemPerson,
ImageType
} from '@jellyfin/sdk/lib/generated-client';
import { getImageApi } from '@jellyfin/sdk/lib/utils/api/image-api';
import type { ImageUrlsApi } from '@jellyfin/sdk/lib/utils/api/image-urls-api';
import { remote } from '@/plugins/remote';
import { CardShapes, getShapeFromItemType, isPerson } from '@/utils/items';
@ -20,6 +22,13 @@ const excludedBlurhashTypes = Object.freeze(
new Set<ImageType>([ImageType.Logo])
);
/**
* Gets the image URL given an item id and the image type requested
*/
export function getItemImageUrl(...args: Parameters<ImageUrlsApi['getItemImageUrlById']>) {
return remote.sdk.newUserApi(getImageApi).getItemImageUrlById(...args);
}
/**
* Gets the tag of the image of an specific item and type.
*
@ -347,7 +356,7 @@ export function getImageInfo(
};
}
const url_string = remote.sdk.api?.getItemImageUrl(itemId, imgType);
const url_string = getItemImageUrl(itemId, imgType);
if (imgTag && imgType && url_string) {
url = new URL(url_string);
@ -420,7 +429,7 @@ export function getLogo(
}
if (imgTag && imgType && itemId) {
url = new URL(remote.sdk.api?.getItemImageUrl(itemId, imgType) ?? '');
url = new URL(getItemImageUrl(itemId, imgType));
const parameters: Record<string, string> = {
imgTag,