We can always reintroduce Vite PWA once we iron out the
rest of the things and our app is more ready to work offline
(by properly using stores, for example)
The status of workbox support is unclear, once it's clear we can
think about supporting it again: https://github.com/vite-pwa/vite-plugin-pwa/issues/452
Next up was called for each library, while the function itself overwrote the whole state. This resulted in nextUp being populated by the latest library fetched.
I reduced it to a single call cause removing the parentId gets us the classic Next Up experience from web.
Other improvements:
- Merge promises together
- Better function names and null checks
The readme was not fitting for the current state of the client. Use
better futureproofing in the wording and link to wiki pages where
the most up-to-date information (like configuration settings) will live.
* Make the description framework agnostic, so we don't need to update it
in case we switch our desktop app bundler (for example).
* Add better description for end users. We were too developer centric.
* Add links to Wiki for all the pieces that are more susceptible of evolving.
* Add some clarification about how jellyfin-vue works
(add a note about jellyfin-web too) in regards to privacy,
since by what I read on Reddit,
many people assume the connections are not direct between their devices
and the target Jellyfin server.
* Made that privacy note really agnostic for how the client might be
served/distributed in the future (but hopefully I did it in a clear way).
* Clarify the "Getting started" and "Running a production build sections".
Co-authored-by: aweebs <8809837+aweebs@users.noreply.github.com>
Due to a regression in npm 9.3.0 (upgraded by Node.JS 18 LTS at 18.14.0,
see https://github.com/nodejs/node/blob/main/doc/changelogs/CHANGELOG_V18.md#2023-02-02-version-18140-hydrogen-lts-bethgriggs-prepared-by-juanarbol),
the `npm get config` command stopped working in workspaces. This made
our actions using actions/setup-node to fail.
Issues were opened in the relevant repositories since january
and february (check https://github.com/npm/cli/issues/6099 and https://github.com/actions/setup-node/issues/712)
but it looks like getting this fixed upstream it's going to take a long time.
We have been waiting for a really long time
for other fixes in npm, so I don't expect this situation will be solved really soon
We need a working CI before the Vue 3 merge, so applying this commit will
solve the issue in the meantime. In the future, it might be interesting
to revert this commit.
Also format the GitHub Actions workflows using the official VSCode GitHub extension
