Backport pull request #5718 from jellyfin-web/release-10.9.z

HtmlVideoPlayer fix and cleanup

Original-merge: 18061ce247

Merged-by: thornbill <thornbill@users.noreply.github.com>

Backported-by: Joshua M. Boniface <joshua@boniface.me>
This commit is contained in:
dmitrylyzo 2024-06-24 20:30:57 -04:00 committed by Joshua M. Boniface
parent 2cbc9e4abf
commit f30343cfca

View File

@ -209,10 +209,6 @@ export class HtmlVideoPlayer {
* @type {number | null}
*/
#audioTrackIndexToSetOnPlaying;
/**
* @type {null | undefined}
*/
#currentClock;
/**
* @type {any | null | undefined}
*/
@ -862,6 +858,8 @@ export class HtmlVideoPlayer {
videoElement.parentNode.removeChild(videoElement);
}
this._currentAspectRatio = null;
const dlg = this.#videoDialog;
if (dlg) {
this.#videoDialog = null;
@ -1169,9 +1167,6 @@ export class HtmlVideoPlayer {
this.destroyNativeTracks(videoElement, targetTrackIndex);
this.destroyStoredTrackInfo(targetTrackIndex);
this.#currentClock = null;
this._currentAspectRatio = null;
const octopus = this.#currentAssRenderer;
if (octopus) {
octopus.dispose();
@ -1499,16 +1494,6 @@ export class HtmlVideoPlayer {
* @private
*/
updateSubtitleText(timeMs) {
const clock = this.#currentClock;
if (clock) {
try {
clock.seek(timeMs / 1000);
} catch (err) {
console.error(`error in libjass: ${err}`);
}
return;
}
const allTrackEvents = [this.#currentTrackEvents, this.#currentSecondaryTrackEvents];
const subtitleTextElements = [this.#videoSubtitlesElem, this.#videoSecondarySubtitlesElem];