joel16/android_kernel_sony_msm8994
1
0
Fork 0
mirror of https://github.com/joel16/android_kernel_sony_msm8994.git synced 2024-12-12 06:49:34 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

drivers/isdn/hardware/mISDN: move a dereference below a NULL test

Browse Source 
In each case, if the NULL test is necessary, then the dereference should be
moved below the NULL test.

The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@@
type T;
expression E;
identifier i,fld;
statement S;
@@

- T i = E->fld;
+ T i;
  ... when != E
      when != i
  if (E == NULL) S
+ i = E->fld;
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Karsten Keil <kkeil@suse.de>
This commit is contained in:
Julia Lawall 2009-01-09 12:22:53 -08:00 committed by Karsten Keil
parent f27b8c356c
commit 20b788045b
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/isdn/hardware/mISDN/hfcmulti.c
View File

@ -3615,7 +3615,7 @@ hfcm_bctrl(struct mISDNchannel *ch, u_int cmd, void *arg)
static void
ph_state_change(struct dchannel *dch)
{
struct hfc_multi *hc = dch->hw;
struct hfc_multi *hc;
int ch, i;
if (!dch) {
@ -3623,6 +3623,7 @@ ph_state_change(struct dchannel *dch)
__func__);
return;
}
hc = dch->hw;
ch = dch->slot;
if (hc->type == 1) {