joel16/android_kernel_sony_msm8994
1
0
Fork 0
mirror of https://github.com/joel16/android_kernel_sony_msm8994.git synced 2025-02-25 07:53:26 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

ALSA: usb-audio: avoid freeing umidi object twice

Browse Source 
commit 07d86ca93db7e5cdf4743564d98292042ec21af7 upstream.

The 'umidi' object will be free'd on the error path by snd_usbmidi_free()
when tearing down the rawmidi interface. So we shouldn't try to free it
in snd_usbmidi_create() after having registered the rawmidi interface.

Found by KASAN.

Change-Id: I109ad90b5836a5422380816671f9eb1a37e0557e
Signed-off-by: Andrey Konovalov <andreyknvl@gmail.com>
Acked-by: Clemens Ladisch <clemens@ladisch.de>
Cc: <stable@vger.kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
This commit is contained in:
Andrey Konovalov 2016-02-13 11:08:06 +03:00 committed by Olivier Karasangabo
parent 1649dd6995
commit ae306adc03
No known key found for this signature in database
GPG Key ID: C5C93AF8ED1CCEB5
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
sound/usb/midi.c
View File

@ -2245,7 +2245,6 @@ int snd_usbmidi_create(struct snd_card *card,
else else
err = snd_usbmidi_create_endpoints(umidi, endpoints); err = snd_usbmidi_create_endpoints(umidi, endpoints);
if (err < 0) { if (err < 0) {
snd_usbmidi_free(umidi);
return err; return err;
} }