mirror of
https://github.com/joel16/android_kernel_sony_msm8994_rework.git
synced 2024-12-28 15:24:58 +00:00
[PATCH] read_mapping_page for address space
Add read_mapping_page() which is used for callers that pass mapping->a_ops->readpage as the filler for read_cache_page. This removes some duplication from filesystem code. Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
This commit is contained in:
parent
c330dda908
commit
090d2b185d
@ -185,9 +185,7 @@ static struct page *afs_dir_get_page(struct inode *dir, unsigned long index)
|
||||
|
||||
_enter("{%lu},%lu", dir->i_ino, index);
|
||||
|
||||
page = read_cache_page(dir->i_mapping,index,
|
||||
(filler_t *) dir->i_mapping->a_ops->readpage,
|
||||
NULL);
|
||||
page = read_mapping_page(dir->i_mapping, index, NULL);
|
||||
if (!IS_ERR(page)) {
|
||||
wait_on_page_locked(page);
|
||||
kmap(page);
|
||||
|
@ -63,7 +63,6 @@ unsigned long afs_mntpt_expiry_timeout = 20;
|
||||
int afs_mntpt_check_symlink(struct afs_vnode *vnode)
|
||||
{
|
||||
struct page *page;
|
||||
filler_t *filler;
|
||||
size_t size;
|
||||
char *buf;
|
||||
int ret;
|
||||
@ -71,10 +70,7 @@ int afs_mntpt_check_symlink(struct afs_vnode *vnode)
|
||||
_enter("{%u,%u}", vnode->fid.vnode, vnode->fid.unique);
|
||||
|
||||
/* read the contents of the symlink into the pagecache */
|
||||
filler = (filler_t *) AFS_VNODE_TO_I(vnode)->i_mapping->a_ops->readpage;
|
||||
|
||||
page = read_cache_page(AFS_VNODE_TO_I(vnode)->i_mapping, 0,
|
||||
filler, NULL);
|
||||
page = read_mapping_page(AFS_VNODE_TO_I(vnode)->i_mapping, 0, NULL);
|
||||
if (IS_ERR(page)) {
|
||||
ret = PTR_ERR(page);
|
||||
goto out;
|
||||
@ -160,7 +156,6 @@ static struct vfsmount *afs_mntpt_do_automount(struct dentry *mntpt)
|
||||
struct page *page = NULL;
|
||||
size_t size;
|
||||
char *buf, *devname = NULL, *options = NULL;
|
||||
filler_t *filler;
|
||||
int ret;
|
||||
|
||||
kenter("{%s}", mntpt->d_name.name);
|
||||
@ -182,9 +177,7 @@ static struct vfsmount *afs_mntpt_do_automount(struct dentry *mntpt)
|
||||
goto error;
|
||||
|
||||
/* read the contents of the AFS special symlink */
|
||||
filler = (filler_t *)mntpt->d_inode->i_mapping->a_ops->readpage;
|
||||
|
||||
page = read_cache_page(mntpt->d_inode->i_mapping, 0, filler, NULL);
|
||||
page = read_mapping_page(mntpt->d_inode->i_mapping, 0, NULL);
|
||||
if (IS_ERR(page)) {
|
||||
ret = PTR_ERR(page);
|
||||
goto error;
|
||||
|
@ -181,9 +181,7 @@ static void *cramfs_read(struct super_block *sb, unsigned int offset, unsigned i
|
||||
struct page *page = NULL;
|
||||
|
||||
if (blocknr + i < devsize) {
|
||||
page = read_cache_page(mapping, blocknr + i,
|
||||
(filler_t *)mapping->a_ops->readpage,
|
||||
NULL);
|
||||
page = read_mapping_page(mapping, blocknr + i, NULL);
|
||||
/* synchronous error? */
|
||||
if (IS_ERR(page))
|
||||
page = NULL;
|
||||
|
@ -159,8 +159,7 @@ fail:
|
||||
static struct page * ext2_get_page(struct inode *dir, unsigned long n)
|
||||
{
|
||||
struct address_space *mapping = dir->i_mapping;
|
||||
struct page *page = read_cache_page(mapping, n,
|
||||
(filler_t*)mapping->a_ops->readpage, NULL);
|
||||
struct page *page = read_mapping_page(mapping, n, NULL);
|
||||
if (!IS_ERR(page)) {
|
||||
wait_on_page_locked(page);
|
||||
kmap(page);
|
||||
|
@ -71,8 +71,7 @@ vxfs_get_page(struct address_space *mapping, u_long n)
|
||||
{
|
||||
struct page * pp;
|
||||
|
||||
pp = read_cache_page(mapping, n,
|
||||
(filler_t*)mapping->a_ops->readpage, NULL);
|
||||
pp = read_mapping_page(mapping, n, NULL);
|
||||
|
||||
if (!IS_ERR(pp)) {
|
||||
wait_on_page_locked(pp);
|
||||
|
@ -280,7 +280,7 @@ static struct hfs_bnode *__hfs_bnode_create(struct hfs_btree *tree, u32 cnid)
|
||||
block = off >> PAGE_CACHE_SHIFT;
|
||||
node->page_offset = off & ~PAGE_CACHE_MASK;
|
||||
for (i = 0; i < tree->pages_per_bnode; i++) {
|
||||
page = read_cache_page(mapping, block++, (filler_t *)mapping->a_ops->readpage, NULL);
|
||||
page = read_mapping_page(mapping, block++, NULL);
|
||||
if (IS_ERR(page))
|
||||
goto fail;
|
||||
if (PageError(page)) {
|
||||
|
@ -59,7 +59,7 @@ struct hfs_btree *hfs_btree_open(struct super_block *sb, u32 id, btree_keycmp ke
|
||||
unlock_new_inode(tree->inode);
|
||||
|
||||
mapping = tree->inode->i_mapping;
|
||||
page = read_cache_page(mapping, 0, (filler_t *)mapping->a_ops->readpage, NULL);
|
||||
page = read_mapping_page(mapping, 0, NULL);
|
||||
if (IS_ERR(page))
|
||||
goto free_tree;
|
||||
|
||||
|
@ -31,8 +31,7 @@ int hfsplus_block_allocate(struct super_block *sb, u32 size, u32 offset, u32 *ma
|
||||
dprint(DBG_BITMAP, "block_allocate: %u,%u,%u\n", size, offset, len);
|
||||
mutex_lock(&HFSPLUS_SB(sb).alloc_file->i_mutex);
|
||||
mapping = HFSPLUS_SB(sb).alloc_file->i_mapping;
|
||||
page = read_cache_page(mapping, offset / PAGE_CACHE_BITS,
|
||||
(filler_t *)mapping->a_ops->readpage, NULL);
|
||||
page = read_mapping_page(mapping, offset / PAGE_CACHE_BITS, NULL);
|
||||
pptr = kmap(page);
|
||||
curr = pptr + (offset & (PAGE_CACHE_BITS - 1)) / 32;
|
||||
i = offset % 32;
|
||||
@ -72,8 +71,8 @@ int hfsplus_block_allocate(struct super_block *sb, u32 size, u32 offset, u32 *ma
|
||||
offset += PAGE_CACHE_BITS;
|
||||
if (offset >= size)
|
||||
break;
|
||||
page = read_cache_page(mapping, offset / PAGE_CACHE_BITS,
|
||||
(filler_t *)mapping->a_ops->readpage, NULL);
|
||||
page = read_mapping_page(mapping, offset / PAGE_CACHE_BITS,
|
||||
NULL);
|
||||
curr = pptr = kmap(page);
|
||||
if ((size ^ offset) / PAGE_CACHE_BITS)
|
||||
end = pptr + PAGE_CACHE_BITS / 32;
|
||||
@ -119,8 +118,8 @@ found:
|
||||
set_page_dirty(page);
|
||||
kunmap(page);
|
||||
offset += PAGE_CACHE_BITS;
|
||||
page = read_cache_page(mapping, offset / PAGE_CACHE_BITS,
|
||||
(filler_t *)mapping->a_ops->readpage, NULL);
|
||||
page = read_mapping_page(mapping, offset / PAGE_CACHE_BITS,
|
||||
NULL);
|
||||
pptr = kmap(page);
|
||||
curr = pptr;
|
||||
end = pptr + PAGE_CACHE_BITS / 32;
|
||||
@ -167,7 +166,7 @@ int hfsplus_block_free(struct super_block *sb, u32 offset, u32 count)
|
||||
mutex_lock(&HFSPLUS_SB(sb).alloc_file->i_mutex);
|
||||
mapping = HFSPLUS_SB(sb).alloc_file->i_mapping;
|
||||
pnr = offset / PAGE_CACHE_BITS;
|
||||
page = read_cache_page(mapping, pnr, (filler_t *)mapping->a_ops->readpage, NULL);
|
||||
page = read_mapping_page(mapping, pnr, NULL);
|
||||
pptr = kmap(page);
|
||||
curr = pptr + (offset & (PAGE_CACHE_BITS - 1)) / 32;
|
||||
end = pptr + PAGE_CACHE_BITS / 32;
|
||||
@ -199,7 +198,7 @@ int hfsplus_block_free(struct super_block *sb, u32 offset, u32 count)
|
||||
break;
|
||||
set_page_dirty(page);
|
||||
kunmap(page);
|
||||
page = read_cache_page(mapping, ++pnr, (filler_t *)mapping->a_ops->readpage, NULL);
|
||||
page = read_mapping_page(mapping, ++pnr, NULL);
|
||||
pptr = kmap(page);
|
||||
curr = pptr;
|
||||
end = pptr + PAGE_CACHE_BITS / 32;
|
||||
|
@ -440,7 +440,7 @@ static struct hfs_bnode *__hfs_bnode_create(struct hfs_btree *tree, u32 cnid)
|
||||
block = off >> PAGE_CACHE_SHIFT;
|
||||
node->page_offset = off & ~PAGE_CACHE_MASK;
|
||||
for (i = 0; i < tree->pages_per_bnode; block++, i++) {
|
||||
page = read_cache_page(mapping, block, (filler_t *)mapping->a_ops->readpage, NULL);
|
||||
page = read_mapping_page(mapping, block, NULL);
|
||||
if (IS_ERR(page))
|
||||
goto fail;
|
||||
if (PageError(page)) {
|
||||
|
@ -38,7 +38,7 @@ struct hfs_btree *hfs_btree_open(struct super_block *sb, u32 id)
|
||||
goto free_tree;
|
||||
|
||||
mapping = tree->inode->i_mapping;
|
||||
page = read_cache_page(mapping, 0, (filler_t *)mapping->a_ops->readpage, NULL);
|
||||
page = read_mapping_page(mapping, 0, NULL);
|
||||
if (IS_ERR(page))
|
||||
goto free_tree;
|
||||
|
||||
|
@ -632,10 +632,9 @@ struct metapage *__get_metapage(struct inode *inode, unsigned long lblock,
|
||||
}
|
||||
SetPageUptodate(page);
|
||||
} else {
|
||||
page = read_cache_page(mapping, page_index,
|
||||
(filler_t *)mapping->a_ops->readpage, NULL);
|
||||
page = read_mapping_page(mapping, page_index, NULL);
|
||||
if (IS_ERR(page) || !PageUptodate(page)) {
|
||||
jfs_err("read_cache_page failed!");
|
||||
jfs_err("read_mapping_page failed!");
|
||||
return NULL;
|
||||
}
|
||||
lock_page(page);
|
||||
|
@ -60,8 +60,7 @@ static int dir_commit_chunk(struct page *page, unsigned from, unsigned to)
|
||||
static struct page * dir_get_page(struct inode *dir, unsigned long n)
|
||||
{
|
||||
struct address_space *mapping = dir->i_mapping;
|
||||
struct page *page = read_cache_page(mapping, n,
|
||||
(filler_t*)mapping->a_ops->readpage, NULL);
|
||||
struct page *page = read_mapping_page(mapping, n, NULL);
|
||||
if (!IS_ERR(page)) {
|
||||
wait_on_page_locked(page);
|
||||
kmap(page);
|
||||
|
@ -2577,8 +2577,7 @@ static char *page_getlink(struct dentry * dentry, struct page **ppage)
|
||||
{
|
||||
struct page * page;
|
||||
struct address_space *mapping = dentry->d_inode->i_mapping;
|
||||
page = read_cache_page(mapping, 0, (filler_t *)mapping->a_ops->readpage,
|
||||
NULL);
|
||||
page = read_mapping_page(mapping, 0, NULL);
|
||||
if (IS_ERR(page))
|
||||
goto sync_fail;
|
||||
wait_on_page_locked(page);
|
||||
|
@ -86,8 +86,7 @@ static inline void ntfs_unmap_page(struct page *page)
|
||||
static inline struct page *ntfs_map_page(struct address_space *mapping,
|
||||
unsigned long index)
|
||||
{
|
||||
struct page *page = read_cache_page(mapping, index,
|
||||
(filler_t*)mapping->a_ops->readpage, NULL);
|
||||
struct page *page = read_mapping_page(mapping, index, NULL);
|
||||
|
||||
if (!IS_ERR(page)) {
|
||||
wait_on_page_locked(page);
|
||||
|
@ -2529,8 +2529,7 @@ int ntfs_attr_set(ntfs_inode *ni, const s64 ofs, const s64 cnt, const u8 val)
|
||||
end >>= PAGE_CACHE_SHIFT;
|
||||
/* If there is a first partial page, need to do it the slow way. */
|
||||
if (start_ofs) {
|
||||
page = read_cache_page(mapping, idx,
|
||||
(filler_t*)mapping->a_ops->readpage, NULL);
|
||||
page = read_mapping_page(mapping, idx, NULL);
|
||||
if (IS_ERR(page)) {
|
||||
ntfs_error(vol->sb, "Failed to read first partial "
|
||||
"page (sync error, index 0x%lx).", idx);
|
||||
@ -2600,8 +2599,7 @@ int ntfs_attr_set(ntfs_inode *ni, const s64 ofs, const s64 cnt, const u8 val)
|
||||
}
|
||||
/* If there is a last partial page, need to do it the slow way. */
|
||||
if (end_ofs) {
|
||||
page = read_cache_page(mapping, idx,
|
||||
(filler_t*)mapping->a_ops->readpage, NULL);
|
||||
page = read_mapping_page(mapping, idx, NULL);
|
||||
if (IS_ERR(page)) {
|
||||
ntfs_error(vol->sb, "Failed to read last partial page "
|
||||
"(sync error, index 0x%lx).", idx);
|
||||
|
@ -231,8 +231,7 @@ do_non_resident_extend:
|
||||
* Read the page. If the page is not present, this will zero
|
||||
* the uninitialized regions for us.
|
||||
*/
|
||||
page = read_cache_page(mapping, index,
|
||||
(filler_t*)mapping->a_ops->readpage, NULL);
|
||||
page = read_mapping_page(mapping, index, NULL);
|
||||
if (IS_ERR(page)) {
|
||||
err = PTR_ERR(page);
|
||||
goto init_err_out;
|
||||
|
@ -64,8 +64,7 @@ static char *ocfs2_page_getlink(struct dentry * dentry,
|
||||
{
|
||||
struct page * page;
|
||||
struct address_space *mapping = dentry->d_inode->i_mapping;
|
||||
page = read_cache_page(mapping, 0,
|
||||
(filler_t *)mapping->a_ops->readpage, NULL);
|
||||
page = read_mapping_page(mapping, 0, NULL);
|
||||
if (IS_ERR(page))
|
||||
goto sync_fail;
|
||||
wait_on_page_locked(page);
|
||||
|
@ -499,8 +499,8 @@ unsigned char *read_dev_sector(struct block_device *bdev, sector_t n, Sector *p)
|
||||
struct address_space *mapping = bdev->bd_inode->i_mapping;
|
||||
struct page *page;
|
||||
|
||||
page = read_cache_page(mapping, (pgoff_t)(n >> (PAGE_CACHE_SHIFT-9)),
|
||||
(filler_t *)mapping->a_ops->readpage, NULL);
|
||||
page = read_mapping_page(mapping, (pgoff_t)(n >> (PAGE_CACHE_SHIFT-9)),
|
||||
NULL);
|
||||
if (!IS_ERR(page)) {
|
||||
wait_on_page_locked(page);
|
||||
if (!PageUptodate(page))
|
||||
|
@ -452,8 +452,7 @@ static struct page *reiserfs_get_page(struct inode *dir, unsigned long n)
|
||||
/* We can deadlock if we try to free dentries,
|
||||
and an unlink/rmdir has just occured - GFP_NOFS avoids this */
|
||||
mapping_set_gfp_mask(mapping, GFP_NOFS);
|
||||
page = read_cache_page(mapping, n,
|
||||
(filler_t *) mapping->a_ops->readpage, NULL);
|
||||
page = read_mapping_page(mapping, n, NULL);
|
||||
if (!IS_ERR(page)) {
|
||||
wait_on_page_locked(page);
|
||||
kmap(page);
|
||||
|
@ -53,8 +53,7 @@ static int dir_commit_chunk(struct page *page, unsigned from, unsigned to)
|
||||
static struct page * dir_get_page(struct inode *dir, unsigned long n)
|
||||
{
|
||||
struct address_space *mapping = dir->i_mapping;
|
||||
struct page *page = read_cache_page(mapping, n,
|
||||
(filler_t*)mapping->a_ops->readpage, NULL);
|
||||
struct page *page = read_mapping_page(mapping, n, NULL);
|
||||
if (!IS_ERR(page)) {
|
||||
wait_on_page_locked(page);
|
||||
kmap(page);
|
||||
|
@ -99,6 +99,13 @@ extern struct page * read_cache_page(struct address_space *mapping,
|
||||
extern int read_cache_pages(struct address_space *mapping,
|
||||
struct list_head *pages, filler_t *filler, void *data);
|
||||
|
||||
static inline struct page *read_mapping_page(struct address_space *mapping,
|
||||
unsigned long index, void *data)
|
||||
{
|
||||
filler_t *filler = (filler_t *)mapping->a_ops->readpage;
|
||||
return read_cache_page(mapping, index, filler, data);
|
||||
}
|
||||
|
||||
int add_to_page_cache(struct page *page, struct address_space *mapping,
|
||||
unsigned long index, gfp_t gfp_mask);
|
||||
int add_to_page_cache_lru(struct page *page, struct address_space *mapping,
|
||||
|
@ -1477,8 +1477,7 @@ asmlinkage long sys_swapon(const char __user * specialfile, int swap_flags)
|
||||
error = -EINVAL;
|
||||
goto bad_swap;
|
||||
}
|
||||
page = read_cache_page(mapping, 0,
|
||||
(filler_t *)mapping->a_ops->readpage, swap_file);
|
||||
page = read_mapping_page(mapping, 0, swap_file);
|
||||
if (IS_ERR(page)) {
|
||||
error = PTR_ERR(page);
|
||||
goto bad_swap;
|
||||
|
Loading…
Reference in New Issue
Block a user