Vasily Averin 6eac3f93f5 [PATCH] missing unused dentry in prune_dcache()? ...

On the the following patch:
http://linux.bkbits.net:8080/linux-2.6/gnupatch@449b144ecSF1rYskg3q-SeR2vf88zg

# ChangeSet
#   2006/06/22 15:05:57-07:00 neilb@suse.de
#   [PATCH] Fix dcache race during umount

#   If prune_dcache finds a dentry that it cannot free, it leaves it where it
#   is (at the tail of the list) and exits, on the assumption that some other
#   thread will be removing that dentry soon.

However as far as I see this comment is not correct: when we cannot take
s_umount rw_semaphore (for example because it was taken in do_remount) this
dentry is already extracted from dentry_unused list and we do not add it
into the list again.  Therefore dentry will not be found by prune_dcache()
and shrink_dcache_sb() and will leave in memory very long time until the
partition will be unmounted.

The patch adds this dentry into tail of the dentry_unused list.

Signed-off-by: Vasily Averin <vvs@sw.ru>
Cc: Neil Brown <neilb@suse.de>
Acked-by: David Howells <dhowells@redhat.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

2006-10-28 11:30:53 -07:00

..

9p

[PATCH] r/o bind mount prepwork: inc_nlink() helper

2006-10-01 00:39:30 -07:00

adfs

[PATCH] Streamline generic_file_* interfaces and filemap cleanups

2006-10-01 00:39:28 -07:00

affs

[PATCH] Streamline generic_file_* interfaces and filemap cleanups

2006-10-01 00:39:28 -07:00

afs

[PATCH] fs/*: use BUILD_BUG_ON

2006-10-11 11:14:23 -07:00

autofs

[PATCH] autofs3: Make sure all dentries refs are released before calling kill_anon_super()

2006-10-20 10:26:38 -07:00

autofs4

[PATCH] AUTOFS: Make sure all dentries refs are released before calling kill_anon_super()

2006-10-11 11:14:25 -07:00

befs

[PATCH] befs: endianness annotations

2006-10-10 16:15:33 -07:00

bfs

[PATCH] r/o bind mount prepwork: inc_nlink() helper

2006-10-01 00:39:30 -07:00

cifs

[PATCH] new cifs endianness bugs

2006-10-15 11:00:58 -07:00

coda

[PATCH] r/o bind mount prepwork: inc_nlink() helper

2006-10-01 00:39:30 -07:00

configfs

configfs: handle kzalloc() failure in check_perm()

2006-10-20 15:29:00 -07:00

cramfs

[PATCH] cramfs: make cramfs_uncompress_exit() return void

2006-09-29 09:18:20 -07:00

debugfs

debugfs: spelling fix

2006-10-03 23:28:36 +02:00

devpts

[PATCH] inode-diet: Eliminate i_blksize from the inode structure

2006-09-27 08:26:18 -07:00

dlm

[DLM] fix iovec length in recvmsg

2006-10-20 09:13:10 -04:00

ecryptfs

[PATCH] ecryptfs: use special_file()

2006-10-20 10:26:35 -07:00

efs

[PATCH] Really ignore kmem_cache_destroy return value

2006-09-27 08:26:10 -07:00

exportfs

[PATCH] VFS: Make filldir_t and struct kstat deal in 64-bit inode numbers

2006-10-03 08:03:40 -07:00

ext2

[PATCH] ext2: errors behaviour fix

2006-10-11 11:14:21 -07:00

ext3

[PATCH] ext3: errors behaviour fix

2006-10-11 11:14:21 -07:00

ext4

[PATCH] ext4: fix printk format warnings

2006-10-28 11:30:51 -07:00

fat

[PATCH] separate bdi congestion functions from queue congestion functions

2006-10-20 10:26:35 -07:00

freevxfs

[PATCH] freevxfs: fix leak on error path

2006-09-29 09:18:20 -07:00

fuse

[PATCH] fuse: fix dereferencing dentry parent

2006-10-17 08:18:45 -07:00

gfs2

[GFS2] gfs2_dir_read_data(): fix uninitialized variable usage

2006-10-20 09:16:20 -04:00

hfs

[PATCH] r/o bind mounts: monitor zeroing of i_nlink

2006-10-01 00:39:30 -07:00

hfsplus

fix file specification in comments

2006-10-03 23:01:26 +02:00

hostfs

[PATCH] Streamline generic_file_* interfaces and filemap cleanups

2006-10-01 00:39:28 -07:00

hpfs

[PATCH] hpfs endianness annotations

2006-10-10 16:15:34 -07:00

hppfs

[PATCH] hppfs: readdir callback missed in prototype change

2006-10-09 14:19:08 -07:00

hugetlbfs

[PATCH] hugetlb: fix prio_tree unit

2006-10-28 11:30:53 -07:00

isofs

[PATCH] isofs endianness annotations

2006-10-10 16:15:34 -07:00

jbd

[PATCH] jbd: journal_dirty_data re-check for unmapped buffers

2006-10-28 11:30:51 -07:00

jbd2

[PATCH] jbd2: journal_dirty_data re-check for unmapped buffers

2006-10-28 11:30:51 -07:00

jffs

[PATCH] r/o bind mounts: unlink: monitor i_nlink

2006-10-01 00:39:30 -07:00

jffs2

[PATCH] fs/*: use BUILD_BUG_ON

2006-10-11 11:14:23 -07:00

jfs

JFS: pageno needs to be long

2006-10-13 12:42:36 -05:00

lockd

[PATCH] lockd endianness annotations

2006-10-20 10:26:40 -07:00

minix

[PATCH] fs/*: use BUILD_BUG_ON

2006-10-11 11:14:23 -07:00

msdos

[PATCH] r/o bind mounts: monitor zeroing of i_nlink

2006-10-01 00:39:30 -07:00

ncpfs

[PATCH] wrong order of arguments in copy_to_user() in ncpfs

2006-10-09 14:19:08 -07:00

nfs

[PATCH] NFS: Cache invalidation fixup

2006-10-21 13:35:06 -07:00

nfs_common

[PATCH] nfs_common endianness annotations

2006-10-20 10:26:41 -07:00

nfsd

[PATCH] nfsd: nfs_replay_me

2006-10-20 10:26:43 -07:00

nls

fix file specification in comments

2006-10-03 23:01:26 +02:00

ntfs

[PATCH] Streamline generic_file_* interfaces and filemap cleanups

2006-10-01 00:39:28 -07:00

ocfs2

ocfs2: cond_resched() in ocfs2_zero_extend()

2006-10-20 15:27:48 -07:00

openpromfs

Move several *_SUPER_MAGIC symbols to include/linux/magic.h.

2006-09-24 11:13:19 -04:00

partitions

[PATCH] fs/partitions/check: add sysfs error handling

2006-10-17 08:18:47 -07:00

proc

[PATCH] OOM killer meets userspace headers

2006-10-20 10:26:38 -07:00

qnx4

[PATCH] r/o bind mounts: monitor zeroing of i_nlink

2006-10-01 00:39:30 -07:00

ramfs

[PATCH] r/o bind mount prepwork: inc_nlink() helper

2006-10-01 00:39:30 -07:00

reiserfs

[PATCH] separate bdi congestion functions from queue congestion functions

2006-10-20 10:26:35 -07:00

romfs

[PATCH] Really ignore kmem_cache_destroy return value

2006-09-27 08:26:10 -07:00

smbfs

[PATCH] Streamline generic_file_* interfaces and filemap cleanups

2006-10-01 00:39:28 -07:00

sysfs

sysfs: update obsolete comment in sysfs_update_file

2006-10-18 12:49:54 -07:00

sysv

[PATCH] fs/*: use BUILD_BUG_ON

2006-10-11 11:14:23 -07:00

udf

[PATCH] UDF: Fix mounting read-write

2006-10-05 16:18:55 -07:00

ufs

[PATCH] ufs endianness annotations

2006-10-10 16:15:34 -07:00

vfat

[PATCH] r/o bind mounts: monitor zeroing of i_nlink

2006-10-01 00:39:30 -07:00

xfs

[PATCH] separate bdi congestion functions from queue congestion functions

2006-10-20 10:26:35 -07:00

aio.c

[PATCH] pr_debug: aio: use size_t length modifier in pr_debug format arguments

2006-10-03 08:04:19 -07:00

attr.c

…

bad_inode.c

[PATCH] Remove readv/writev methods and use aio_read/aio_write instead

2006-10-01 00:39:28 -07:00

binfmt_aout.c

[PATCH] Require mmap handler for a.out executables

2006-09-29 09:18:08 -07:00

binfmt_elf_fdpic.c

[PATCH] elf_fdpic_core_dump: don't take tasklist_lock

2006-09-29 09:18:14 -07:00

binfmt_elf.c

[PATCH] Fix core files so they make sense to gdb...

2006-10-15 11:24:49 -07:00

binfmt_em86.c

…

binfmt_flat.c

Remove obsolete #include <linux/config.h>

2006-06-30 19:25:36 +02:00

binfmt_misc.c

[PATCH] Fix unserialized task->files changing

2006-09-29 09:18:12 -07:00

binfmt_script.c

…

binfmt_som.c

[PARISC] Fix fs/binfmt_som.c

2006-10-04 06:51:26 -06:00

bio.c

[PATCH] fs/bio.c: tweaks

2006-10-11 11:14:25 -07:00

block_dev.c

[PATCH] Fix potential OOPs in blkdev_open()

2006-10-28 11:30:52 -07:00

buffer.c

[PATCH] Fix IO error reporting on fsync()

2006-10-17 08:18:46 -07:00

char_dev.c

[PATCH] BLOCK: Move extern declarations out of fs/*.c into header files [try #6]

2006-09-30 20:52:18 +02:00

compat_ioctl.c

[PATCH] 32-bit compatibility HDIO IOCTLs

2006-10-11 11:14:22 -07:00

compat.c

[PATCH] more fs/compat.c __user annotations

2006-10-10 15:37:20 -07:00

dcache.c

[PATCH] missing unused dentry in prune_dcache()?

2006-10-28 11:30:53 -07:00

dcookies.c

Remove obsolete #include <linux/config.h>

2006-06-30 19:25:36 +02:00

direct-io.c

[PATCH] lockdep: annotate direct io

2006-07-03 15:27:06 -07:00

dnotify.c

[PATCH] file: modify struct fown_struct to use a struct pid

2006-10-02 07:57:14 -07:00

dquot.c

[PATCH] dquot: add proper locking when using current->signal->tty

2006-09-29 09:18:14 -07:00

drop_caches.c

…

eventpoll.c

[PATCH] epoll_pwait()

2006-10-11 11:14:21 -07:00

exec.c

[PATCH] namespaces: utsname: switch to using uts namespaces

2006-10-02 07:57:21 -07:00

fcntl.c

[PATCH] file: Add locking to f_getown

2006-10-02 07:57:15 -07:00

fifo.c

[PATCH] pipe.c/fifo.c code cleanups

2006-04-11 13:53:33 +02:00

file_table.c

[PATCH] file: modify struct fown_struct to use a struct pid

2006-10-02 07:57:14 -07:00

file.c

[PATCH] expand_fdtable(): remove pointless unlock+lock

2006-09-29 09:18:25 -07:00

filesystems.c

[PATCH] Ban register_filesystem(NULL);

2006-09-29 09:18:20 -07:00

fs-writeback.c

[PATCH] BLOCK: Remove dependence on existence of blockdev_superblock [try #6]

2006-09-30 20:52:26 +02:00

generic_acl.c

[PATCH] Generic infrastructure for acls

2006-09-29 09:18:24 -07:00

inode.c

[PATCH] Take i_mutex in splice_from_pipe()

2006-10-19 20:53:08 +02:00

inotify_user.c

[PATCH] inotify: fix deadlock found by lockdep

2006-07-31 13:28:41 -07:00

inotify.c

[PATCH] inotify (4/5): allow watch removal from event handler

2006-06-20 05:25:19 -04:00

internal.h

[PATCH] CONFIG_BLOCK internal.h cleanups

2006-09-30 20:52:32 +02:00

ioctl.c

Remove obsolete #include <linux/config.h>

2006-06-30 19:25:36 +02:00

ioprio.c

[PATCH] block layer: ioprio_best function fix

2006-10-12 15:09:51 +02:00

Kconfig

[CRYPTO] users: Select ECB/CBC where needed

2006-10-25 16:51:05 +10:00

Kconfig.binfmt

…

libfs.c

[PATCH] r/o bind mount prepwork: inc_nlink() helper

2006-10-01 00:39:30 -07:00

locks.c

[PATCH] file: modify struct fown_struct to use a struct pid

2006-10-02 07:57:14 -07:00

Makefile

[PATCH] jbd2: enable building of jbd2 and have ext4 use it rather than jbd

2006-10-11 11:14:16 -07:00

mbcache.c

[PATCH] mbcache: add lock annotation for __mb_cache_entry_release_unlock()

2006-09-29 09:18:07 -07:00

mpage.c

[PATCH] BLOCK: Dissociate generic_writepages() from mpage stuff [try #6]

2006-09-30 20:52:26 +02:00

namei.c

[PATCH] r/o bind mount prepwork: move open_namei()'s vfs_create()

2006-10-01 00:39:30 -07:00

namespace.c

[PATCH] namespaces: incorporate fs namespace into nsproxy

2006-10-02 07:57:20 -07:00

nfsctl.c

Remove obsolete #include <linux/config.h>

2006-06-30 19:25:36 +02:00

no-block.c

[PATCH] BLOCK: Make it possible to disable the block layer [try #6]

2006-09-30 20:52:31 +02:00

open.c

[PATCH] r/o bind mounts: prepare for write access checks: collapse if()

2006-10-01 00:39:30 -07:00

pipe.c

[PATCH] Some cleanup in the pipe code

2006-10-01 00:39:33 -07:00

pnode.c

[PATCH] core: use list_move()

2006-06-26 09:58:17 -07:00

pnode.h

…

posix_acl.c

[PATCH] kmemdup: some users

2006-10-01 00:39:19 -07:00

quota_v1.c

…

quota_v2.c

…

quota.c

[PATCH] BLOCK: Make it possible to disable the block layer [try #6]

2006-09-30 20:52:31 +02:00

read_write.c

[PATCH] Add vector AIO support

2006-10-01 00:39:29 -07:00

read_write.h

[PATCH] Remove readv/writev methods and use aio_read/aio_write instead

2006-10-01 00:39:28 -07:00

readdir.c

[PATCH] VFS: Make filldir_t and struct kstat deal in 64-bit inode numbers

2006-10-03 08:03:40 -07:00

select.c

[PATCH] enforce RLIMIT_NOFILE in poll()

2006-09-29 09:18:23 -07:00

seq_file.c

…

splice.c

[PATCH] mm: clean up pagecache allocation

2006-10-28 11:30:50 -07:00

stat.c

[PATCH] VFS: Make filldir_t and struct kstat deal in 64-bit inode numbers

2006-10-03 08:03:40 -07:00

super.c

[PATCH] VFS: Destroy the dentries contributed by a superblock on unmounting

2006-10-11 11:14:25 -07:00

sync.c

[PATCH] BLOCK: Move functions out of buffer code [try #6]

2006-09-30 20:31:19 +02:00

utimes.c

[PATCH] Create fs/utimes.c

2006-10-01 00:39:19 -07:00

xattr_acl.c

…

xattr.c

[PATCH] Introduce vfs_listxattr

2006-10-09 14:20:38 -07:00