Jan Kara 7f5aa21508 jbd2: Avoid possible NULL dereference in jbd2_journal_begin_ordered_truncate() ...

If we race with commit code setting i_transaction to NULL, we could
possibly dereference it.  Proper locking requires the journal pointer
(to access journal->j_list_lock), which we don't have.  So we have to
change the prototype of the function so that filesystem passes us the
journal pointer.  Also add a more detailed comment about why the
function jbd2_journal_begin_ordered_truncate() does what it does and
how it should be used.

Thanks to Dan Carpenter <error27@gmail.com> for pointing to the
suspitious code.

Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Acked-by: Joel Becker <joel.becker@oracle.com>
CC: linux-ext4@vger.kernel.org
CC: ocfs2-devel@oss.oracle.com
CC: mfasheh@suse.de
CC: Dan Carpenter <error27@gmail.com>

2009-02-10 11:15:34 -05:00

..

checkpoint.c

jbd2: don't give up looking for space so easily in __jbd2_log_wait_for_space

2008-11-06 22:38:07 -05:00

commit.c

Merge branch 'for_linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4

2009-01-08 17:14:59 -08:00

journal.c

jbd2: Fix return value of jbd2_journal_start_commit()

2009-02-10 11:27:46 -05:00

Kconfig

fs/Kconfig: move ext2, ext3, ext4, JBD, JBD2 out

2008-10-20 11:43:59 -07:00

Makefile

…

recovery.c

jbd2: fix error handling for checkpoint io

2008-10-10 20:29:13 -04:00

revoke.c

jdb2: replace remaining __FUNCTION__ occurrences

2008-04-17 10:38:59 -04:00

transaction.c

jbd2: Avoid possible NULL dereference in jbd2_journal_begin_ordered_truncate()

2009-02-10 11:15:34 -05:00