l0ng-ai/openidea
1
0 Fork 0
mirror of https://github.com/l0ng-ai/openidea.git synced 2026-11-07 10:16:03 -10:00
Code Issues Packages Projects Releases 1 Wiki Activity

fix(editor): give each file its own find bar, query and caret (#1296)

Browse Source 
The find bar belonged to the pane and every bar shared one query, and its effect re-ran the search and moved the caret whenever the active tab changed, so switching files dragged the previous file's search into the next one and lost its caret. Each tab now has its own find bar with its own query and options, as with IDEA's per-editor search session. The last search only pre-fills a newly opened bar (or the selection does) and drives Find Next without a bar; showing a bar again only highlights, and the caret moves only when the query or an option changes in that bar. Bars of closed tabs are dropped.

Co-authored-by: jaw52 <[email protected]>
This commit is contained in:
Jaw authored and GitHub committed 2026-11-04 23:11:05 +08:00
1 parent d032addb17
commit b31edc3482
5 files changed
+212 -67
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

e2e/editor.spec.ts
+43
View File
@@ -26,6 +26,49 @@ test("⌘F opens the find bar and highlights matches; Escape returns to the edit
await expect(editor.locator(".cm-content")).toBeFocused();
});
test("each file keeps its own find bar, query and caret", async ({ workbench: page }) => {
const find = page.getByRole("textbox", { name: "Find" });
const caret = page.getByRole("button", { name: /^\d+:\d+/ });
const tab = (name: string) => page.getByRole("tablist", { name: "Editor tabs" }).getByRole("tab", { name });
const a = await openFromTree(page, "build.gradle.kts");
await a.locator(".cm-content").click();
await page.keyboard.press("Meta+f");
await find.fill("Order");
await expect(caret).toHaveText(/\(5 chars\)/);
const caretA = await caret.textContent();
// Another file has no bar until ⌘F; opening one starts from the last search without moving the caret.
const b = await openFromTree(page, "settings.gradle.kts");
await expect(find).toBeHidden();
await b.locator(".cm-line", { hasText: "@PostMapping" }).click();
const caretB = await caret.textContent();
await page.keyboard.press("Meta+f");
await expect(find).toHaveValue("Order");
await expect(caret).toHaveText(caretB!);
await find.fill("status");
await expect(caret).toHaveText(/\(6 chars\)/);
const caretB2 = await caret.textContent();
// A third file starts from the latest search.
await openFromTree(page, "README.md");
await expect(find).toBeHidden();
await page.keyboard.press("Meta+f");
await expect(find).toHaveValue("status");
// Switching back shows each file's own query, caret untouched.
await tab("build.gradle.kts").click();
await expect(find).toHaveValue("Order");
await expect(caret).toHaveText(caretA!);
await tab("settings.gradle.kts").click();
await expect(find).toHaveValue("status");
await expect(caret).toHaveText(caretB2!);
await find.press("Escape");
await expect(find).toBeHidden();
await tab("build.gradle.kts").click();
await expect(find).toHaveValue("Order");
});
test("opening several files creates tabs and ⌘W closes the active one", async ({ workbench: page }) => {
await openFromTree(page, "build.gradle.kts");
await openFromTree(page, "settings.gradle.kts");