Compare commits

...
Author SHA1 Message Date
l0ng-ai 05b62611ff fix(settings): keep Python interpreter dialog rows aligned 2026-11-08 14:36:59 +08:00
3 changed files with 47 additions and 4 deletions

No files matched your search

+40
View File
@@ -1,5 +1,45 @@
import { expect, test } from "./fixtures"; import { expect, test } from "./fixtures";
test("Add Python Interpreter keeps environment labels and fields inside their rows", async ({ workbench: page }) => {
await page.keyboard.press("Meta+,");
const settings = page.getByRole("dialog", { name: "Settings", exact: true });
await settings.getByRole("textbox", { name: "Search settings" }).fill("Python Interpreter");
await settings
.getByRole("tree", { name: "Settings pages" })
.getByRole("treeitem", { name: "Python Interpreter", exact: true })
.click();
await settings.getByRole("button", { name: "Add Interpreter…", exact: true }).click();
const dialog = page.getByRole("dialog", { name: "Add Python Interpreter", exact: true });
await expect(dialog).toBeVisible();
for (const width of [1000, 800, 520]) {
await page.setViewportSize({ width, height: 760 });
await expect(async () => {
const labelsFit = await dialog.getByRole("list", { name: "Interpreter type" }).evaluate((list) =>
[...list.querySelectorAll("button")].every((button) => {
const box = button.getBoundingClientRect();
const range = document.createRange();
range.selectNodeContents(button);
return [...range.getClientRects()].every(
(r) => r.top >= box.top - 1 && r.bottom <= box.bottom + 1 && r.right <= box.right + 1,
);
}),
);
expect(labelsFit).toBe(true);
}).toPass({ timeout: 3000 });
const location = dialog.getByRole("textbox", { name: "Location:", exact: true });
const fieldSpacing = await location.evaluate((input) => ({
rowHeight: input.parentElement!.getBoundingClientRect().height,
fieldHeight: input.getBoundingClientRect().height,
}));
expect(fieldSpacing.rowHeight).toBeLessThanOrEqual(fieldSpacing.fieldHeight + 1);
const base = await dialog.getByRole("button", { name: "Base interpreter", exact: true }).boundingBox();
const loc = await location.boundingBox();
expect(base!.y - loc!.y - loc!.height).toBeLessThan(50);
}
});
test("Project Structure keeps edits across repeated shortcuts and applies them", async ({ workbench: page }) => { test("Project Structure keeps edits across repeated shortcuts and applies them", async ({ workbench: page }) => {
await page.keyboard.press("Meta+;"); await page.keyboard.press("Meta+;");
const dialog = page.getByRole("dialog", { name: "Project Structure", exact: true }); const dialog = page.getByRole("dialog", { name: "Project Structure", exact: true });
@@ -226,7 +226,7 @@ export function AddInterpreterDialog({
<label htmlFor={ids.existing}> <label htmlFor={ids.existing}>
<T>Interpreter:</T> <T>Interpreter:</T>
</label> </label>
<div className={`${styles.pathRow} ${styles.existingPathRow}`}> <div className={styles.pathRow}>
<Select <Select
id={ids.existing} id={ids.existing}
className={styles.pathInput} className={styles.pathInput}
@@ -152,7 +152,7 @@
/* Add Python Interpreter dialog */ /* Add Python Interpreter dialog */
.dialogBody { .dialogBody {
display: grid; display: grid;
grid-template-columns: 150px minmax(0, 1fr); grid-template-columns: minmax(150px, max-content) minmax(0, 1fr);
min-height: 300px; min-height: 300px;
} }
.kinds { .kinds {
@@ -174,6 +174,7 @@
color: var(--fg); color: var(--fg);
font: inherit; font: inherit;
text-align: left; text-align: left;
white-space: nowrap;
} }
.kindOn { .kindOn {
background: var(--bg-list-selected); background: var(--bg-list-selected);
@@ -187,12 +188,14 @@
} }
.radios { .radios {
display: flex; display: flex;
gap: 16px; flex-wrap: wrap;
gap: 6px 16px;
} }
.radio { .radio {
display: inline-flex; display: inline-flex;
align-items: center; align-items: center;
gap: 6px; gap: 6px;
white-space: nowrap;
} }
.pathRow { .pathRow {
display: flex; display: flex;
@@ -201,7 +204,7 @@
flex: 1; flex: 1;
min-width: 0; min-width: 0;
} }
.existingPathRow { .form > .pathRow {
flex: none; flex: none;
} }
.pathInput { .pathInput {