Commit Graph

187 Commits

Author SHA1 Message Date
Raphael Taylor-Davies 71efcf5ee8 Remove Rayon-based Scheduler (#6169)
* Remove scheduler

* Fix tpch

* Format
2023-04-30 19:57:41 +01:00
Yijie Shen d9d0a47643 Deprecate JIT (#6164) 2023-04-30 23:01:46 +08:00
Andrew Lamb 8bb971d3d8 Update rust_lint.sh to include cargo doc (#6070) 2023-04-21 15:37:55 +08:00
Andrew Lamb 3df9f8002c Remove old ci directory (#3198)
* Remove old ci directory

* Consolidate actual CI scripts

* Restore rust_lint.sh, add comments
2022-08-19 09:44:42 -04:00
Raphael Taylor-Davies 36b82d7bc6 Run clippy with optional features (#2918) 2022-07-16 09:06:09 -04:00
Tim Van Wassenhove 522ea52fcd Issue 2321: Add code formatting instructions to CONTRIBUTING (#2444)
* ehance documentation on how to format/check your code

* Update dev/format-code.sh

Co-authored-by: Raphael Taylor-Davies <1781103+tustvold@users.noreply.github.com>

* Update dev/format-code.sh

Co-authored-by: Raphael Taylor-Davies <1781103+tustvold@users.noreply.github.com>

* attempt to share lint infra

* corrected invalid /

* mention scripts in formatting instructions

Co-authored-by: Raphael Taylor-Davies <1781103+tustvold@users.noreply.github.com>
2022-05-06 09:11:45 -06:00
Kazuaki Ishizaki e991c5be52 ARROW-12419: [Java] Remove to download flatc binary for s390x
This PR is a follow-up of #10058. #10058 avoids executing flatc during the Java build process by statically generating Java files from the schema. Now, flatc is not necessary.

Since flatc for s390x is explicitly downloaded in a script, we can drop this download.

Closes #10067 from kiszk/ARROW-12419

Authored-by: Kazuaki Ishizaki <ishizaki@jp.ibm.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
2021-04-18 05:15:03 +09:00
Krisztián Szűcs bfe389d5f5 ARROW-12381: [Packaging][Python] macOS wheels are built with wrong package kind
Closes #10027 from kszucs/wheel-package-kind

Authored-by: Krisztián Szűcs <szucs.krisztian@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
2021-04-15 10:33:50 +09:00
Antoine Pitrou eada649e78 ARROW-12262: [Doc] Enable S3 and Flight in docs build
Also use Ubuntu 20.04 by default, instead of 18.04.

Closes #9933 from pitrou/ARROW-12262-ubuntu-docs

Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
2021-04-14 15:06:57 +02:00
Sutou Kouhei bd99e26b38 ARROW-12352: [CI][R][Windows] Remove needless workaround for MSYS2
repo.msys2.org is alive. sf.net may be fragile than repo.msys2.org.

See also ARROW-10202: https://issues.apache.org/jira/browse/ARROW-10202

Closes #10004 from kou/ci-r-remove-needless-msys2-workaround

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Krisztián Szűcs <szucs.krisztian@gmail.com>
2021-04-13 12:57:25 +02:00
Nic Crane 14b5218806 ARROW-12236: [R][CI] Add check that all docs pages are listed in _pkgdown.yml
Added a bash script to the workflow that checks that all .Rd files in /r/man/ that aren't internal reference ones are listed as sections in the _pkgdown.yml reference sections

Closes #9946 from thisisnic/ARROW-12236-pkgdown-ci

Authored-by: Nic Crane <thisisnic@gmail.com>
Signed-off-by: Neal Richardson <neal.p.richardson@gmail.com>
2021-04-12 16:39:25 -07:00
Joris Van den Bossche ec880808b0 ARROW-12314: [Python] Accept columns as set in parquet read_pandas
Closes #9966 from jorisvandenbossche/ARROW-12314-read_pandas-sets

Authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
2021-04-12 14:21:25 -04:00
Neal Richardson e433ca40db ARROW-12098: [R] Catch cpp build failures on linux
The installation looks like this now in the default case if the build script errors:

```
* installing *source* package ‘arrow’ ...
** using staged installation
*** Found local C++ source
*** Building C++ libraries
**** cmake
**** arrow
**** Error building Arrow C++. Re-run with ARROW_R_DEV=true for debug information.
------------------------- NOTE ---------------------------
See https://arrow.apache.org/docs/r/articles/install.html
for help installing Arrow C++ libraries
---------------------------------------------------------
```

This PR also (1) restores the arrow-without-arrow wrapping (from #9689) and (2) adds an .onAttach message for the arrow-without-arrow case to hopefully alert users earlier that they have an incomplete/useless build. If you do get a without-arrow build, this is what the loading message looks like:

```
> library(arrow)
The Arrow C++ library is not available. To retry installation with debug output, run:
    install_arrow(verbose = TRUE)
See https://arrow.apache.org/docs/r/articles/install.html for more guidance and troubleshooting.

Attaching package: ‘arrow’

The following object is masked from ‘package:utils’:

    timestamp

```

It *also* adds an .onAttach message if you have a build with optional features disabled (e.g. S3, lz4, etc.):

```
> library(arrow)
See arrow_info() for available features

Attaching package: ‘arrow’

The following object is masked from ‘package:utils’:

    timestamp
```

`arrow_info()` will then (on Linux only) also print a message pointing you to the installation vignette if there are missing features:

```
> arrow_info()
Arrow package version: 3.0.0.9000

Capabilities:

dataset    TRUE
parquet    TRUE
s3         TRUE
utf8proc   TRUE
re2        TRUE
snappy     TRUE
gzip       TRUE
brotli     TRUE
zstd       TRUE
lz4        TRUE
lz4_frame  TRUE
lzo       FALSE
bz2        TRUE
jemalloc   TRUE
mimalloc  FALSE

To reinstall with more features enabled, see
  https://arrow.apache.org/docs/r/articles/install.html

...
```

Certain compression libraries (like lzo) are on a blocklist that excludes them from this extra messaging. The purpose of all of this is to give more hints to users when they have limited builds and give them guidance on how to enhance them, while at the same time not overly broadcasting this (which would promote FUD) and trying to be clear that you don't *always* have to `install_arrow()` after `install.packages()`.

Closes #9896 from nealrichardson/nix-install-debug

Authored-by: Neal Richardson <neal.p.richardson@gmail.com>
Signed-off-by: Neal Richardson <neal.p.richardson@gmail.com>
2021-04-09 10:19:51 -07:00
Dominik Moritz bec1082756 ARROW-12239: [JS] Switch to yarn
Closes #9918 from domoritz/yarn

Lead-authored-by: Dominik Moritz <domoritz@gmail.com>
Co-authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
2021-04-09 12:15:27 +09:00
Antoine Pitrou 36930b6672 ARROW-12112: [CI] Reduce footprint of conda-integration image
This seems to save about 2GB in the image's root directory.

Closes #9891 from pitrou/ARROW-12191-conda-integration

Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Krisztián Szűcs <szucs.krisztian@gmail.com>
2021-04-07 10:45:16 +02:00
Andrew Lamb 4a53414694 ARROW-12204: [Rust][CI] Reduce size of Rust build artifacts in integration test
# Rationale

The [integration test](https://github.com/apache/arrow/pull/9884/checks?check_run_id=2263730460) has a fixed size builder docker image and has builds from several Arrow implementations.

The Rust build artifacts (compiled binaries) in the integration tests still consume ~ 1GB of space even after https://github.com/apache/arrow/pull/9879 (see @pitrou 's comment on  https://github.com/apache/arrow/pull/9884#issuecomment-813037756).

# Changes
1. Only build the `arrow-integration-testing` crate (which has the binaries needed for integration testing) rather than all of them
2. Remove incremental build artifacts
3. Moves `cargo check`  to ensure we can build arrow without default features to a github action and out of the integration test

This should both speed up the rust build as part of integration testing as well as reduce the amount of disk space required in the builder (both peak and after the rust build).

# Results

According to this [log](https://pipelines.actions.githubusercontent.com/CKhEcbzaHKPSiCoVWyWCFardoFMA9UN2zDnXYiBlRYO31o0IIv/_apis/pipelines/1/runs/179726/signedlogcontent/3?urlExpires=2021-04-05T12%3A37%3A13.1888704Z&urlSigningMethod=HMACV1&urlSignature=zROZZZham0BGH5f2vbe65n3DL13xXLgD9RJXybRqBAA%3D)  after this PR's changes, the rust artifacts are much smaller.

Note we could still save space by removing the rust toolchain and `.cargo` files but I think that can be an optimization for another time:
```
2021-04-05T11:30:22.6164120Z 244M	/opt/go/pkg
2021-04-05T11:30:22.6164599Z 393M	/opt/go
2021-04-05T11:30:22.7201596Z 110M	/opt/conda/envs/arrow/share
2021-04-05T11:30:22.7220002Z 171M	/opt/conda/envs/arrow/libexec/gcc/x86_64-conda-linux-gnu/9.3.0
2021-04-05T11:30:22.7220911Z 171M	/opt/conda/envs/arrow/libexec/gcc/x86_64-conda-linux-gnu
2021-04-05T11:30:22.7221489Z 171M	/opt/conda/envs/arrow/libexec/gcc
2021-04-05T11:30:22.7221945Z 186M	/opt/conda/envs/arrow/libexec
2021-04-05T11:30:22.7314210Z 186M	/opt/conda/envs/arrow/lib/valgrind
2021-04-05T11:30:22.8109246Z 129M	/opt/conda/envs/arrow/lib/python3.8/site-packages
2021-04-05T11:30:22.8290900Z 177M	/opt/conda/envs/arrow/lib/python3.8
2021-04-05T11:30:22.8636030Z 1.8G	/opt/conda/envs/arrow/lib
2021-04-05T11:30:22.9861104Z 171M	/opt/conda/envs/arrow/include/boost
2021-04-05T11:30:23.0128341Z 260M	/opt/conda/envs/arrow/include
2021-04-05T11:30:23.0163805Z 417M	/opt/conda/envs/arrow/bin
2021-04-05T11:30:23.0449297Z 102M	/opt/conda/envs/arrow/x86_64-conda-linux-gnu/sysroot/usr/lib64
2021-04-05T11:30:23.0525177Z 133M	/opt/conda/envs/arrow/x86_64-conda-linux-gnu/sysroot/usr
2021-04-05T11:30:23.0526023Z 139M	/opt/conda/envs/arrow/x86_64-conda-linux-gnu/sysroot
2021-04-05T11:30:23.0527418Z 189M	/opt/conda/envs/arrow/x86_64-conda-linux-gnu
2021-04-05T11:30:23.0612702Z 108M	/opt/conda/envs/arrow/jre/lib
2021-04-05T11:30:23.0613140Z 109M	/opt/conda/envs/arrow/jre
2021-04-05T11:30:23.0618402Z 3.2G	/opt/conda/envs/arrow
2021-04-05T11:30:23.0618775Z 3.2G	/opt/conda/envs
2021-04-05T11:30:23.1055113Z 159M	/opt/conda/lib
2021-04-05T11:30:23.5619580Z 146M	/opt/conda/pkgs/valgrind-3.15.0-he513fc3_0/lib/valgrind
2021-04-05T11:30:23.5625488Z 146M	/opt/conda/pkgs/valgrind-3.15.0-he513fc3_0/lib
2021-04-05T11:30:23.5626989Z 146M	/opt/conda/pkgs/valgrind-3.15.0-he513fc3_0
2021-04-05T11:30:23.5793611Z 349M	/opt/conda/pkgs
2021-04-05T11:30:23.5845265Z 3.7G	/opt/conda
2021-04-05T11:30:23.5846086Z 4.1G	/opt
2021-04-05T11:30:23.6810817Z 131M	/root/.m2/repository/org
2021-04-05T11:30:23.6813841Z 260M	/root/.m2/repository
2021-04-05T11:30:23.6814253Z 260M	/root/.m2
2021-04-05T11:30:23.7360947Z 124M	/root/.cargo/registry/index/github.com-1ecc6299db9ec823/.git/objects/pack
2021-04-05T11:30:23.7362421Z 124M	/root/.cargo/registry/index/github.com-1ecc6299db9ec823/.git/objects
2021-04-05T11:30:23.7376583Z 125M	/root/.cargo/registry/index/github.com-1ecc6299db9ec823/.git
2021-04-05T11:30:23.7447433Z 133M	/root/.cargo/registry/index/github.com-1ecc6299db9ec823
2021-04-05T11:30:23.7448341Z 133M	/root/.cargo/registry/index
2021-04-05T11:30:23.7448796Z 232M	/root/.cargo/registry
2021-04-05T11:30:23.7449202Z 245M	/root/.cargo
2021-04-05T11:30:23.8658627Z 126M	/root/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/share/doc/rust/html/core
2021-04-05T11:30:23.8663924Z 423M	/root/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/share/doc/rust/html
2021-04-05T11:30:23.8668130Z 423M	/root/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/share/doc/rust
2021-04-05T11:30:23.8669570Z 423M	/root/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/share/doc
2021-04-05T11:30:23.8670941Z 423M	/root/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/share
2021-04-05T11:30:23.8672364Z 149M	/root/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib
2021-04-05T11:30:23.8673637Z 155M	/root/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu
2021-04-05T11:30:23.8674758Z 157M	/root/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib
2021-04-05T11:30:23.8675721Z 376M	/root/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib
2021-04-05T11:30:23.8676657Z 865M	/root/.rustup/toolchains/stable-x86_64-unknown-linux-gnu
2021-04-05T11:30:23.8677417Z 865M	/root/.rustup/toolchains
2021-04-05T11:30:23.8677825Z 865M	/root/.rustup
2021-04-05T11:30:23.8678171Z 1.5G	/root
2021-04-05T11:30:23.9219564Z 113M	/go/pkg/mod/google.golang.org/genproto@v0.0.0-20200911024640-645f7a48b24f/googleapis
2021-04-05T11:30:23.9220667Z 113M	/go/pkg/mod/google.golang.org/genproto@v0.0.0-20200911024640-645f7a48b24f
2021-04-05T11:30:23.9306825Z 129M	/go/pkg/mod/google.golang.org
2021-04-05T11:30:23.9346436Z 264M	/go/pkg/mod
2021-04-05T11:30:23.9346938Z 264M	/go/pkg
2021-04-05T11:30:23.9347281Z 264M	/go
2021-04-05T11:30:23.9383575Z 129M	/build/cpp/src/arrow
2021-04-05T11:30:23.9384025Z 131M	/build/cpp/src
2021-04-05T11:30:23.9387580Z 223M	/build/cpp
2021-04-05T11:30:23.9387915Z 223M	/build
2021-04-05T11:30:23.9388188Z 6.1G	/
2021-04-05T11:30:24.0044084Z 846M	/arrow/
```

Closes #9889 from alamb/alamb/reduce_integration_size

Authored-by: Andrew Lamb <andrew@nerdnetworks.org>
Signed-off-by: Andrew Lamb <andrew@nerdnetworks.org>
2021-04-06 06:54:52 -04:00
Andrew Lamb 1c9fedb31e ARROW-12112: [Rust] Create and store less debug information in CI and integration tests
# Rationale
Rust debug symbols are quite verbose, taking up memory during the final link time as well as significant disk space. Turning off the creation of symbols should save us compile / test time for CI as well as space on the integration test

# Change
Do not produce debug symbols on Rust CI (keep enough to have line numbers in `panic!` traceback, but not enough to interpret a core file, which no one does to my knowledge anyways)

Note that the integration test passed: https://github.com/apache/arrow/pull/9879/checks?check_run_id=2256148363

Closes #9879 from alamb/less_symbols_in_integration

Authored-by: Andrew Lamb <andrew@nerdnetworks.org>
Signed-off-by: Andrew Lamb <andrew@nerdnetworks.org>
2021-04-03 13:03:59 -04:00
Weston Pace e70f7db4a5 ARROW-12143: [CI] R builds should timeout and fail after some threshold and dump the output.
This adds a one hour timeout to the R builds.  It changes the R CI test script to use `reporter="location"` by default.  It adds a dump test logs step to the end of the build that will always dump the test output regardless of success/failure.

These three changes combined will make it much easier to debug test failures in R tests.

Closes #9846 from westonpace/feature/arrow-12143

Lead-authored-by: Weston Pace <weston.pace@gmail.com>
Co-authored-by: Jonathan Keane <jkeane@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
2021-03-31 19:11:28 -04:00
Krisztián Szűcs 27231a3f31 ARROW-12139: [Python][Packaging] Use vcpkg to build macOS wheels
Closes #9767 from kszucs/mac-wheel-vcpkg

Authored-by: Krisztián Szűcs <szucs.krisztian@gmail.com>
Signed-off-by: Krisztián Szűcs <szucs.krisztian@gmail.com>
2021-03-30 11:46:35 +02:00
Sutou Kouhei 1659018bb2 ARROW-12131: [CI][GLib] Ensure upgrading MSYS2
We need to refresh package database for ucrt64 repository after system upgrade.

See also: https://github.com/msys2/setup-msys2/issues/119

Closes #9832 from kou/ci-glib-windows

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
2021-03-30 05:13:03 +09:00
jpeeter a774371961 ARROW-11838: [C++] Support IPC reads with shared dictionaries.
The only code change required, AFAICT, is the calculation of num_dicts, which is no longer simply the number of fields, but rather the unique number of id's they point to. I'm calculating this on-demand, as it's quite cheap and not frequently called, but could also (p)re-compute this on every addField.

For now, I've added tests that read materialised data generated from Java, as we don't support writing IPC with shared dictionaries in C++ either yet (and out of scope here).

Down the line, I would like full read & write support for shared dictionaries across at least C++, Python, Java and Julia, so I'll be coming back to this with follow-up PR's where needed. As part of that, I'll also change the tests to no longer rely on materialised files, but use the round-trip mechanism.

Closes #9629 from jmgpeeters/ARROW-11838

Lead-authored-by: jpeeter <jpeeter@loswjpeeter1.intra.gsacapital.com>
Co-authored-by: jmgpeeters <joris.mg.peeters@gmail.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
2021-03-29 15:59:53 +02:00
Jonathan Keane 6e56680caa ARROW-11914: [R] [CI] r-sanitizer nightly is broken
This resolves the sanitizer error (thank you @lidavidm for the c++ solution!). I also added a step to print `testthat.out` if `RDsan` fails which we weren't doing before. Hopefully that helps diagnose these a bit easier in the future.

Closes #9814 from jonkeane/ARROW-11914-r-sanitizer

Authored-by: Jonathan Keane <jkeane@gmail.com>
Signed-off-by: Neal Richardson <neal.p.richardson@gmail.com>
2021-03-26 15:29:50 -07:00
Matthew Topol 5e98e6ff13 ARROW-12045: [Go][Parquet] Initial Chunk of Parquet port to Go
Based on the c++ implementation but tuned and optimized for Go, I spent the first couple months this year creating a Go implementation for Parquet with the goal of native/easy integration with the Arrow library while still being highly performant and at minimum reaching feature parity with the C++ implementation.

Based on the conversations on the JIRA card, rather than dumping a huge code bomb (there's a ton), I've chunked it up. This is the initial chunk of code comprising of an internal utils directory that is analogous to the cpp/arrow/utils/ bit readers/writers/bit run readers/etc. which were ultimately used by the go implementation, while using c2goasm to reach the performance necessary for certain areas.

This is part 1 of the implementation as I chunk it up and push it out. I'll wait for each chunk to get merged before pushing the next PR in order to make sure that everything stays in sync.

CC: @emkornfield @wesm @sbinet @nickpoorman

Closes #9671 from zeroshade/arrow-7905-p1

Authored-by: Matthew Topol <mtopol@factset.com>
Signed-off-by: Micah Kornfield <emkornfield@gmail.com>
2021-03-26 13:37:14 -07:00
Maarten A. Breddels 3ee637f427 ARROW-10306: [C++] Add string replacement kernel
Two new kernels
 * replace_substring like Python's str.replace
 * replace_substring_re2  like Python's re.sub

Closes #8468 from maartenbreddels/ARROW-10306

Lead-authored-by: Maarten A. Breddels <maartenbreddels@gmail.com>
Co-authored-by: Neal Richardson <neal.p.richardson@gmail.com>
Co-authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Neal Richardson <neal.p.richardson@gmail.com>
2021-03-25 19:17:21 -07:00
Sutou Kouhei 1e7fb1ff66 ARROW-11975: [CI][GLib] Remove needless libgccjit
It blocks gcc update.

Closes #9718 from kou/glib-ci

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
2021-03-16 20:03:15 +01:00
Krisztián Szűcs 1ed4646f24 ARROW-10349: [Python] Build and publish aarch64 wheels
This should work in theory, I'm building the image to see how well does vcpkg support arm packages.

```bash
ARCH=arm64v8 archery docker build python-wheel-manylinux-2014
```

Closes #9285 from kszucs/manylinux-arm64

Lead-authored-by: Krisztián Szűcs <szucs.krisztian@gmail.com>
Co-authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Krisztián Szűcs <szucs.krisztian@gmail.com>
2021-03-15 11:52:48 +01:00
Joris Van den Bossche 919d71a07d ARROW-11923: [CI] Update branch name for dask dev integration tests
Closes #9669 from jorisvandenbossche/ARROW-11923

Authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
2021-03-11 06:35:16 +09:00
Ian Cook cee05a9de4 ARROW-11580: [C++] Add CMake option ARROW_DEPENDENCY_SOURCE=VCPKG
This builds upon ARROW-11340 and makes it simpler to use vcpkg for dependencies.

Previously, to use vcpkg it was necessary to specify:
- `-DARROW_DEPENDENCY_SOURCE=SYSTEM`
- `-DCMAKE_TOOLCHAIN_FILE=/path/to/vcpkg.cmake`
- `-DVCPKG_TARGET_TRIPLET=xxx-yyy-zzz`
- Various`*_MSVC_*` variables on Windows
- Various `*_ROOT`, `*_LIB`, and `*_INCLUDE` variables in some cases
- `-D_VCPKG_INSTALLED_DIR=/path/to/vcpkg/installed/dir` in some cases

Now all that is necessary is:
- `-DARROW_DEPENDENCY_SOURCE=VCPKG`

Other variables are now optional and can be specified to override default behaviors.

After this is merged, I will make additional updates to the docs, focusing initially on Windows (ARROW-11336).

Closes #9553 from ianmcook/ARROW-11580-take2

Authored-by: Ian Cook <ianmcook@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
2021-03-05 12:35:24 +09:00
Kenta Murata 2aecd773f5 ARROW-11470: [C++] Detect overflow on computation of tensor strides
The overflow by integer multiplication are occurred in `ComputeRowMajorStrides`, `ComputeColumnMajorStrides`, and `CheckTensorStridesValidity`.

This should fix the following issues:
- https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=29748
- https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=29745

Found by OSS-Fuzz.

Closes #9395 from mrkn/ARROW-11470

Authored-by: Kenta Murata <mrkn@mrkn.jp>
Signed-off-by: Antoine Pitrou <antoine@python.org>
2021-02-18 12:31:27 +01:00
Ian Cook f2119b39aa ARROW-11340: [C++] Add vcpkg.json manifest to cpp project root
@kszucs could you review this please? My main purpose in adding this is to improve the experience for Arrow C++ devs using Windows, but I noticed it also relates to your [TODO in #9096](https://github.com/apache/arrow/pull/9096/files#diff-990134cce6657dbbcf95457cf1a56810a7efa1f6cd58ecc27557c7d6ff45b533R67-R68). vcpkg does not have any `requirements.txt`-style package enumeration mechanism, but it supports this JSON manifest as a mechanism of defining dependencies.

In the `vcpkg install` command, you can specify the path to the directory containing this manifest file with `--x-manifest-root` which later will change to `--manifest-root`. See details at https://vcpkg.readthedocs.io/en/stable/specifications/manifests/.

There are some differences between the packages listed in this manifest versus the packages you listed in the `vcpkg install` commands in #9096
- This installs `gtest` and `benchmark`
- This installs `boost` instead of separate `boost-filesystem`, `boost-regex`, etc.
- This does not explicitly include the `core` feature of `aws-sdk-cpp` because explicitly including it causes an error, and it gets installed anyway

Closes #9287 from ianmcook/ARROW-11340

Lead-authored-by: Ian Cook <ianmcook@gmail.com>
Co-authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Krisztián Szűcs <szucs.krisztian@gmail.com>
2021-02-17 18:13:36 +01:00
Kazuaki Ishizaki 49102e850d ARROW-8797: [C++] Read RecordBatch in a different endian
This PR creates a test to receive RecordBatch for different endian (e.g. receive RecordBatch with big-endian schema on little-endian platform).

This PR changes
1.  Introduce Endianness enum class to represent endianness
2.  Add a new flag `endianness` to `arrow::schema` to represent endianness of Array in `RecordBatch`.
3.  Eagerly convert non-nativeendian data to nativeendian data in a batch if `IpcReadOption.use_native_endian = true` (`true` by default).
4.  Add golden arrow files for integration test in both endians and test script

Regarding 3., other possible choices are as follows:
- Lazily convert non-nativeendian data to nativeendian data for a column in each RecordBatch.
Pros: Avoid conversion for columns that will not be read
Cons: Complex management of endianness of each column. Inconsistency of endianness between schema and column data.
- Convert non-nativeendian data to nativeendian data when each element is read
Pros: Can keep the original schema without batch conversion
Cons: 1) Each RecordBatch may need an additional field to show whether the endian conversion is necessary or not. 2) Need to update test cases to accept different endianness between expected and actual schemas.

Now, this PR uses the simplest approach (always see native endianness in schemas) that eagerly converts all of the columns in a batch.

TODO

- [x] Support to convert endian of each element for primitive types
- [x] Support to convert endian of each element for complex types
- [x] Support to convert endian of each element for all types for stream
- [x] Add golden arrow files in both endians

For creating this PR, @kou helps me greatly (prototype of arrow::schema and teaching me about RecordBatch).

Closes #7507 from kiszk/ARROW-8797

Lead-authored-by: Kazuaki Ishizaki <ishizaki@jp.ibm.com>
Co-authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
2021-02-17 15:44:14 +01:00
Neal Richardson 8d731984fe ARROW-9856: [R] Add bindings for string compute functions
Includes dependency toolchain updates (utf8proc, re2) and bindings for

* "nchar", "str_length" -> "binary_length"
* "tolower", "str_to_lower"  -> "utf8_lower"
* "toupper", "str_to_upper" -> "utf8_upper"
* "str_trim" is handled a little differently since it's one function in `stringr` but three functions in arrow (utf8_ltrim_whitespace, utf8_rtrim_whitespace, utf8_trim_whitespace)

Closes #9423 from nealrichardson/r-strings

Authored-by: Neal Richardson <neal.p.richardson@gmail.com>
Signed-off-by: Neal Richardson <neal.p.richardson@gmail.com>
2021-02-16 13:30:35 -08:00
Antoine Pitrou 020a40eb5c ARROW-11417: [Integration] Add integration tests for buffer compression
The tests use "gold" files generated by PyArrow 2.0.0 and are only enabled for C++.

Closes #9408 from pitrou/ARROW-11417-compression-integration

Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
2021-02-09 19:12:59 +01:00
Hongze Zhang 1fc791b1a4 ARROW-7808: [Java][Dataset] Implement Dataset Java API by JNI to C++
Add following Datasets APIs to Java:

- DatasetFactory
- Dataset
- Scanner
- ScanTask
- ScanTask.BatchIterator

Add a native dataset path to bridge c++ Datasets components to Java:

- NativeDatasetFactory (c++ class : DatasetFactory)
- NativeDataset (c++ class: Dataset)
- NativeScanner (c++ class: DisposableScannerAdaptor)

Following c++ components are not JNI-mapped to keep the initial implementation simple:

- Fragment
- ScanTask
- (arrow::)RecordBatchIterator

Add following API to `FileSystemDatasetFactory` to avoid passing file system objects via JNI bridge:

- `FileSystemDatasetFactory::Make( std::string uri, std::shared_ptr<FileFormat> format, FileSystemFactoryOptions options)`

Unit tests are based on `FileSystemDatasetFactory`.

Closes #7030 from zhztheplayer/ARROW-7808

Authored-by: Hongze Zhang <hongze.zhang@intel.com>
Signed-off-by: Micah Kornfield <emkornfield@gmail.com>
2021-02-09 08:59:00 -08:00
Bryan Cutler ee8f3eb1ba ARROW-10457: [CI] Fix Spark integration tests with branch-3.0
This adds an additional docker-compose task that will test a Spark branch with the latest PyArrow, instead of the default which also builds Spark with the latest Arrow Java. This is so existing Spark releases with fixed Arrow Java dependencies can still be tested with current PyArrow changes to ensure there is still compatibility. The nightly test against Spark branch-3.0 is changed to use this new task.

Closes #9210 from BryanCutler/ci-spark-branch-3.0-ARROW-10457

Authored-by: Bryan Cutler <cutlerb@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
2021-02-05 09:27:22 +09:00
Neal Richardson 31c1ae5986 ARROW-11350: [C++] Bump dependency versions
Where newer versions were available but we could not upgrade, I left comments in the versions.txt file for future reference.

This PR turns off re2 in the R package builds since we don't use it (yet).

Closes #9296 from nealrichardson/bump-mimalloc

Lead-authored-by: Neal Richardson <neal.p.richardson@gmail.com>
Co-authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
2021-02-03 15:06:38 +09:00
Sutou Kouhei 8f65154156 ARROW-11449: [CI][R][Windows] Use ccache
38m -> 20m

Closes #9383 from kou/ci-r-windows-ccache

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Neal Richardson <neal.p.richardson@gmail.com>
2021-02-01 08:17:40 -08:00
Antoine Pitrou 251b635bc7 ARROW-11377: [C++][CI] Add Thread Sanitizer nightly build
Closes #9317 from pitrou/ARROW-11377-tsan-nightly

Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
2021-01-26 14:33:38 +01:00
Krisztián Szűcs 2d5688c061 [Release] Update versions for 4.0.0-SNAPSHOT 2021-01-18 22:43:08 +01:00
Krisztián Szűcs dac83a05ef [Release] Update versions for 3.0.0 2021-01-18 22:33:19 +01:00
Krisztián Szűcs b26b2cf17c ARROW-11212: [Packaging][Python] Use vcpkg as dependency source for manylinux and windows wheels
Also resolves:
- ARROW-11213: [Packaging][Python] Dockerize wheel building on windows
- ARROW-11215: [CI] Use named volumes by default for caching in docker-compose
- ARROW-11231: [Python][Packaging] Enable mimalloc in wheels

Main features:
- dockerize windows builds
- use vcpkg as the dependency source where we can explicitly pin a working version without worrying about the drag of build environment over time

Potential follow-up:
- use vcpkg on macos as well

cc @kou @xhochy

## Manylinux testing

Should be straightforward (I'm going to shared pre-built images for quicker testing).

## Windows testing

Only windows host is able to run windows containers. I'm virtualizing windows on macOS (should work on linux as well) using virtualbox:

```bash
git clone https://github.com/StefanScherer/windows-docker-machine
cd windows-docker-machine
# grant more resources in the vagrantfile under the virtualbox section (I use 8 cores and 16GiB of ram)
vagrant up --provider virtualbox 2019-box
docker context ls
docker context use 2019-box
docker image ls
```

Now docker should use the windows docker daemon.

```bash
pip install -e dev/archery[docker]
# the volumes defined in the docker compose file should be commented out and pass arrow's source explicitly
# this is required because compose is being executed on a unix host and the directory is mounted through a virtual machine
PYTHON=3.6 archery docker run --no-pull --using-docker-cli -v C:$(pwd):C:/arrow python-wheel-windows-vs2017 cmd.exe
# then within the container execute a build or do other interactive things
arrow\ci\scripts\python_wheel_windown_build.bat
```

Closes #9096 from kszucs/wheel-vcpkg

Lead-authored-by: Krisztián Szűcs <szucs.krisztian@gmail.com>
Co-authored-by: Sutou Kouhei <kou@clear-code.com>
Co-authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
2021-01-15 08:47:17 +09:00
Antoine Pitrou 3a0c1379d9 ARROW-10264: [Python] Fix failing hdfs test
Closes #9192 from jorisvandenbossche/ARROW-10264-hdfs-tests

Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
2021-01-14 18:02:25 +01:00
Sutou Kouhei b3f1e8b51c ARROW-11234: [CI][Ruby][macOS] Reduce CI time
21m -> 12m

Closes #9185 from kou/ci-ruby-macos

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
2021-01-13 11:11:37 +01:00
Sutou Kouhei f57db6d838 ARROW-11219: [CI][Ruby][MinGW] Reduce CI time
36m -> 12m

Closes #9173 from kou/ci-ruby-mingw

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Krisztián Szűcs <szucs.krisztian@gmail.com>
2021-01-12 16:32:32 +01:00
Sutou Kouhei 5b00b58a54 ARROW-10777: [Packaging][Python] Build sdist by Crossbow
Closes #9145 from kou/packaging-python-sdist

Lead-authored-by: Sutou Kouhei <kou@clear-code.com>
Co-authored-by: Krisztián Szűcs <szucs.krisztian@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
2021-01-12 15:49:30 +09:00
Neal Richardson 566369e0b0 ARROW-10803: Support R >= 3.3 and add CI
Includes fixes for compiling on R 3.4 and R 3.3, plus a crossbow job to build on old R versions

Closes #8833 from nealrichardson/old-r-versions

Lead-authored-by: Neal Richardson <neal.p.richardson@gmail.com>
Co-authored-by: Romain Francois <romain@rstudio.com>
Signed-off-by: Neal Richardson <neal.p.richardson@gmail.com>
2021-01-11 11:28:27 -08:00
Antoine Pitrou 469e523102 ARROW-11009: [C++] Allow changing default memory pool with an environment variable
ARROW_DEFAULT_MEMORY_POOL can take the name of the desired memory pool backend
('jemalloc', 'mimalloc', 'system').

Closes #9105 from pitrou/ARROW-11009-memory-pool-env-var

Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Benjamin Kietzman <bengilgit@gmail.com>
2021-01-11 09:28:53 -05:00
Sutou Kouhei dc50aaf47c ARROW-11139: [GLib] Add support for extension type
Closes #9109 from kou/glib-extension-type

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
2021-01-06 13:44:00 +09:00
Sutou Kouhei 9842421fcb ARROW-10604: [GLib][Ruby] Add support for 256-bit decimal
Closes #8919 from kou/glib-decimal256

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
2020-12-21 09:58:05 +09:00
Jonathan Keane b88ee0d5fd ARROW-10856: [R] CC and CXX environment variables passing to cmake
Ensure that the environment variables are properly passed to cmake.

Closes #8932 from jonkeane/centos-ARROW-10856

Authored-by: Jonathan Keane <jkeane@gmail.com>
Signed-off-by: Neal Richardson <neal.p.richardson@gmail.com>
2020-12-18 16:04:34 -08:00