langchain-ai/deepagents
1
0
Fork 0
mirror of https://github.com/langchain-ai/deepagents.git synced 2026-07-22 09:45:24 -04:00
Code Issues 169 Packages Projects Releases 16 Wiki Activity

fix(code): remove MCP OAuth success page message shift (#4463)

Browse Source 
The MCP OAuth loopback callback success page rewrote its message text
~1.5s after load (after a best-effort `window.close()`), producing a
visible text "shift" on the page. Since the static message ("MCP
authorization complete. You can close this tab and return to your
terminal.") already reads correctly whether or not the tab closes, this
drops the DOM `textContent` rewrite (and the now-unused
`id="oauth-message"`) and keeps only the best-effort `window.close()`.
The message no longer changes.

## Test Plan
- [ ] Complete an MCP OAuth login where the browser is OS-opened (normal
case) and confirm the success page text stays constant (no shift) and
the tab does not falsely disappear.

Made by [Open
SWE](https://openswe.vercel.app/agents/bcb41636-7d5a-faf8-0728-553ffa8c14e9)

Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com>
This commit is contained in:
Mason Daugherty
2026-07-05 23:51:15 -04:00
committed by GitHub
parent cd21d57969
commit 69bb06c068
1 changed files with 6 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files
libs/code/deepagents_code/mcp_auth.py
+6 -13
View File
@@ -862,19 +862,12 @@ def _oauth_result_html(
escaped = html.escape(message)
# `window.close()` is only honored for tabs the script itself opened
# (browser policy). The loopback flow launches the browser via
# `webbrowser.open`, so the callback tab was opened by the OS rather than
# by a script and the browser refuses to close it. Attempt the close for
# the rare script-opened case, then rewrite the message so it stays
# accurate when the tab stays open instead of promising it will vanish.
# `webbrowser.open`, so the callback tab was usually opened by the OS and
# the browser refuses to close it. Attempt the close for the rare
# script-opened case; the static message already reads correctly whether
# or not the tab closes, so nothing is rewritten and the text never shifts.
auto_close = (
"<script>setTimeout(function(){"
"window.close();"
"setTimeout(function(){"
"var m=document.getElementById('oauth-message');"
"if(m){m.textContent="
"'You can close this tab and return to your terminal.';}"
"},500);"
"},1000);</script>"
"<script>setTimeout(function(){window.close();},1000);</script>"
if status == "success"
else ""
)
@@ -896,7 +889,7 @@ def _oauth_result_html(
"</style></head><body>"
'<main class="panel">'
f'<div class="mark" style="background:{background};color:{accent}">{mark}</div>'
f'<h1>{escaped_heading}</h1><p id="oauth-message">{escaped}</p>'
f"<h1>{escaped_heading}</h1><p>{escaped}</p>"
"</main>"
f"{auto_close}"
"</body></html>"