langchain-ai/deepagents
1
0
Fork 0
mirror of https://github.com/langchain-ai/deepagents.git synced 2026-07-15 11:55:45 -04:00
Code Issues 169 Packages Projects Releases 16 Wiki Activity

[PR #959] [CLOSED] fix(cli): use LocalShellBackend for shell access, allowing subagent access #1012

New Issue
Closed
opened 2026-02-16 09:17:55 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 09:17:55 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/langchain-ai/deepagents/pull/959
Author: @vtrivedy
Created: 1/30/2026
Status: ❌ Closed

Base: master ← Head: vivek/subagent-shell

📝 Commits (10+)

  • 0c75a73 Add subagent_middleware parameter to give subagents shell access
  • cdbdcf3 Merge branch 'master' into vivek/subagent-shell
  • b595c5c fix: add LocalContextMiddleware to subagent_mw so it can inject the inherited context
  • 7c8b7f4 Merge branch 'master' into vivek/subagent-shell
  • 72fcdf6 refactor(cli): replace ShellMiddleware with LocalShellBackend
  • 375462c docs: remove implementation detail from enable_shell docstring
  • 9545885 fix: remove non-existent subagent_middleware parameter
  • 89e150b refactor: remove ShellMiddleware in favor of LocalShellBackend
  • 80dea6d x
  • 6750921 Merge branch 'master' into vivek/subagent-shell

📊 Changes

9 files changed (+80 additions, -413 deletions)

View changed files

📝 libs/cli/deepagents_cli/agent.py (+60 -40)
📝 libs/cli/deepagents_cli/main.py (+1 -1)
➖ libs/cli/deepagents_cli/shell.py (+0 -167)
📝 libs/cli/deepagents_cli/subagents.py (+6 -3)
📝 libs/cli/deepagents_cli/ui.py (+4 -12)
📝 libs/cli/deepagents_cli/widgets/approval.py (+9 -3)
📝 libs/cli/pyproject.toml (+0 -1)
➖ libs/cli/tests/unit_tests/test_shell.py (+0 -145)
📝 libs/cli/tests/unit_tests/test_ui.py (+0 -41)

📄 Description

  • CLI will use now use LocalShellBackend for shell access instead of custom ShellMiddleware
  • Subagents can now also use the shell

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/langchain-ai/deepagents/pull/959 **Author:** [@vtrivedy](https://github.com/vtrivedy) **Created:** 1/30/2026 **Status:** ❌ Closed **Base:** `master` ← **Head:** `vivek/subagent-shell` --- ### 📝 Commits (10+) - [`0c75a73`](https://github.com/langchain-ai/deepagents/commit/0c75a732d1876444401411303bbf6cc71ad1fc57) Add subagent_middleware parameter to give subagents shell access - [`cdbdcf3`](https://github.com/langchain-ai/deepagents/commit/cdbdcf33841835c148c23d03c8ad532beac04b6c) Merge branch 'master' into vivek/subagent-shell - [`b595c5c`](https://github.com/langchain-ai/deepagents/commit/b595c5ce7508bfb5034787c5e0bc0e33f525aebf) fix: add `LocalContextMiddleware` to `subagent_mw` so it can inject the inherited context - [`7c8b7f4`](https://github.com/langchain-ai/deepagents/commit/7c8b7f428438ba21a2ec1ea22179b465df8d1e16) Merge branch 'master' into vivek/subagent-shell - [`72fcdf6`](https://github.com/langchain-ai/deepagents/commit/72fcdf60d0a28cc2d37e0a1e9599c58eab999d87) refactor(cli): replace ShellMiddleware with LocalShellBackend - [`375462c`](https://github.com/langchain-ai/deepagents/commit/375462c35586e2c4f5c1a336123ace24e0ac2d17) docs: remove implementation detail from enable_shell docstring - [`9545885`](https://github.com/langchain-ai/deepagents/commit/954588505db5a903a73d7526be8a9d38de91ee66) fix: remove non-existent subagent_middleware parameter - [`89e150b`](https://github.com/langchain-ai/deepagents/commit/89e150b66676d76d964f0856da7bae89605506ad) refactor: remove ShellMiddleware in favor of LocalShellBackend - [`80dea6d`](https://github.com/langchain-ai/deepagents/commit/80dea6d418155e45eb9ff387dcf53cf80b4ba17c) x - [`6750921`](https://github.com/langchain-ai/deepagents/commit/675092113f4e08686dc53b3ffd1589249a890670) Merge branch 'master' into vivek/subagent-shell ### 📊 Changes **9 files changed** (+80 additions, -413 deletions) <details> <summary>View changed files</summary> 📝 `libs/cli/deepagents_cli/agent.py` (+60 -40) 📝 `libs/cli/deepagents_cli/main.py` (+1 -1) ➖ `libs/cli/deepagents_cli/shell.py` (+0 -167) 📝 `libs/cli/deepagents_cli/subagents.py` (+6 -3) 📝 `libs/cli/deepagents_cli/ui.py` (+4 -12) 📝 `libs/cli/deepagents_cli/widgets/approval.py` (+9 -3) 📝 `libs/cli/pyproject.toml` (+0 -1) ➖ `libs/cli/tests/unit_tests/test_shell.py` (+0 -145) 📝 `libs/cli/tests/unit_tests/test_ui.py` (+0 -41) </details> ### 📄 Description * CLI will use now use `LocalShellBackend` for shell access instead of custom `ShellMiddleware` * Subagents can now also use the shell --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-16 09:17:55 -05:00
yindo closed this issue 2026-02-16 09:17:55 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
MCP
backends
bug
cli
config
customization
deepagents
documentation
external
feature
fix
good first issue
help wanted
integration
internal
invalid
middleware
model
needs investigation
p0
p1
p2
p3
performance
pull-request
Mirrored from GitHub Pull Request
 question
sdk
subagents
unable to reproduce
windows
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langchain-ai/deepagents#1012
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?