langchain-ai/deepagents
1
0
Fork 0
mirror of https://github.com/langchain-ai/deepagents.git synced 2026-07-24 12:25:49 -04:00
Code Issues 169 Packages Projects Releases 16 Wiki Activity

[PR #1015] fix(deepagents): avoid unnecessary REMOVE_ALL_MESSAGES in PatchToolCallsMiddleware #1065

New Issue
Open
opened 2026-02-16 09:18:03 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 09:18:03 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/langchain-ai/deepagents/pull/1015
Author: @christian-bromann
Created: 2/2/2026
Status: 🔄 Open

Base: main ← Head: cb/improve-dangling-toolcall-fix

📝 Commits (2)

  • 1f9a744 fix(deepagents): avoid unnecessary REMOVE_ALL_MESSAGES in PatchToolCallsMiddleware
  • e39ea8a Merge branch 'master' into cb/improve-dangling-toolcall-fix

📊 Changes

2 files changed (+257 additions, -0 deletions)

View changed files

📝 libs/deepagents/deepagents/middleware/patch_tool_calls.py (+7 -0)
➕ libs/deepagents/tests/unit_tests/middleware/test_patch_tool_calls.py (+250 -0)

📄 Description

Adding to check wether we need to update the state if no dangling tool calls were found.

Overwrite is an explicit state replacement signal - When we return {"messages": Overwrite(patched_messages)}, LangGraph will perform a state update operation, replacing the messages entirely. This happens regardless of whether the content is identical to what was already there.

Returning None seems a more performant approach.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/langchain-ai/deepagents/pull/1015 **Author:** [@christian-bromann](https://github.com/christian-bromann) **Created:** 2/2/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `cb/improve-dangling-toolcall-fix` --- ### 📝 Commits (2) - [`1f9a744`](https://github.com/langchain-ai/deepagents/commit/1f9a7446c07cf60ba6134f399d6c4f7e93931ad1) fix(deepagents): avoid unnecessary REMOVE_ALL_MESSAGES in PatchToolCallsMiddleware - [`e39ea8a`](https://github.com/langchain-ai/deepagents/commit/e39ea8a18f478d25a988dac2ec31c8510a377122) Merge branch 'master' into cb/improve-dangling-toolcall-fix ### 📊 Changes **2 files changed** (+257 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `libs/deepagents/deepagents/middleware/patch_tool_calls.py` (+7 -0) ➕ `libs/deepagents/tests/unit_tests/middleware/test_patch_tool_calls.py` (+250 -0) </details> ### 📄 Description Adding to check wether we need to update the state if no dangling tool calls were found. Overwrite is an explicit state replacement signal - When we return `{"messages": Overwrite(patched_messages)}`, LangGraph will perform a state update operation, replacing the messages entirely. This happens regardless of whether the content is identical to what was already there. Returning `None` seems a more performant approach. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-16 09:18:03 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
MCP
backends
bug
cli
config
customization
deepagents
documentation
external
feature
fix
good first issue
help wanted
integration
internal
invalid
middleware
model
needs investigation
p0
p1
p2
p3
performance
pull-request
Mirrored from GitHub Pull Request
 question
sdk
subagents
unable to reproduce
windows
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langchain-ai/deepagents#1065
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?