langchain-ai/deepagents
1
0
Fork 0
mirror of https://github.com/langchain-ai/deepagents.git synced 2026-07-25 04:46:03 -04:00
Code Issues 169 Packages Projects Releases 16 Wiki Activity

[PR #1135] [MERGED] fix(cli): hide resume hint on app error and improve startup message #1154

New Issue
Closed
opened 2026-02-16 09:18:17 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 09:18:17 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/langchain-ai/deepagents/pull/1135
Author: @mdrxy
Created: 2/5/2026
Status: ✅ Merged
Merged: 2/5/2026
Merged by: @mdrxy

Base: master ← Head: mdrxy/fix-error-startup

📝 Commits (1)

  • 634304b fix(cli): hide resume hint on app error and improve startup message

📊 Changes

3 files changed (+114 additions, -7 deletions)

View changed files

📝 libs/cli/deepagents_cli/app.py (+5 -1)
📝 libs/cli/deepagents_cli/main.py (+12 -6)
➕ libs/cli/tests/unit_tests/test_main.py (+97 -0)

📄 Description

  • Don't show "Resume this thread with:" when the app exits with an error
  • Change startup message from "Thread:" to "Starting with thread:"

Changes

  • run_textual_app() now returns the app's return code (0 for success, non-zero for error)
  • run_textual_cli_async() propagates this return code
  • Resume hint only displays when return_code == 0
  • Startup message clarifies intent: "Starting with thread: abc123"

Why

When the Textual app crashes (e.g., due to an internal exception), it displays a traceback and exits. Previously, the "Resume this thread with:" hint was still shown after the error, which was confusing since the session didn't complete successfully.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/langchain-ai/deepagents/pull/1135 **Author:** [@mdrxy](https://github.com/mdrxy) **Created:** 2/5/2026 **Status:** ✅ Merged **Merged:** 2/5/2026 **Merged by:** [@mdrxy](https://github.com/mdrxy) **Base:** `master` ← **Head:** `mdrxy/fix-error-startup` --- ### 📝 Commits (1) - [`634304b`](https://github.com/langchain-ai/deepagents/commit/634304b48a0dfa8f4a4e8ea786bb65433d60dd11) fix(cli): hide resume hint on app error and improve startup message ### 📊 Changes **3 files changed** (+114 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `libs/cli/deepagents_cli/app.py` (+5 -1) 📝 `libs/cli/deepagents_cli/main.py` (+12 -6) ➕ `libs/cli/tests/unit_tests/test_main.py` (+97 -0) </details> ### 📄 Description - Don't show "Resume this thread with:" when the app exits with an error - Change startup message from "Thread:" to "Starting with thread:" ## Changes - `run_textual_app()` now returns the app's return code (0 for success, non-zero for error) - `run_textual_cli_async()` propagates this return code - Resume hint only displays when `return_code == 0` - Startup message clarifies intent: "Starting with thread: abc123" ## Why When the Textual app crashes (e.g., due to an internal exception), it displays a traceback and exits. Previously, the "Resume this thread with:" hint was still shown after the error, which was confusing since the session didn't complete successfully. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-16 09:18:17 -05:00
yindo closed this issue 2026-02-16 09:18:17 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
MCP
backends
bug
cli
config
customization
deepagents
documentation
external
feature
fix
good first issue
help wanted
integration
internal
invalid
middleware
model
needs investigation
p0
p1
p2
p3
performance
pull-request
Mirrored from GitHub Pull Request
 question
sdk
subagents
unable to reproduce
windows
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langchain-ai/deepagents#1154
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?