langchain-ai/deepagents
1
0
Fork 0
mirror of https://github.com/langchain-ai/deepagents.git synced 2026-07-24 20:35:31 -04:00
Code Issues 169 Packages Projects Releases 16 Wiki Activity

[PR #1335] [MERGED] fix(acp): Fix double approval bug #1316

New Issue
Closed
opened 2026-02-16 09:18:43 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 09:18:43 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/langchain-ai/deepagents/pull/1335
Author: @jacoblee93
Created: 2/13/2026
Status: ✅ Merged
Merged: 2/13/2026
Merged by: @jacoblee93

Base: main ← Head: jacob/doublehitl

📝 Commits (2)

  • a4099be Fix double approval bug
  • 88e78a3 Remove redundant interrupt check

📊 Changes

2 files changed (+59 additions, -5 deletions)

View changed files

📝 libs/acp/deepagents_acp/server.py (+5 -5)
📝 libs/acp/tests/test_agent.py (+54 -0)

📄 Description

The ACP client was calling handle interrupts twice

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/langchain-ai/deepagents/pull/1335 **Author:** [@jacoblee93](https://github.com/jacoblee93) **Created:** 2/13/2026 **Status:** ✅ Merged **Merged:** 2/13/2026 **Merged by:** [@jacoblee93](https://github.com/jacoblee93) **Base:** `main` ← **Head:** `jacob/doublehitl` --- ### 📝 Commits (2) - [`a4099be`](https://github.com/langchain-ai/deepagents/commit/a4099be84d598ec902f43f878c7aabcceb815a20) Fix double approval bug - [`88e78a3`](https://github.com/langchain-ai/deepagents/commit/88e78a3f9bfc8f8ab5ae1e56061f3c7eee2d925b) Remove redundant interrupt check ### 📊 Changes **2 files changed** (+59 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `libs/acp/deepagents_acp/server.py` (+5 -5) 📝 `libs/acp/tests/test_agent.py` (+54 -0) </details> ### 📄 Description The ACP client was calling handle interrupts twice --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-16 09:18:43 -05:00
yindo closed this issue 2026-02-16 09:18:43 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
MCP
backends
bug
cli
config
customization
deepagents
documentation
external
feature
fix
good first issue
help wanted
integration
internal
invalid
middleware
model
needs investigation
p0
p1
p2
p3
performance
pull-request
Mirrored from GitHub Pull Request
 question
sdk
subagents
unable to reproduce
windows
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langchain-ai/deepagents#1316
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?