langchain-ai/deepagentsjs
1
0
Fork 0
mirror of https://github.com/langchain-ai/deepagentsjs.git synced 2026-07-18 16:04:44 -04:00
Code Issues 42 Packages Projects Releases 10 Wiki Activity

[PR #200] [MERGED] fix: normalize path handling for cross-platform compatibility #203

New Issue
Closed
opened 2026-02-16 06:17:25 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 06:17:25 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/langchain-ai/deepagentsjs/pull/200
Author: @JadenKim-dev
Created: 2/6/2026
Status: ✅ Merged
Merged: 2/7/2026
Merged by: @christian-bromann

Base: main ← Head: skill-middleware

📝 Commits (3)

  • 56564ee fix: normalize path handling for cross-platform compatibility
  • 1fa4966 add changesets
  • b0ca8bc Merge branch 'main' into skill-middleware

📊 Changes

3 files changed (+529 additions, -3 deletions)

View changed files

➕ .changeset/forty-plants-rescue.md (+5 -0)
📝 libs/deepagents/src/middleware/skills.test.ts (+518 -0)
📝 libs/deepagents/src/middleware/skills.ts (+6 -3)

📄 Description

Summary

Fixes path handling in the skills middleware to ensure proper cross-platform compatibility between Unix and Windows environments. The middleware now correctly detects and uses the appropriate path separator (/ for Unix, \ for Windows) when constructing skill file paths.

Changes

  • Path normalization logic: Updated listSkillsFromBackend() to detect the path separator style from the source path and apply it consistently throughout path construction
  • Test coverage: Added test suite with new test cases covering:
    • Edge cases (oversized files, missing directories, YAML parsing errors)
    • Backward compatibility (checkpoint restoration, reload prevention)
    • Validation (name format validation, description truncation)
    • Cross-platform path handling (Unix forward slashes, Windows backslashes)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/langchain-ai/deepagentsjs/pull/200 **Author:** [@JadenKim-dev](https://github.com/JadenKim-dev) **Created:** 2/6/2026 **Status:** ✅ Merged **Merged:** 2/7/2026 **Merged by:** [@christian-bromann](https://github.com/christian-bromann) **Base:** `main` ← **Head:** `skill-middleware` --- ### 📝 Commits (3) - [`56564ee`](https://github.com/langchain-ai/deepagentsjs/commit/56564ee1aa571654376071c9c7176d9d979d8b74) fix: normalize path handling for cross-platform compatibility - [`1fa4966`](https://github.com/langchain-ai/deepagentsjs/commit/1fa49662728225c30d2cec1717b69425248676a7) add changesets - [`b0ca8bc`](https://github.com/langchain-ai/deepagentsjs/commit/b0ca8bc2d329b09136f4588b71e3d444e42ae680) Merge branch 'main' into skill-middleware ### 📊 Changes **3 files changed** (+529 additions, -3 deletions) <details> <summary>View changed files</summary> ➕ `.changeset/forty-plants-rescue.md` (+5 -0) 📝 `libs/deepagents/src/middleware/skills.test.ts` (+518 -0) 📝 `libs/deepagents/src/middleware/skills.ts` (+6 -3) </details> ### 📄 Description ## Summary Fixes path handling in the skills middleware to ensure proper cross-platform compatibility between Unix and Windows environments. The middleware now correctly detects and uses the appropriate path separator (`/` for Unix, `\` for Windows) when constructing skill file paths. ## Changes - **Path normalization logic**: Updated `listSkillsFromBackend()` to detect the path separator style from the source path and apply it consistently throughout path construction - **Test coverage**: Added test suite with new test cases covering: - Edge cases (oversized files, missing directories, YAML parsing errors) - Backward compatibility (checkpoint restoration, reload prevention) - Validation (name format validation, description truncation) - Cross-platform path handling (Unix forward slashes, Windows backslashes) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-16 06:17:25 -05:00
yindo closed this issue 2026-02-16 06:17:25 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
help wanted
needs-response
pull-request
Mirrored from GitHub Pull Request
 stale
triage: high-impact
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langchain-ai/deepagentsjs#203
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?