langchain-ai/deepagentsjs
1
0
Fork 0
mirror of https://github.com/langchain-ai/deepagentsjs.git synced 2026-07-18 16:04:44 -04:00
Code Issues 42 Packages Projects Releases 10 Wiki Activity

[PR #247] [CLOSED] fix(deepagents): CompositeBackend grepRaw/globInfo respect path→backend mapping (#241) #295

New Issue
Closed
opened 2026-06-05 17:22:33 -04:00 by yindo · 0 comments
yindo commented 2026-06-05 17:22:33 -04:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/langchain-ai/deepagentsjs/pull/247
Author: @christian-bromann
Created: 2/23/2026
Status: ❌ Closed

Base: main ← Head: cb/composite-fix

📝 Commits (3)

  • b86d5d1 fix(deepagents): CompositeBackend grepRaw/globInfo respect path→backend mapping (#241)
  • 1f62273 Create light-cars-report.md
  • 30026fe cr

📊 Changes

3 files changed (+79 additions, -30 deletions)

View changed files

➕ .changeset/light-cars-report.md (+5 -0)
📝 libs/deepagents/src/backends/composite.test.ts (+44 -2)
📝 libs/deepagents/src/backends/composite.ts (+30 -28)

📄 Description

Fixes #241.

  • grepRaw and globInfo in CompositeBackend no longer fan out to every routed backend when the search path doesn't match a route prefix. They now delegate only to the default backend, matching the behavior of all other operations (read, write, edit, lsInfo).
  • Removed the now-unused private routes field (only sortedRoutes is needed).
  • Updated tests to assert the corrected routing: searching at / only queries the default backend; searching with an explicit route prefix (e.g. /memories/) correctly queries the routed backend.

Motivation

When a CompositeBackend is configured with path-based routing like:

new CompositeBackend(workspaceFs, {
    'memory/': configsFs,
    'skills/': configsFs,
})

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/langchain-ai/deepagentsjs/pull/247 **Author:** [@christian-bromann](https://github.com/christian-bromann) **Created:** 2/23/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `cb/composite-fix` --- ### 📝 Commits (3) - [`b86d5d1`](https://github.com/langchain-ai/deepagentsjs/commit/b86d5d110f9cd339d1bf59b6e8d0577068d4b463) fix(deepagents): CompositeBackend grepRaw/globInfo respect path→backend mapping (#241) - [`1f62273`](https://github.com/langchain-ai/deepagentsjs/commit/1f62273d37ff77cc84afc200dc6da7d533988200) Create light-cars-report.md - [`30026fe`](https://github.com/langchain-ai/deepagentsjs/commit/30026fe9f04edd7f4530a8b5b926c4cbeefdb38f) cr ### 📊 Changes **3 files changed** (+79 additions, -30 deletions) <details> <summary>View changed files</summary> ➕ `.changeset/light-cars-report.md` (+5 -0) 📝 `libs/deepagents/src/backends/composite.test.ts` (+44 -2) 📝 `libs/deepagents/src/backends/composite.ts` (+30 -28) </details> ### 📄 Description Fixes #241. - `grepRaw` and `globInfo` in `CompositeBackend` no longer fan out to every routed backend when the search path doesn't match a route prefix. They now delegate only to the default backend, matching the behavior of all other operations (`read`, `write`, `edit`, `lsInfo`). - Removed the now-unused `private routes` field (only `sortedRoutes` is needed). - Updated tests to assert the corrected routing: searching at `/` only queries the default backend; searching with an explicit route prefix (e.g. `/memories/`) correctly queries the routed backend. ## Motivation When a `CompositeBackend` is configured with path-based routing like: ```ts new CompositeBackend(workspaceFs, { 'memory/': configsFs, 'skills/': configsFs, }) ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-06-05 17:22:33 -04:00
yindo closed this issue 2026-06-05 17:22:33 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
help wanted
needs-response
pull-request
Mirrored from GitHub Pull Request
 stale
triage: high-impact
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langchain-ai/deepagentsjs#295
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?