langchain-ai/deepagentsjs
1
0
Fork 0
mirror of https://github.com/langchain-ai/deepagentsjs.git synced 2026-07-18 16:04:44 -04:00
Code Issues 42 Packages Projects Releases 10 Wiki Activity

[PR #291] [MERGED] feat(acp): add authMethods to InitializeResponse for ACP registry compliance #332

New Issue
Closed
opened 2026-06-05 17:22:42 -04:00 by yindo · 0 comments
yindo commented 2026-06-05 17:22:42 -04:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/langchain-ai/deepagentsjs/pull/291
Author: @christian-bromann
Created: 3/9/2026
Status: ✅ Merged
Merged: 3/10/2026
Merged by: @christian-bromann

Base: main ← Head: cb/acp-auth-method

📝 Commits (4)

  • 3571d5a feat(acp): add authMethods to InitializeResponse for ACP registry compliance
  • f8cbe9d Create weak-singers-wash.md
  • d13be2d format
  • 2099f8e remove description prop

📊 Changes

5 files changed (+169 additions, -0 deletions)

View changed files

➕ .changeset/weak-singers-wash.md (+5 -0)
📝 libs/acp/src/index.ts (+5 -0)
📝 libs/acp/src/server.test.ts (+39 -0)
📝 libs/acp/src/server.ts (+26 -0)
📝 libs/acp/src/types.ts (+94 -0)

📄 Description

Summary

  • Add authMethods to the ACP InitializeResponse, fixing the registry CI failure ("No authMethods in response")
  • Introduce typed interfaces (ACPAuthMethod, ACPAuthMethodAgent, ACPAuthMethodEnvVar, ACPAuthMethodTerminal) matching the ACP auth methods spec
  • Make authMethods configurable via DeepAgentsServerOptions so users building custom DeepAgentsServer instances can define their own auth flows

Defaults to Anthropic/OpenAI env_var methods plus a generic agent-type fallback when no authMethods are provided:

const server = new DeepAgentsServer({
  agents: { name: "my-agent" },
  authMethods: [
    {
      id: "my-login",
      name: "Login",
      type: "terminal",
      args: ["--login"],
    },
    {
      id: "api-key",
      name: "API Key",
      type: "env_var",
      vars: [{ name: "MY_API_KEY" }],
      link: "https://my-service.com/keys",
    },
  ],
});

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/langchain-ai/deepagentsjs/pull/291 **Author:** [@christian-bromann](https://github.com/christian-bromann) **Created:** 3/9/2026 **Status:** ✅ Merged **Merged:** 3/10/2026 **Merged by:** [@christian-bromann](https://github.com/christian-bromann) **Base:** `main` ← **Head:** `cb/acp-auth-method` --- ### 📝 Commits (4) - [`3571d5a`](https://github.com/langchain-ai/deepagentsjs/commit/3571d5a8640b07a3b6357abf9f9cdd70d822e20c) feat(acp): add authMethods to InitializeResponse for ACP registry compliance - [`f8cbe9d`](https://github.com/langchain-ai/deepagentsjs/commit/f8cbe9dbb2460f980f0f4f7c5d264ed5ba2722c7) Create weak-singers-wash.md - [`d13be2d`](https://github.com/langchain-ai/deepagentsjs/commit/d13be2dd6e589b468b6a80b0e907b2cedf2173f2) format - [`2099f8e`](https://github.com/langchain-ai/deepagentsjs/commit/2099f8eea68a45f39f52052fcd65bbe334a01ea2) remove description prop ### 📊 Changes **5 files changed** (+169 additions, -0 deletions) <details> <summary>View changed files</summary> ➕ `.changeset/weak-singers-wash.md` (+5 -0) 📝 `libs/acp/src/index.ts` (+5 -0) 📝 `libs/acp/src/server.test.ts` (+39 -0) 📝 `libs/acp/src/server.ts` (+26 -0) 📝 `libs/acp/src/types.ts` (+94 -0) </details> ### 📄 Description ## Summary - Add `authMethods` to the ACP `InitializeResponse`, fixing the registry CI failure ("No authMethods in response") - Introduce typed interfaces (`ACPAuthMethod`, `ACPAuthMethodAgent`, `ACPAuthMethodEnvVar`, `ACPAuthMethodTerminal`) matching the [ACP auth methods spec](https://agentclientprotocol.com/rfds/auth-methods) - Make `authMethods` configurable via `DeepAgentsServerOptions` so users building custom `DeepAgentsServer` instances can define their own auth flows Defaults to Anthropic/OpenAI `env_var` methods plus a generic agent-type fallback when no `authMethods` are provided: ```typescript const server = new DeepAgentsServer({ agents: { name: "my-agent" }, authMethods: [ { id: "my-login", name: "Login", type: "terminal", args: ["--login"], }, { id: "api-key", name: "API Key", type: "env_var", vars: [{ name: "MY_API_KEY" }], link: "https://my-service.com/keys", }, ], }); ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-06-05 17:22:42 -04:00
yindo closed this issue 2026-06-05 17:22:42 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
help wanted
needs-response
pull-request
Mirrored from GitHub Pull Request
 stale
triage: high-impact
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langchain-ai/deepagentsjs#332
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?