langchain-ai/deepagentsjs
1
0
Fork 0
mirror of https://github.com/langchain-ai/deepagentsjs.git synced 2026-07-18 16:04:44 -04:00
Code Issues 42 Packages Projects Releases 10 Wiki Activity

[PR #300] [MERGED] fix(modal): prevent sandbox timeout in integration tests #339

New Issue
Closed
opened 2026-06-05 17:22:43 -04:00 by yindo · 0 comments
yindo commented 2026-06-05 17:22:43 -04:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/langchain-ai/deepagentsjs/pull/300
Author: @hntrl
Created: 3/11/2026
Status: ✅ Merged
Merged: 3/11/2026
Merged by: @hntrl

Base: main ← Head: hunter/fix-ci

📝 Commits (1)

  • bec88ee fix(modal): prevent sandbox timeout in integration tests

📊 Changes

1 file changed (+5 additions, -0 deletions)

View changed files

📝 libs/providers/modal/src/sandbox.int.test.ts (+5 -0)

📄 Description

Summary

Fixes flaky Modal provider integration tests that were failing due to sandbox instances being garbage-collected mid-test.

Changes

@langchain/modal

The Modal standard integration tests were failing because:

  1. No timeoutMs on the shared sandbox — The shared sandbox created by the standard test harness used Modal's SDK default TTL (~5 min), but the full test suite takes ~13 minutes for Modal. The sandbox was terminated mid-run, causing NOT_FOUND errors in globInfo and integration tests.

  2. Concurrent test execution hitting Modal concurrency limits — Parallel sandbox creation caused beforeAll hooks to time out (180s) waiting for capacity.

Fixes:

  • Added timeoutMs: 900_000 (15 min) to the shared sandbox so it survives the full test suite
  • Added sequential: true to avoid hitting Modal's sandbox concurrency limits (matching the Deno provider pattern)
  • Added timeoutMs: 300_000 (5 min) to the three provider-specific sandbox creations that were missing it

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/langchain-ai/deepagentsjs/pull/300 **Author:** [@hntrl](https://github.com/hntrl) **Created:** 3/11/2026 **Status:** ✅ Merged **Merged:** 3/11/2026 **Merged by:** [@hntrl](https://github.com/hntrl) **Base:** `main` ← **Head:** `hunter/fix-ci` --- ### 📝 Commits (1) - [`bec88ee`](https://github.com/langchain-ai/deepagentsjs/commit/bec88ee85a1e350ef8a4eb0e4db907a89e604585) fix(modal): prevent sandbox timeout in integration tests ### 📊 Changes **1 file changed** (+5 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `libs/providers/modal/src/sandbox.int.test.ts` (+5 -0) </details> ### 📄 Description ## Summary Fixes flaky Modal provider integration tests that were failing due to sandbox instances being garbage-collected mid-test. ## Changes ### `@langchain/modal` The Modal standard integration tests were failing because: 1. **No `timeoutMs` on the shared sandbox** — The shared sandbox created by the standard test harness used Modal's SDK default TTL (~5 min), but the full test suite takes ~13 minutes for Modal. The sandbox was terminated mid-run, causing `NOT_FOUND` errors in `globInfo` and `integration` tests. 2. **Concurrent test execution hitting Modal concurrency limits** — Parallel sandbox creation caused `beforeAll` hooks to time out (180s) waiting for capacity. Fixes: - Added `timeoutMs: 900_000` (15 min) to the shared sandbox so it survives the full test suite - Added `sequential: true` to avoid hitting Modal's sandbox concurrency limits (matching the Deno provider pattern) - Added `timeoutMs: 300_000` (5 min) to the three provider-specific sandbox creations that were missing it --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-06-05 17:22:43 -04:00
yindo closed this issue 2026-06-05 17:22:43 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
help wanted
needs-response
pull-request
Mirrored from GitHub Pull Request
 stale
triage: high-impact
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langchain-ai/deepagentsjs#339
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?