langchain-ai/deepagentsjs
1
0
Fork 0
mirror of https://github.com/langchain-ai/deepagentsjs.git synced 2026-07-19 08:26:01 -04:00
Code Issues 42 Packages Projects Releases 10 Wiki Activity

[GH-ISSUE #185] createSummarizationMiddleware logic error #43

New Issue
Closed
opened 2026-02-16 06:16:57 -05:00 by yindo · 1 comment
yindo commented 2026-02-16 06:16:57 -05:00
Owner
Copy Link
Copy Source

Originally created by @zixingtangmouren on GitHub (Feb 4, 2026).
Original GitHub issue: https://github.com/langchain-ai/deepagentsjs/issues/185

Originally assigned to: @christian-bromann on GitHub.

Description

It seems that there is a logic issue in the createSummarizationMiddleware middleware in the main branch.

path: libs/deepagents/src/middleware/summarization.ts

    if (truncateTrigger.type === "fraction" && maxInputTokens) {
      const threshold = Math.floor(maxInputTokens * truncateTrigger.value);
      return totalTokens >= threshold;
    }

I pulled down the main branch to test it and found that the fraction parameter is always invalid because maxInputTokens is always undefined.

Originally created by @zixingtangmouren on GitHub (Feb 4, 2026). Original GitHub issue: https://github.com/langchain-ai/deepagentsjs/issues/185 Originally assigned to: @christian-bromann on GitHub. ## Description It seems that there is a logic issue in the `createSummarizationMiddleware` middleware in the main branch. path: libs/deepagents/src/middleware/summarization.ts ```ts if (truncateTrigger.type === "fraction" && maxInputTokens) { const threshold = Math.floor(maxInputTokens * truncateTrigger.value); return totalTokens >= threshold; } ``` I pulled down the main branch to test it and found that the fraction parameter is always invalid because maxInputTokens is always undefined.
yindo closed this issue 2026-02-16 06:16:57 -05:00
yindo commented 2026-02-16 06:16:58 -05:00
Author
Owner
Copy Link
Copy Source

@christian-bromann commented on GitHub (Feb 4, 2026):

Thanks for reporting, will take a look!

@christian-bromann commented on GitHub (Feb 4, 2026): Thanks for reporting, will take a look!
yindo changed title from `createSummarizationMiddleware` logic error to [GH-ISSUE #185] `createSummarizationMiddleware` logic error 2026-06-05 17:21:09 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
help wanted
needs-response
pull-request
Mirrored from GitHub Pull Request
 stale
triage: high-impact
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langchain-ai/deepagentsjs#43
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?