langchain-ai/deepagentsjs
1
0
Fork 0
mirror of https://github.com/langchain-ai/deepagentsjs.git synced 2026-08-24 12:32:49 -04:00
Code Issues 42 Packages Projects Releases 10 Wiki Activity

[PR #464] [CLOSED] fix(deepagents): follow symlinks in sandbox find commands #490

New Issue
Closed
opened 2026-06-05 17:23:22 -04:00 by yindo · 0 comments
yindo commented 2026-06-05 17:23:22 -04:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/langchain-ai/deepagentsjs/pull/464
Author: @hntrl
Created: 4/14/2026
Status: ❌ Closed

Base: main ← Head: hunter/fix-sandbox-find-follow-symlinks

📝 Commits (1)

  • ce5a459 fix(deepagents): follow symlinks in sandbox find commands

📊 Changes

2 files changed (+17 additions, -4 deletions)

View changed files

📝 libs/deepagents/src/backends/sandbox.test.ts (+14 -1)
📝 libs/deepagents/src/backends/sandbox.ts (+3 -3)

📄 Description

Summary

Fixes #447.

Sandbox filesystem discovery commands were not following symlinks, causing ls, glob, and grep (with glob) to return empty results for symlinked directories (for example, provider mounts exposed via symlinks). This change updates the BaseSandbox command builders to use find -L so symlink targets are traversed consistently.

Changes

deepagents (libs/deepagents/src/backends/sandbox.ts)

  • Updated buildLsCommand to use find -L.
  • Updated buildFindCommand (used by glob) to use find -L.
  • Updated glob-filtered buildGrepCommand path to use find -L before grep.

Tests (libs/deepagents/src/backends/sandbox.test.ts)

  • Added assertions that generated ls and glob commands include find -L.
  • Added coverage for grep(..., glob=...) to verify symlink-following command generation.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/langchain-ai/deepagentsjs/pull/464 **Author:** [@hntrl](https://github.com/hntrl) **Created:** 4/14/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `hunter/fix-sandbox-find-follow-symlinks` --- ### 📝 Commits (1) - [`ce5a459`](https://github.com/langchain-ai/deepagentsjs/commit/ce5a459a0fccdb68395078a5a3f0186b7ac6ebc7) fix(deepagents): follow symlinks in sandbox find commands ### 📊 Changes **2 files changed** (+17 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `libs/deepagents/src/backends/sandbox.test.ts` (+14 -1) 📝 `libs/deepagents/src/backends/sandbox.ts` (+3 -3) </details> ### 📄 Description ## Summary Fixes #447. Sandbox filesystem discovery commands were not following symlinks, causing `ls`, `glob`, and `grep` (with `glob`) to return empty results for symlinked directories (for example, provider mounts exposed via symlinks). This change updates the `BaseSandbox` command builders to use `find -L` so symlink targets are traversed consistently. ## Changes ### `deepagents` (`libs/deepagents/src/backends/sandbox.ts`) - Updated `buildLsCommand` to use `find -L`. - Updated `buildFindCommand` (used by `glob`) to use `find -L`. - Updated glob-filtered `buildGrepCommand` path to use `find -L` before `grep`. ### Tests (`libs/deepagents/src/backends/sandbox.test.ts`) - Added assertions that generated `ls` and `glob` commands include `find -L`. - Added coverage for `grep(..., glob=...)` to verify symlink-following command generation. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-06-05 17:23:22 -04:00
yindo closed this issue 2026-06-05 17:23:23 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
help wanted
needs-response
pull-request
Mirrored from GitHub Pull Request
 stale
triage: high-impact
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langchain-ai/deepagentsjs#490
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?