langchain-ai/deepagentsjs
1
0
Fork 0
mirror of https://github.com/langchain-ai/deepagentsjs.git synced 2026-07-19 08:26:01 -04:00
Code Issues 42 Packages Projects Releases 10 Wiki Activity

[PR #528] [MERGED] fix(deepagents): align LangSmith sandbox create options with SDK #539

New Issue
Closed
opened 2026-06-05 17:23:36 -04:00 by yindo · 0 comments
yindo commented 2026-06-05 17:23:36 -04:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/langchain-ai/deepagentsjs/pull/528
Author: @hntrl
Created: 5/8/2026
Status: ✅ Merged
Merged: 5/8/2026
Merged by: @hntrl

Base: main ← Head: hunter/fix-langsmith-snapshot-ci

📝 Commits (1)

  • 22a8bf0 fix(deepagents): align LangSmith sandbox create options with SDK

📊 Changes

2 files changed (+87 additions, -6 deletions)

View changed files

📝 libs/deepagents/src/backends/langsmith.test.ts (+65 -1)
📝 libs/deepagents/src/backends/langsmith.ts (+22 -5)

📄 Description

Summary

This fixes a CI-breaking type mismatch in the LangSmith sandbox backend introduced by the snapshot lifecycle update. LangSmithSandbox.create() was using a snapshotId flow that did not match the current langsmith SDK typings, which surfaced as unhandled Vitest typecheck errors in CI.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/langchain-ai/deepagentsjs/pull/528 **Author:** [@hntrl](https://github.com/hntrl) **Created:** 5/8/2026 **Status:** ✅ Merged **Merged:** 5/8/2026 **Merged by:** [@hntrl](https://github.com/hntrl) **Base:** `main` ← **Head:** `hunter/fix-langsmith-snapshot-ci` --- ### 📝 Commits (1) - [`22a8bf0`](https://github.com/langchain-ai/deepagentsjs/commit/22a8bf0c0176f3e5634a5cbbbb73d740ccf6c11c) fix(deepagents): align LangSmith sandbox create options with SDK ### 📊 Changes **2 files changed** (+87 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `libs/deepagents/src/backends/langsmith.test.ts` (+65 -1) 📝 `libs/deepagents/src/backends/langsmith.ts` (+22 -5) </details> ### 📄 Description ## Summary This fixes a CI-breaking type mismatch in the LangSmith sandbox backend introduced by the snapshot lifecycle update. `LangSmithSandbox.create()` was using a `snapshotId` flow that did not match the current `langsmith` SDK typings, which surfaced as unhandled Vitest typecheck errors in CI. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-06-05 17:23:36 -04:00
yindo closed this issue 2026-06-05 17:23:36 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
help wanted
needs-response
pull-request
Mirrored from GitHub Pull Request
 stale
triage: high-impact
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langchain-ai/deepagentsjs#539
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?