langchain-ai/deepagentsjs
1
0
Fork 0
mirror of https://github.com/langchain-ai/deepagentsjs.git synced 2026-07-19 08:26:01 -04:00
Code Issues 42 Packages Projects Releases 10 Wiki Activity

[PR #567] [MERGED] fix(deno): stabilize reconnect integration test #566

New Issue
Closed
opened 2026-06-05 17:23:46 -04:00 by yindo · 0 comments
yindo commented 2026-06-05 17:23:46 -04:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/langchain-ai/deepagentsjs/pull/567
Author: @hntrl
Created: 6/1/2026
Status: ✅ Merged
Merged: 6/1/2026
Merged by: @hntrl

Base: main ← Head: hunter/fix-deno-reconnect-int-flake

📝 Commits (2)

  • bb78801 fix(deno): stabilize reconnect integration test
  • 8c145a4 test(standard-tests): retry env-var command assertion

📊 Changes

2 files changed (+16 additions, -4 deletions)

View changed files

📝 libs/providers/deno/src/sandbox.int.test.ts (+10 -2)
📝 libs/standard-tests/src/tests/command-execution.ts (+6 -2)

📄 Description

Summary

Stabilizes a flaky Deno provider integration test that intermittently failed in CI when reconnecting to an existing sandbox immediately after closing the original connection. The reconnect path can briefly return a transient 404 DEPLOYMENT_NOT_FOUND, causing otherwise healthy runs to fail. This change adds bounded retry/backoff during reconnect and ensures the reconnected sandbox handle is explicitly closed.

Changes

@langchain/deno

  • Updated reconnect integration test in libs/providers/deno/src/sandbox.int.test.ts to retry DenoSandbox.fromId(sandboxId) with withRetry (5 attempts, 1s delay).
  • Added a short comment documenting the transient reconnect window after WebSocket close.
  • Added explicit cleanup for the reconnected sandbox to avoid leaking extra connections during the test run.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/langchain-ai/deepagentsjs/pull/567 **Author:** [@hntrl](https://github.com/hntrl) **Created:** 6/1/2026 **Status:** ✅ Merged **Merged:** 6/1/2026 **Merged by:** [@hntrl](https://github.com/hntrl) **Base:** `main` ← **Head:** `hunter/fix-deno-reconnect-int-flake` --- ### 📝 Commits (2) - [`bb78801`](https://github.com/langchain-ai/deepagentsjs/commit/bb7880192b5ab770b225fe00957ad33a56a49069) fix(deno): stabilize reconnect integration test - [`8c145a4`](https://github.com/langchain-ai/deepagentsjs/commit/8c145a4872649272f7f7aee23d0cb0a56e5697e6) test(standard-tests): retry env-var command assertion ### 📊 Changes **2 files changed** (+16 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `libs/providers/deno/src/sandbox.int.test.ts` (+10 -2) 📝 `libs/standard-tests/src/tests/command-execution.ts` (+6 -2) </details> ### 📄 Description ## Summary Stabilizes a flaky Deno provider integration test that intermittently failed in CI when reconnecting to an existing sandbox immediately after closing the original connection. The reconnect path can briefly return a transient `404 DEPLOYMENT_NOT_FOUND`, causing otherwise healthy runs to fail. This change adds bounded retry/backoff during reconnect and ensures the reconnected sandbox handle is explicitly closed. ## Changes ### `@langchain/deno` - Updated reconnect integration test in `libs/providers/deno/src/sandbox.int.test.ts` to retry `DenoSandbox.fromId(sandboxId)` with `withRetry` (`5` attempts, `1s` delay). - Added a short comment documenting the transient reconnect window after WebSocket close. - Added explicit cleanup for the reconnected sandbox to avoid leaking extra connections during the test run. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-06-05 17:23:46 -04:00
yindo closed this issue 2026-06-05 17:23:46 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
help wanted
needs-response
pull-request
Mirrored from GitHub Pull Request
 stale
triage: high-impact
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langchain-ai/deepagentsjs#566
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?