langchain-ai/deepagentsjs
1
0
Fork 0
mirror of https://github.com/langchain-ai/deepagentsjs.git synced 2026-07-16 05:30:30 -04:00
Code Issues 42 Packages Projects Releases 10 Wiki Activity

[PR #577] [MERGED] chore(deepagents): clarify LocalShellBackend virtualMode behavior #576

New Issue
Closed
opened 2026-06-05 17:23:48 -04:00 by yindo · 0 comments
yindo commented 2026-06-05 17:23:48 -04:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/langchain-ai/deepagentsjs/pull/577
Author: @hntrl
Created: 6/2/2026
Status: ✅ Merged
Merged: 6/2/2026
Merged by: @hntrl

Base: main ← Head: hunter/local-shell-virtualmode-guidance

📝 Commits (1)

  • 52b4b60 chore(deepagents): clarify LocalShellBackend virtualMode behavior

📊 Changes

2 files changed (+28 additions, -0 deletions)

View changed files

📝 libs/deepagents/src/backends/local-shell.test.ts (+23 -0)
📝 libs/deepagents/src/backends/local-shell.ts (+5 -0)

📄 Description

Summary

Fixes #544.

Clarifies LocalShellBackend path semantics without introducing a breaking default change. This keeps legacy behavior intact while making the bounded-workspace setup explicit in docs and examples.

Changes

deepagents (LocalShellBackend)

  • Clarified LocalShellBackendOptions docs to explicitly note that rootDir does not bound filesystem paths when virtualMode is false.
  • Updated LocalShellBackend examples to use virtualMode: true when bounded path semantics are intended.
  • Added unit coverage to assert legacy behavior is preserved: with virtualMode: false, absolute writes can resolve outside rootDir.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/langchain-ai/deepagentsjs/pull/577 **Author:** [@hntrl](https://github.com/hntrl) **Created:** 6/2/2026 **Status:** ✅ Merged **Merged:** 6/2/2026 **Merged by:** [@hntrl](https://github.com/hntrl) **Base:** `main` ← **Head:** `hunter/local-shell-virtualmode-guidance` --- ### 📝 Commits (1) - [`52b4b60`](https://github.com/langchain-ai/deepagentsjs/commit/52b4b60ed2cdc20b4e14979184319d6a1cda44d9) chore(deepagents): clarify LocalShellBackend virtualMode behavior ### 📊 Changes **2 files changed** (+28 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `libs/deepagents/src/backends/local-shell.test.ts` (+23 -0) 📝 `libs/deepagents/src/backends/local-shell.ts` (+5 -0) </details> ### 📄 Description ## Summary Fixes #544. Clarifies `LocalShellBackend` path semantics without introducing a breaking default change. This keeps legacy behavior intact while making the bounded-workspace setup explicit in docs and examples. ## Changes ### deepagents (`LocalShellBackend`) - Clarified `LocalShellBackendOptions` docs to explicitly note that `rootDir` does not bound filesystem paths when `virtualMode` is `false`. - Updated `LocalShellBackend` examples to use `virtualMode: true` when bounded path semantics are intended. - Added unit coverage to assert legacy behavior is preserved: with `virtualMode: false`, absolute writes can resolve outside `rootDir`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-06-05 17:23:48 -04:00
yindo closed this issue 2026-06-05 17:23:48 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
help wanted
needs-response
pull-request
Mirrored from GitHub Pull Request
 stale
triage: high-impact
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langchain-ai/deepagentsjs#576
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?