mirror of
https://github.com/langchain-ai/delta-rs.git
synced 2026-07-21 01:35:22 -04:00
Bhavana Sundar
c85075e427
# Description Added `deprecate_positional_commit_args` to `_util.py` as a helper that preserves legacy positional behavior per method, emits a DeprecationWarning, rejects invalid usage, and normalizes to canonical commit_properties-first order. Wired into all public mutating APIs across `table.py`, `writer/convert_to.py`, and `transaction.py`. `write_deltalake` params reordered to canonical order (already keyword-only, no shim needed). `restore` left untouched (already keyword-only). Unit tests added in `tests/test_util.py`. # Related Issue(s) - closes #4252 Notes: - `_internal.pyi stubs are already in canonical order - `create()` and `vacuum()` handle legacy positional args inline (they had extra trailing params beyond the commit args, so the shared helper is bypassed for those two) Follow-up PR will make all APIs keyword-only and remove the compatibility path AI disclosure: I used Claude as a coding assistant to help map out affected methods. I reviewed every modification, ran the full test suite locally, and understand each change made. --------- Signed-off-by: Bhavana Sundar <bhavana7899@gmail.com> Co-authored-by: Ethan Urbanski <ethanurbanski@gmail.com>