langchain-ai/docs
1
0
Fork 0
mirror of https://github.com/langchain-ai/docs.git synced 2026-07-23 21:05:23 -04:00
Code Issues 490 Packages Projects Releases Wiki Activity

[PR #1621] [MERGED] fix: unused model var and runtime type error #1703

New Issue
Closed
opened 2026-02-17 17:22:38 -05:00 by yindo · 0 comments
yindo commented 2026-02-17 17:22:38 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/langchain-ai/docs/pull/1621
Author: @bwhiting2356
Created: 11/25/2025
Status: ✅ Merged
Merged: 11/25/2025
Merged by: @christian-bromann

Base: main ← Head: brendan/js-docs-update

📝 Commits (3)

📊 Changes

1 file changed (+8 additions, -7 deletions)

View changed files

📝 src/oss/langchain/quickstart.mdx (+8 -7)

📄 Description

Overview

Fixing two issues in this section of the docs: an unused model var and type errors with tool Runtime

Type of change

  • In the "Full example code" section, model was defined but never used. Now we pass in the model object instead of the string.
  • Fixing type errors from Runtime when we defined getUserLocation, both in "Full example code" and the earlier snippet.
  • Using object shorthand properties consistently

Checklist

  • I have read the contributing guidelines
  • I have tested my changes locally using docs dev
  • All code examples have been tested and work correctly
  • I have used root relative paths for internal links
  • I have updated navigation in src/docs.json if needed

(Internal team members only / optional): Create a preview deployment as necessary using the Create Preview Branch workflow

Additional notes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/langchain-ai/docs/pull/1621 **Author:** [@bwhiting2356](https://github.com/bwhiting2356) **Created:** 11/25/2025 **Status:** ✅ Merged **Merged:** 11/25/2025 **Merged by:** [@christian-bromann](https://github.com/christian-bromann) **Base:** `main` ← **Head:** `brendan/js-docs-update` --- ### 📝 Commits (3) - [`1a7c60c`](https://github.com/langchain-ai/docs/commit/1a7c60c9b809e2eef372251363394be4e4db56ec) fix unused var and type error - [`9e19fc6`](https://github.com/langchain-ai/docs/commit/9e19fc6009d70c8afe0ab58f14dff2330bf7fed5) more object shorthand - [`cccacd0`](https://github.com/langchain-ai/docs/commit/cccacd0b91887ed34230b642e8b3c6b635beb56b) reorder ### 📊 Changes **1 file changed** (+8 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `src/oss/langchain/quickstart.mdx` (+8 -7) </details> ### 📄 Description ## Overview Fixing two issues in this section of the docs: an unused model var and type errors with tool `Runtime` ## Type of change * In the "Full example code" section, `model` was defined but never used. Now we pass in the `model` object instead of the string. * Fixing type errors from `Runtime` when we defined `getUserLocation`, both in "Full example code" and the earlier snippet. * Using object shorthand properties consistently - [Slack thread](https://langchain.slack.com/archives/C04S2MUSHA4/p1764047118495919) ## Checklist <!-- Put an 'x' in all boxes that apply --> - [x] I have read the [contributing guidelines](README.md) - [x] I have tested my changes locally using `docs dev` - [x] All code examples have been tested and work correctly - [ ] I have used **root relative** paths for internal links - [ ] I have updated navigation in `src/docs.json` if needed (Internal team members only / optional): Create a preview deployment as necessary using the [Create Preview Branch workflow](https://github.com/langchain-ai/docs/actions/workflows/create-preview-branch.yml) ## Additional notes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-17 17:22:38 -05:00
yindo closed this issue 2026-02-17 17:22:38 -05:00
yindo changed title from [PR #1621] fix: unused model var and runtime type error to [PR #1621] [MERGED] fix: unused model var and runtime type error 2026-06-05 18:14:29 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
deepagents
docs-infra
external
external
help wanted
integration
internal
internal
javascript
js/ts
langchain
langgraph
langsmith
needs-title
pull-request
Mirrored from GitHub Pull Request
 python
reference
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langchain-ai/docs#1703
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?