langchain-ai/docs
1
0
Fork 0
mirror of https://github.com/langchain-ai/docs.git synced 2026-07-22 12:25:55 -04:00
Code Issues 490 Packages Projects Releases Wiki Activity

[PR #2948] [MERGED] docs: clarify memory approval for scheduled agents [closes DOC-799] #3032

New Issue
Closed
opened 2026-06-05 18:20:53 -04:00 by yindo · 0 comments
yindo commented 2026-06-05 18:20:53 -04:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/langchain-ai/docs/pull/2948
Author: @lnhsingh
Created: 3/5/2026
Status: ✅ Merged
Merged: 3/6/2026
Merged by: @lnhsingh

Base: main ← Head: open-swe/f923c558-9d42-ad55-bb66-a4c5c3f67d4f

📝 Commits (2)

  • 9d3b678 Clarify that memory approval controls write_file/edit_file calls and impacts scheduled agents
  • a653882 Apply suggestions from code review

📊 Changes

2 files changed (+15 additions, -5 deletions)

View changed files

📝 src/langsmith/agent-builder-essentials.mdx (+7 -3)
📝 src/langsmith/agent-builder-manage-agent-settings.mdx (+8 -2)

📄 Description

Description

Clarifies that Agent Builder's memory approval setting controls write_file/edit_file tool calls to the memories folder, and explains the impact on scheduled (cron) agents.

The issue reported that it was unclear that write_file/edit_file tool requests correspond to memory updates, and that leaving approval enabled on scheduled agents causes runs to pause indefinitely waiting for manual approval.

Changes:

  • agent-builder-manage-agent-settings.mdx: Expanded the "Update memory" section to explain that memories are persisted via write_file/edit_file calls, describe what happens when approval is enabled (agent pauses), and added a tip callout specifically for cron/scheduled agents recommending they disable the approval requirement.
  • agent-builder-essentials.mdx: Updated the "Memory and updates" section to explain the underlying mechanism (file writes to memories folder), mention the default approval behavior, and link to the settings page for instructions on disabling it for automated agents.

Resolves DOC-799

Test Plan

  • Verify the "Update memory" section on the settings page clearly explains the write_file/edit_file connection
  • Verify the tip callout for scheduled agents is visible and actionable
  • Verify the essentials page links correctly to the settings page anchor
  • Verify the cron trigger link resolves correctly

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/langchain-ai/docs/pull/2948 **Author:** [@lnhsingh](https://github.com/lnhsingh) **Created:** 3/5/2026 **Status:** ✅ Merged **Merged:** 3/6/2026 **Merged by:** [@lnhsingh](https://github.com/lnhsingh) **Base:** `main` ← **Head:** `open-swe/f923c558-9d42-ad55-bb66-a4c5c3f67d4f` --- ### 📝 Commits (2) - [`9d3b678`](https://github.com/langchain-ai/docs/commit/9d3b678eeddc7097509f945b9580c5f602895c3a) Clarify that memory approval controls write_file/edit_file calls and impacts scheduled agents - [`a653882`](https://github.com/langchain-ai/docs/commit/a653882750e0f424ccbfed03becfc204402f6ee9) Apply suggestions from code review ### 📊 Changes **2 files changed** (+15 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `src/langsmith/agent-builder-essentials.mdx` (+7 -3) 📝 `src/langsmith/agent-builder-manage-agent-settings.mdx` (+8 -2) </details> ### 📄 Description ## Description Clarifies that Agent Builder's memory approval setting controls `write_file`/`edit_file` tool calls to the memories folder, and explains the impact on scheduled (cron) agents. The issue reported that it was unclear that `write_file`/`edit_file` tool requests correspond to memory updates, and that leaving approval enabled on scheduled agents causes runs to pause indefinitely waiting for manual approval. Changes: - **`agent-builder-manage-agent-settings.mdx`**: Expanded the "Update memory" section to explain that memories are persisted via `write_file`/`edit_file` calls, describe what happens when approval is enabled (agent pauses), and added a tip callout specifically for cron/scheduled agents recommending they disable the approval requirement. - **`agent-builder-essentials.mdx`**: Updated the "Memory and updates" section to explain the underlying mechanism (file writes to memories folder), mention the default approval behavior, and link to the settings page for instructions on disabling it for automated agents. Resolves DOC-799 ## Test Plan - [ ] Verify the "Update memory" section on the settings page clearly explains the `write_file`/`edit_file` connection - [ ] Verify the tip callout for scheduled agents is visible and actionable - [ ] Verify the essentials page links correctly to the settings page anchor - [ ] Verify the cron trigger link resolves correctly --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-06-05 18:20:53 -04:00
yindo closed this issue 2026-06-05 18:20:53 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
deepagents
docs-infra
external
external
help wanted
integration
internal
internal
javascript
js/ts
langchain
langgraph
langsmith
needs-title
pull-request
Mirrored from GitHub Pull Request
 python
reference
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langchain-ai/docs#3032
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?