langchain-ai/docs
1
0
Fork 0
mirror of https://github.com/langchain-ai/docs.git synced 2026-07-22 04:15:25 -04:00
Code Issues 490 Packages Projects Releases Wiki Activity

[PR #3325] [MERGED] Fix encryption docs: stop steering users toward custom encryption when basic suffices #3382

New Issue
Closed
opened 2026-06-05 18:22:55 -04:00 by yindo · 0 comments
yindo commented 2026-06-05 18:22:55 -04:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/langchain-ai/docs/pull/3325
Author: @cwlbraa
Created: 3/26/2026
Status: ✅ Merged
Merged: 5/4/2026
Merged by: @cwlbraa

Base: main ← Head: cwlbraa/lsd-less-custom-encryption

📝 Commits (1)

  • 5499fd5 Fix encryption docs to stop steering users toward custom when basic suffices

📊 Changes

1 file changed (+6 additions, -3 deletions)

View changed files

📝 src/langsmith/encryption.mdx (+6 -3)

📄 Description

  • Moves "selective field encryption" to the basic encryption row in the comparison table — LANGGRAPH_AES_JSON_KEYS already handles this use case, so listing it as a reason to use custom encryption was misleading
  • Removes the "Selective field encryption" bullet from the custom encryption use-case list
  • Adds a prominent <Warning> box at the top of the custom encryption section making it explicit that custom encryption should only be used when basic encryption doesn't meet your needs

Why

The doc was implicitly directing users toward custom encryption (more complex, requires implementing/maintaining handlers) for a use case (selective field encryption) that basic encryption already covers natively. This increases operational burden unnecessarily.

I've already jumped on one random customer call to Shepard folks in the right direction, this should prevent that from repeating.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/langchain-ai/docs/pull/3325 **Author:** [@cwlbraa](https://github.com/cwlbraa) **Created:** 3/26/2026 **Status:** ✅ Merged **Merged:** 5/4/2026 **Merged by:** [@cwlbraa](https://github.com/cwlbraa) **Base:** `main` ← **Head:** `cwlbraa/lsd-less-custom-encryption` --- ### 📝 Commits (1) - [`5499fd5`](https://github.com/langchain-ai/docs/commit/5499fd52e1ebb3c5adba2e3c9100f420ffab51a9) Fix encryption docs to stop steering users toward custom when basic suffices ### 📊 Changes **1 file changed** (+6 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/langsmith/encryption.mdx` (+6 -3) </details> ### 📄 Description - Moves "selective field encryption" to the basic encryption row in the comparison table — `LANGGRAPH_AES_JSON_KEYS` already handles this use case, so listing it as a reason to use custom encryption was misleading - Removes the "Selective field encryption" bullet from the custom encryption use-case list - Adds a prominent `<Warning>` box at the top of the custom encryption section making it explicit that custom encryption should only be used when basic encryption doesn't meet your needs ## Why The doc was implicitly directing users toward custom encryption (more complex, requires implementing/maintaining handlers) for a use case (selective field encryption) that basic encryption already covers natively. This increases operational burden unnecessarily. I've already jumped on one random customer call to Shepard folks in the right direction, this should prevent that from repeating. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-06-05 18:22:55 -04:00
yindo closed this issue 2026-06-05 18:22:55 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
deepagents
docs-infra
external
external
help wanted
integration
internal
internal
javascript
js/ts
langchain
langgraph
langsmith
needs-title
pull-request
Mirrored from GitHub Pull Request
 python
reference
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langchain-ai/docs#3382
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?