[PR #606] [MERGED] Clarify what subdomain is for when configuring ingress #852

Closed
opened 2026-02-17 17:21:15 -05:00 by yindo · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/langchain-ai/docs/pull/606
Author: @rahul-langchain
Created: 9/19/2025
Status: Merged
Merged: 9/23/2025
Merged by: @rahul-langchain

Base: mainHead: rahul/clarify-ingress-subdomain


📝 Commits (4)

  • d9c1ae3 Clarify what subdomain is for when configuring ingress
  • 101e4b6 Update src/langsmith/self-host-ingress.mdx
  • a6fa246 Address feedback
  • 2c407cd Merge branch 'main' into rahul/clarify-ingress-subdomain

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 src/langsmith/self-host-ingress.mdx (+1 -1)

📄 Description

Overview

Subdomain really means URL path in these docs, so adding some clarifying language.

Type of change

Type: Other

Checklist

  • I have read the contributing guidelines
  • I have tested my changes locally using docs dev
  • All code examples have been tested and work correctly
  • I have used root relative paths for internal links
  • I have updated navigation in src/docs.json if needed
  • I have gotten approval from the relevant reviewers
  • (Internal team members only / optional) I have created a preview deployment using the Create Preview Branch workflow

Additional notes


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/langchain-ai/docs/pull/606 **Author:** [@rahul-langchain](https://github.com/rahul-langchain) **Created:** 9/19/2025 **Status:** ✅ Merged **Merged:** 9/23/2025 **Merged by:** [@rahul-langchain](https://github.com/rahul-langchain) **Base:** `main` ← **Head:** `rahul/clarify-ingress-subdomain` --- ### 📝 Commits (4) - [`d9c1ae3`](https://github.com/langchain-ai/docs/commit/d9c1ae3595f915cc3e2314a51e26e367d03a5e15) Clarify what subdomain is for when configuring ingress - [`101e4b6`](https://github.com/langchain-ai/docs/commit/101e4b6f929655f2dae99f2dbadea5778bcc0b45) Update src/langsmith/self-host-ingress.mdx - [`a6fa246`](https://github.com/langchain-ai/docs/commit/a6fa2462504db377c0614366a73073a51ded3186) Address feedback - [`2c407cd`](https://github.com/langchain-ai/docs/commit/2c407cd282df09bb5ee32235289aba883275681a) Merge branch 'main' into rahul/clarify-ingress-subdomain ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/langsmith/self-host-ingress.mdx` (+1 -1) </details> ### 📄 Description ## Overview Subdomain really means URL path in these docs, so adding some clarifying language. ## Type of change **Type:** Other ## Checklist <!-- Put an 'x' in all boxes that apply --> - [x] I have read the [contributing guidelines](README.md) - [x] I have tested my changes locally using `docs dev` - [ ] All code examples have been tested and work correctly - [ ] I have used **root relative** paths for internal links - [ ] I have updated navigation in `src/docs.json` if needed - [ ] I have gotten approval from the relevant reviewers - [ ] (Internal team members only / optional) I have created a preview deployment using the [Create Preview Branch workflow](https://github.com/langchain-ai/docs/actions/workflows/create-preview-branch.yml) ## Additional notes <!-- Any other information that would be helpful for reviewers --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-17 17:21:15 -05:00
yindo closed this issue 2026-02-17 17:21:15 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langchain-ai/docs#852