langchain-ai/helm
1
0
Fork 0
mirror of https://github.com/langchain-ai/helm.git synced 2026-07-24 12:35:55 -04:00
Code Issues 24 Packages Projects Releases 10 Wiki Activity

[PR #520] [MERGED] chore: Explicitly specify revisionHistoryLimit for operator deployment template #523

New Issue
Closed
opened 2026-02-16 02:16:32 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 02:16:32 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/langchain-ai/helm/pull/520
Author: @andrewnguonly
Created: 11/24/2025
Status: ✅ Merged
Merged: 11/24/2025
Merged by: @andrewnguonly

Base: main ← Head: an/24nov/revision-history-limit

📝 Commits (1)

  • 1b0428d Explicity specify revisionHistoryLimit for operator deployment template.

📊 Changes

2 files changed (+2 additions, -0 deletions)

View changed files

📝 charts/langgraph-dataplane/values.yaml (+1 -0)
📝 charts/langsmith/values.yaml (+1 -0)

📄 Description

Summary

We're including the spec.revisionHistoryLimit in the operator deployment template to make it explicit that this field can be configured (defaults to 10).

Context:

  1. The operator creates a K8s Deployment resource for a LangSmith Deployment.
  2. When a new revision is created in the LangSmith Deployment UI, a new Replica Set is created for the underlying K8s Deployment.

It's possible that a "bad" deployment may accumulate Replica Sets that are left in a non-functional state (e.g. pods are in CrashLoopBackOff), which may result in resources (CPU, memory) being wasted. spec.revisionHistoryLimit can be configured to a lower number to reduce the number of revisions that are held.

This is useful in non-production environments (test, dev, staging, etc).

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/langchain-ai/helm/pull/520 **Author:** [@andrewnguonly](https://github.com/andrewnguonly) **Created:** 11/24/2025 **Status:** ✅ Merged **Merged:** 11/24/2025 **Merged by:** [@andrewnguonly](https://github.com/andrewnguonly) **Base:** `main` ← **Head:** `an/24nov/revision-history-limit` --- ### 📝 Commits (1) - [`1b0428d`](https://github.com/langchain-ai/helm/commit/1b0428df70a42d6c190110de2b9794584b0eb04f) Explicity specify revisionHistoryLimit for operator deployment template. ### 📊 Changes **2 files changed** (+2 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `charts/langgraph-dataplane/values.yaml` (+1 -0) 📝 `charts/langsmith/values.yaml` (+1 -0) </details> ### 📄 Description ### Summary We're including the `spec.revisionHistoryLimit` in the `operator` deployment template to make it explicit that this field can be configured (defaults to 10). Context: 1. The `operator` creates a K8s Deployment resource for a LangSmith Deployment. 1. When a new revision is created in the LangSmith Deployment UI, a new Replica Set is created for the underlying K8s Deployment. It's possible that a "bad" deployment may accumulate Replica Sets that are left in a non-functional state (e.g. pods are in `CrashLoopBackOff`), which may result in resources (CPU, memory) being wasted. `spec.revisionHistoryLimit` can be configured to a lower number to reduce the number of revisions that are held. This is useful in non-production environments (`test`, `dev`, `staging`, etc). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-16 02:16:32 -05:00
yindo closed this issue 2026-02-16 02:16:32 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langchain-ai/helm#523
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?