langchain-ai/helm
1
0
Fork 0
mirror of https://github.com/langchain-ai/helm.git synced 2026-07-24 12:35:55 -04:00
Code Issues 24 Packages Projects Releases 10 Wiki Activity

[PR #676] [MERGED] feat: make jwtAudiences required in langsmith-auth-proxy #675

New Issue
Closed
opened 2026-06-05 19:17:22 -04:00 by yindo · 0 comments
yindo commented 2026-06-05 19:17:22 -04:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/langchain-ai/helm/pull/676
Author: @bvs-langchain
Created: 4/15/2026
Status: ✅ Merged
Merged: 4/15/2026
Merged by: @bvs-langchain

Base: main ← Head: brian/lsd-1401-make-jwtaudiences-required-in-langsmith-auth-proxy-chart

📝 Commits (2)

  • c6657fb feat: make jwtAudiences required in langsmith-auth-proxy chart
  • b924057 test: add jwtAudiences unit tests and fix existing test suites

📊 Changes

11 files changed (+57 additions, -7 deletions)

View changed files

📝 charts/langsmith-auth-proxy/Chart.yaml (+1 -1)
📝 charts/langsmith-auth-proxy/README.md (+2 -2)
📝 charts/langsmith-auth-proxy/e2e/oauth/values.yaml (+2 -1)
📝 charts/langsmith-auth-proxy/templates/auth-proxy/config-map.yaml (+3 -2)
📝 charts/langsmith-auth-proxy/tests/allowed_upstream_headers_test.yaml (+2 -0)
➕ charts/langsmith-auth-proxy/tests/common-values.yaml (+5 -0)
📝 charts/langsmith-auth-proxy/tests/jwks_uri_test.yaml (+2 -0)
➕ charts/langsmith-auth-proxy/tests/jwt_audiences_test.yaml (+35 -0)
📝 charts/langsmith-auth-proxy/tests/transformer_test.yaml (+2 -0)
📝 charts/langsmith-auth-proxy/tests/upstream_path_prefix_test.yaml (+2 -0)
📝 charts/langsmith-auth-proxy/values.yaml (+1 -1)

📄 Description

Summary

  • authProxy.jwtAudiences is now required when authProxy.enabled is true — the chart fails at render time with a clear error if the list is empty
  • Adds unit tests for the validation (empty fails, single/multiple audiences render correctly)
  • Bumps chart version to 0.0.10

Closes LSD-1401

Test plan

  • helm template fails with clear error when jwtAudiences is empty and authProxy.enabled=true
  • helm template succeeds when authProxy.enabled=false with no audiences
  • helm unittest — all 43 tests pass
  • All CI and e2e value files provide audiences

🤖 Generated with Claude Code

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/langchain-ai/helm/pull/676 **Author:** [@bvs-langchain](https://github.com/bvs-langchain) **Created:** 4/15/2026 **Status:** ✅ Merged **Merged:** 4/15/2026 **Merged by:** [@bvs-langchain](https://github.com/bvs-langchain) **Base:** `main` ← **Head:** `brian/lsd-1401-make-jwtaudiences-required-in-langsmith-auth-proxy-chart` --- ### 📝 Commits (2) - [`c6657fb`](https://github.com/langchain-ai/helm/commit/c6657fbfe67d37072dfce7155c515918909d305a) feat: make jwtAudiences required in langsmith-auth-proxy chart - [`b924057`](https://github.com/langchain-ai/helm/commit/b924057e45b4568679ecfced83f0e3dcd39822d9) test: add jwtAudiences unit tests and fix existing test suites ### 📊 Changes **11 files changed** (+57 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `charts/langsmith-auth-proxy/Chart.yaml` (+1 -1) 📝 `charts/langsmith-auth-proxy/README.md` (+2 -2) 📝 `charts/langsmith-auth-proxy/e2e/oauth/values.yaml` (+2 -1) 📝 `charts/langsmith-auth-proxy/templates/auth-proxy/config-map.yaml` (+3 -2) 📝 `charts/langsmith-auth-proxy/tests/allowed_upstream_headers_test.yaml` (+2 -0) ➕ `charts/langsmith-auth-proxy/tests/common-values.yaml` (+5 -0) 📝 `charts/langsmith-auth-proxy/tests/jwks_uri_test.yaml` (+2 -0) ➕ `charts/langsmith-auth-proxy/tests/jwt_audiences_test.yaml` (+35 -0) 📝 `charts/langsmith-auth-proxy/tests/transformer_test.yaml` (+2 -0) 📝 `charts/langsmith-auth-proxy/tests/upstream_path_prefix_test.yaml` (+2 -0) 📝 `charts/langsmith-auth-proxy/values.yaml` (+1 -1) </details> ### 📄 Description ## Summary - `authProxy.jwtAudiences` is now required when `authProxy.enabled` is true — the chart fails at render time with a clear error if the list is empty - Adds unit tests for the validation (empty fails, single/multiple audiences render correctly) - Bumps chart version to 0.0.10 Closes LSD-1401 ## Test plan - [x] `helm template` fails with clear error when `jwtAudiences` is empty and `authProxy.enabled=true` - [x] `helm template` succeeds when `authProxy.enabled=false` with no audiences - [x] `helm unittest` — all 43 tests pass - [x] All CI and e2e value files provide audiences 🤖 Generated with [Claude Code](https://claude.com/claude-code) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-06-05 19:17:22 -04:00
yindo closed this issue 2026-06-05 19:17:22 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langchain-ai/helm#675
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?