langchain-ai/helm
1
0
Fork 0
mirror of https://github.com/langchain-ai/helm.git synced 2026-07-25 04:56:50 -04:00
Code Issues 24 Packages Projects Releases 10 Wiki Activity

[PR #682] [MERGED] chore: remove feedback migration jobs and configurations #683

New Issue
Closed
opened 2026-06-05 19:17:24 -04:00 by yindo · 0 comments
yindo commented 2026-06-05 19:17:24 -04:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/langchain-ai/helm/pull/682
Author: @langchain-infra
Created: 4/17/2026
Status: ✅ Merged
Merged: 4/17/2026
Merged by: @langchain-infra

Base: v14-stable ← Head: mukil/v14-stable-remove-feedback-migrations

📝 Commits (1)

  • 082c447 chore: remove feedback migration jobs and configurations

📊 Changes

9 files changed (+0 additions, -380 deletions)

View changed files

📝 charts/langsmith/README.md (+0 -46)
📝 charts/langsmith/ci/custom-ca-external-redis-values.yaml (+0 -11)
📝 charts/langsmith/ci/lightweight-config-ingest-queue-values.yaml (+0 -11)
📝 charts/langsmith/ci/lightweight-config-values.yaml (+0 -11)
📝 charts/langsmith/ci/readonly-config-values.yaml (+0 -37)
📝 charts/langsmith/examples/mtls_config.yaml (+0 -4)
➖ charts/langsmith/templates/backend/feedback-config-migration.yaml (+0 -100)
➖ charts/langsmith/templates/backend/feedback-data-migration.yaml (+0 -100)
📝 charts/langsmith/values.yaml (+0 -60)

📄 Description

Summary

  • Deletes the feedback-data-migration and feedback-config-migration Jobs and their backend.feedbackDataMigration / backend.feedbackConfigMigration values blocks.
  • Drops all related rows from README.md, the four ci/*.yaml fixtures, and examples/mtls_config.yaml.
  • Both Jobs were enabled: false by default and invoked one-shot scripts (migrate-feedback-to-postgres.pyc, migrate-feedback-config.pyc) that are no longer shipped in the backend image, so they were dead code.

Net diff: 9 files, -380 lines.

Test plan

  • helm lint charts/langsmith passes
  • helm template against all four ci/*.yaml fixtures renders with no feedback-migration / fb-migrations / config-migrations manifests
  • Repo-wide grep for feedback.?[Mm]igration, feedbackConfigMigration, feedbackDataMigration, migrate-feedback returns no matches

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/langchain-ai/helm/pull/682 **Author:** [@langchain-infra](https://github.com/langchain-infra) **Created:** 4/17/2026 **Status:** ✅ Merged **Merged:** 4/17/2026 **Merged by:** [@langchain-infra](https://github.com/langchain-infra) **Base:** `v14-stable` ← **Head:** `mukil/v14-stable-remove-feedback-migrations` --- ### 📝 Commits (1) - [`082c447`](https://github.com/langchain-ai/helm/commit/082c44781ba45180b149b40d308a6e1f03696332) chore: remove feedback migration jobs and configurations ### 📊 Changes **9 files changed** (+0 additions, -380 deletions) <details> <summary>View changed files</summary> 📝 `charts/langsmith/README.md` (+0 -46) 📝 `charts/langsmith/ci/custom-ca-external-redis-values.yaml` (+0 -11) 📝 `charts/langsmith/ci/lightweight-config-ingest-queue-values.yaml` (+0 -11) 📝 `charts/langsmith/ci/lightweight-config-values.yaml` (+0 -11) 📝 `charts/langsmith/ci/readonly-config-values.yaml` (+0 -37) 📝 `charts/langsmith/examples/mtls_config.yaml` (+0 -4) ➖ `charts/langsmith/templates/backend/feedback-config-migration.yaml` (+0 -100) ➖ `charts/langsmith/templates/backend/feedback-data-migration.yaml` (+0 -100) 📝 `charts/langsmith/values.yaml` (+0 -60) </details> ### 📄 Description ## Summary - Deletes the `feedback-data-migration` and `feedback-config-migration` Jobs and their `backend.feedbackDataMigration` / `backend.feedbackConfigMigration` values blocks. - Drops all related rows from `README.md`, the four `ci/*.yaml` fixtures, and `examples/mtls_config.yaml`. - Both Jobs were `enabled: false` by default and invoked one-shot scripts (`migrate-feedback-to-postgres.pyc`, `migrate-feedback-config.pyc`) that are no longer shipped in the backend image, so they were dead code. Net diff: 9 files, -380 lines. ## Test plan - [x] `helm lint charts/langsmith` passes - [x] `helm template` against all four `ci/*.yaml` fixtures renders with no `feedback-migration` / `fb-migrations` / `config-migrations` manifests - [x] Repo-wide grep for `feedback.?[Mm]igration`, `feedbackConfigMigration`, `feedbackDataMigration`, `migrate-feedback` returns no matches --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-06-05 19:17:24 -04:00
yindo closed this issue 2026-06-05 19:17:24 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langchain-ai/helm#683
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?