langchain-ai/helm
1
0
Fork 0
mirror of https://github.com/langchain-ai/helm.git synced 2026-07-21 22:25:58 -04:00
Code Issues 24 Packages Projects Releases 10 Wiki Activity

[PR #692] ci: use FIPS image variants in langsmith readonly test #694

New Issue
Open
opened 2026-06-05 19:17:26 -04:00 by yindo · 0 comments
yindo commented 2026-06-05 19:17:26 -04:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/langchain-ai/helm/pull/692
Author: @langchain-infra
Created: 4/24/2026
Status: 🔄 Open

Base: main ← Head: mukil/readonly-test-fips-images

📝 Commits (2)

  • 4001a31 ci: use FIPS image variants in langsmith readonly test
  • 7e79eef chore: bump operator image to 0.1.50

📊 Changes

3 files changed (+18 additions, -2 deletions)

View changed files

📝 charts/langsmith/README.md (+1 -1)
📝 charts/langsmith/ci/readonly-config-values.yaml (+16 -0)
📝 charts/langsmith/values.yaml (+1 -1)

📄 Description

Summary

  • Overrides the 7 LangChain-authored image repositories in charts/langsmith/ci/readonly-config-values.yaml to their -fips counterparts so the readonly CI job exercises FIPS images alongside the readOnlyRootFilesystem: true configuration.
  • Only repository is overridden — tag and pullPolicy continue to flow from the chart's default values.yaml, so each release automatically pulls the matching FIPS build.
  • Follows the image mapping documented in langchain-ai/docs#3712. Third-party images (postgres/redis/clickhouse) and LangChain images without a published FIPS variant (clio, agent-builder-*, polly) are untouched.

Test plan

  • helm lint charts/langsmith -f charts/langsmith/ci/readonly-config-values.yaml
  • helm template charts/langsmith -f charts/langsmith/ci/readonly-config-values.yaml shows the 7 overridden repositories and default tag
  • CI readonly workflow pulls and runs the FIPS images successfully

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/langchain-ai/helm/pull/692 **Author:** [@langchain-infra](https://github.com/langchain-infra) **Created:** 4/24/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `mukil/readonly-test-fips-images` --- ### 📝 Commits (2) - [`4001a31`](https://github.com/langchain-ai/helm/commit/4001a311ee1d9783194d4445e9d0d1f4bd5c20b5) ci: use FIPS image variants in langsmith readonly test - [`7e79eef`](https://github.com/langchain-ai/helm/commit/7e79eefb31f15cf3f03a79aa084ef39ab0dc3b12) chore: bump operator image to 0.1.50 ### 📊 Changes **3 files changed** (+18 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `charts/langsmith/README.md` (+1 -1) 📝 `charts/langsmith/ci/readonly-config-values.yaml` (+16 -0) 📝 `charts/langsmith/values.yaml` (+1 -1) </details> ### 📄 Description ## Summary - Overrides the 7 LangChain-authored image repositories in `charts/langsmith/ci/readonly-config-values.yaml` to their `-fips` counterparts so the readonly CI job exercises FIPS images alongside the `readOnlyRootFilesystem: true` configuration. - Only `repository` is overridden — `tag` and `pullPolicy` continue to flow from the chart's default `values.yaml`, so each release automatically pulls the matching FIPS build. - Follows the image mapping documented in langchain-ai/docs#3712. Third-party images (postgres/redis/clickhouse) and LangChain images without a published FIPS variant (clio, agent-builder-*, polly) are untouched. ## Test plan - [x] `helm lint charts/langsmith -f charts/langsmith/ci/readonly-config-values.yaml` - [x] `helm template charts/langsmith -f charts/langsmith/ci/readonly-config-values.yaml` shows the 7 overridden repositories and default tag - [x] CI readonly workflow pulls and runs the FIPS images successfully --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-06-05 19:17:26 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langchain-ai/helm#694
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?