[PR #25] Remove deprecated code #26

New Issue

2026-02-15T18:16:13-05:00

yindo commented

2026-02-15 18:16:13 -05:00

📋 Pull Request Information

Original PR: https://github.com/langchain-ai/kork/pull/25
Author: @Sachin-Bhat
Created: 7/17/2024
Status: 🔄 Open

Base: main ← Head: feature-remove_deprecated_chain

📝 Commits (1)

98f2d59 Remove deprecated code

📊 Changes

6 files changed (+24 additions, -24 deletions)

View changed files

📝 kork/chain.py (+11 -13)
📝 kork/parser.py (+1 -1)
📝 kork/prompt_adapter.py (+2 -3)
📝 tests/test_chain.py (+4 -4)
📝 tests/test_prompt_adapter.py (+1 -1)
📝 tests/utils.py (+5 -2)

📄 Description

Hello @eyurtsev,

Here are the list of changes:

kork/chain.py:
- Removal of LLMChain in favor of RunnableSequence as per LCEL
- Fixing some imports
- Removal of pydantic.config.Extra and instead assigning literals to the extra attribute
- Removal of cast() and predict_and_parse() in favor of .content and invoke()
kork/parser.py:
- convert the GRAMMAR to a raw string
kork/prompt_adapter.py:
- Fixing some imports
- Removal of pydantic.config.Extra and instead assigning literals to the extra attribute
tests/test_chain.py:
- removing Chain.__call__() in favor of .invoke()
tests/test_prompt_adapter.py:
- Fixing some imports
tests/utils.py:
- Removal of pydantic.config.Extra and instead assigning literals to the extra attribute
- addition of property _llm_type() to ensure that the test_chain passes since .invoke() needs this property to function correctly

Merging this fixes #24. Please let me know if further changes are required or if I have missed something.

Cheers,
Sachin

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/langchain-ai/kork/pull/25 **Author:** [@Sachin-Bhat](https://github.com/Sachin-Bhat) **Created:** 7/17/2024 **Status:** 🔄 Open **Base:** `main` ← **Head:** `feature-remove_deprecated_chain` --- ### 📝 Commits (1) - [`98f2d59`](https://github.com/langchain-ai/kork/commit/98f2d59fc797693f502046bcfe3ac320c7824761) Remove deprecated code ### 📊 Changes **6 files changed** (+24 additions, -24 deletions) <details> <summary>View changed files</summary> 📝 `kork/chain.py` (+11 -13) 📝 `kork/parser.py` (+1 -1) 📝 `kork/prompt_adapter.py` (+2 -3) 📝 `tests/test_chain.py` (+4 -4) 📝 `tests/test_prompt_adapter.py` (+1 -1) 📝 `tests/utils.py` (+5 -2) </details> ### 📄 Description Hello @eyurtsev, Here are the list of changes: - kork/chain.py: - Removal of `LLMChain` in favor of `RunnableSequence` as per LCEL - Fixing some imports - Removal of `pydantic.config.Extra` and instead assigning literals to the `extra` attribute - Removal of `cast()` and `predict_and_parse()` in favor of `.content` and `invoke()` - kork/parser.py: - convert the GRAMMAR to a raw string - kork/prompt_adapter.py: - Fixing some imports - Removal of `pydantic.config.Extra` and instead assigning literals to the `extra` attribute - tests/test_chain.py: - removing `Chain.__call__()` in favor of `.invoke()` - tests/test_prompt_adapter.py: - Fixing some imports - tests/utils.py: - Removal of `pydantic.config.Extra` and instead assigning literals to the `extra` attribute - addition of property `_llm_type()` to ensure that the `test_chain` passes since `.invoke()` needs this property to function correctly Merging this fixes #24. Please let me know if further changes are required or if I have missed something. Cheers, Sachin --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

yindo added the pull-request label 2026-02-15 18:16:13 -05:00

yindo referenced this issue

2026-06-05 19:18:22 -04:00

[PR #26] [MERGED] add not maintained #25

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: langchain-ai/kork#26