langchain-ai/langchain-pinecone
1
0
Fork 0
mirror of https://github.com/langchain-ai/langchain-pinecone.git synced 2026-07-18 18:54:37 -04:00
Code Issues 11 Packages Projects Releases 10 Wiki Activity

[PR #27] [MERGED] chore: Rerank unit and integration tests #49

New Issue
Closed
opened 2026-02-16 07:16:07 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 07:16:07 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/langchain-ai/langchain-pinecone/pull/27
Author: @simjak
Created: 5/6/2025
Status: ✅ Merged
Merged: 5/7/2025
Merged by: @jamescalam

Base: feat/reranker ← Head: feat/reranker

📝 Commits (5)

📊 Changes

6 files changed (+701 additions, -165 deletions)

View changed files

📝 libs/pinecone/langchain_pinecone/__init__.py (+2 -2)
➖ libs/pinecone/langchain_pinecone/pinecone_rerank.py (+0 -163)
➕ libs/pinecone/langchain_pinecone/rerank.py (+287 -0)
➕ libs/pinecone/tests/integration_tests/test_rerank.py (+105 -0)
📝 libs/pinecone/tests/unit_tests/test_imports.py (+1 -0)
➕ libs/pinecone/tests/unit_tests/test_rerank.py (+306 -0)

📄 Description

This pull request refactors the PineconeRerank implementation by relocating it to a new module, enhancing its functionality, and adding comprehensive integration tests. The changes also include updates to ensure compatibility with the new structure and improved documentation.

Refactoring and Relocation:

  • The PineconeRerank class has been moved from libs/pinecone/langchain_pinecone/pinecone_rerank.py to libs/pinecone/langchain_pinecone/rerank.py. This includes re-importing it in __init__.py to reflect the new module structure. [1] [2]

Enhancements to PineconeRerank:

  • Updated the _document_to_dict method to use the text field instead of content for document representation, aligning with Pinecone's API defaults.
  • Improved error handling and logging for reranking operations, including better validation of API responses and handling of potential exceptions.
  • Enhanced the rerank method to provide detailed examples and documentation for usage, including support for custom rank fields and model parameters.

Removal of Old Implementation:

  • Deleted the original PineconeRerank implementation from libs/pinecone/langchain_pinecone/pinecone_rerank.py to avoid redundancy.

Integration and Unit Testing:

  • Added new integration tests in libs/pinecone/tests/integration_tests/test_rerank.py to validate the functionality of PineconeRerank, including tests for basic reranking, top_n filtering, custom rank fields, and additional parameters.
  • Updated unit tests in libs/pinecone/tests/unit_tests/test_imports.py to include the relocated PineconeRerank in the import checks.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/langchain-ai/langchain-pinecone/pull/27 **Author:** [@simjak](https://github.com/simjak) **Created:** 5/6/2025 **Status:** ✅ Merged **Merged:** 5/7/2025 **Merged by:** [@jamescalam](https://github.com/jamescalam) **Base:** `feat/reranker` ← **Head:** `feat/reranker` --- ### 📝 Commits (5) - [`4786ea8`](https://github.com/langchain-ai/langchain-pinecone/commit/4786ea8e3b2e24fe5ab3d78b909f8f65dd915e61) chore: unit tests suite - [`b0d9d35`](https://github.com/langchain-ai/langchain-pinecone/commit/b0d9d35fe9b4149fd3b251f4f81becab3472bc0e) chore: rerank integration tests - [`3391a29`](https://github.com/langchain-ai/langchain-pinecone/commit/3391a29e7561b52575e78ec041e5e06378832e90) docs: Rerank docstrings - [`5bbbbb2`](https://github.com/langchain-ai/langchain-pinecone/commit/5bbbbb2e3a300e15f692d11a2448b985384a3051) chore: lint - [`524af14`](https://github.com/langchain-ai/langchain-pinecone/commit/524af14bfbfe4303d015417d666ce3aca9f0e5e0) chore: import tests ### 📊 Changes **6 files changed** (+701 additions, -165 deletions) <details> <summary>View changed files</summary> 📝 `libs/pinecone/langchain_pinecone/__init__.py` (+2 -2) ➖ `libs/pinecone/langchain_pinecone/pinecone_rerank.py` (+0 -163) ➕ `libs/pinecone/langchain_pinecone/rerank.py` (+287 -0) ➕ `libs/pinecone/tests/integration_tests/test_rerank.py` (+105 -0) 📝 `libs/pinecone/tests/unit_tests/test_imports.py` (+1 -0) ➕ `libs/pinecone/tests/unit_tests/test_rerank.py` (+306 -0) </details> ### 📄 Description This pull request refactors the `PineconeRerank` implementation by relocating it to a new module, enhancing its functionality, and adding comprehensive integration tests. The changes also include updates to ensure compatibility with the new structure and improved documentation. ### Refactoring and Relocation: * The `PineconeRerank` class has been moved from `libs/pinecone/langchain_pinecone/pinecone_rerank.py` to `libs/pinecone/langchain_pinecone/rerank.py`. This includes re-importing it in `__init__.py` to reflect the new module structure. [[1]](diffhunk://#diff-1bfb47108ddeb9a0763e9a8b47761d931f37501bf022f3189736399733dd5b67L2-R2) [[2]](diffhunk://#diff-1bfb47108ddeb9a0763e9a8b47761d931f37501bf022f3189736399733dd5b67L12-R12) ### Enhancements to `PineconeRerank`: * Updated the `_document_to_dict` method to use the `text` field instead of `content` for document representation, aligning with Pinecone's API defaults. * Improved error handling and logging for reranking operations, including better validation of API responses and handling of potential exceptions. * Enhanced the `rerank` method to provide detailed examples and documentation for usage, including support for custom rank fields and model parameters. ### Removal of Old Implementation: * Deleted the original `PineconeRerank` implementation from `libs/pinecone/langchain_pinecone/pinecone_rerank.py` to avoid redundancy. ### Integration and Unit Testing: * Added new integration tests in `libs/pinecone/tests/integration_tests/test_rerank.py` to validate the functionality of `PineconeRerank`, including tests for basic reranking, `top_n` filtering, custom rank fields, and additional parameters. * Updated unit tests in `libs/pinecone/tests/unit_tests/test_imports.py` to include the relocated `PineconeRerank` in the import checks. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-16 07:16:07 -05:00
yindo closed this issue 2026-02-16 07:16:07 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
enhancement
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langchain-ai/langchain-pinecone#49
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?