[PR #51] [MERGED] vectorstore: Fix in exists operator. Was working as null #136

New Issue

2026-02-16T05:16:43-05:00

yindo commented

2026-02-16 05:16:43 -05:00

📋 Pull Request Information

Original PR: https://github.com/langchain-ai/langchain-postgres/pull/51
Author: @MartinGotelli
Created: 5/17/2024
Status: ✅ Merged
Merged: 5/17/2024
Merged by: @eyurtsev

Base: main ← Head: fix_exists_condition

📝 Commits (1)

dd5dcc8 Fix in exists operator. Was working as null

📊 Changes

2 files changed (+5 additions, -5 deletions)

View changed files

📝 langchain_postgres/vectorstores.py (+1 -1)
📝 tests/unit_tests/fixtures/filtering_test_cases.py (+4 -4)

📄 Description

So... yeah I f***ed up. But this is the fix.

The $exists was working as the $null, but the rename implies also changing how the bool value is interpreted:

$exists: True (there is a tag, I don't care the value)
$exists: False (no tag in there)

ref: https://github.com/langchain-ai/langchain-postgres/pull/40

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/langchain-ai/langchain-postgres/pull/51 **Author:** [@MartinGotelli](https://github.com/MartinGotelli) **Created:** 5/17/2024 **Status:** ✅ Merged **Merged:** 5/17/2024 **Merged by:** [@eyurtsev](https://github.com/eyurtsev) **Base:** `main` ← **Head:** `fix_exists_condition` --- ### 📝 Commits (1) - [`dd5dcc8`](https://github.com/langchain-ai/langchain-postgres/commit/dd5dcc859752ec0f4b07af450e36cdcfaad78b6f) Fix in exists operator. Was working as null ### 📊 Changes **2 files changed** (+5 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `langchain_postgres/vectorstores.py` (+1 -1) 📝 `tests/unit_tests/fixtures/filtering_test_cases.py` (+4 -4) </details> ### 📄 Description So... yeah I f***ed up. But this is the fix. The $exists was working as the $null, but the rename implies also changing how the bool value is interpreted: $exists: True (there is a tag, I don't care the value) $exists: False (no tag in there) ref: https://github.com/langchain-ai/langchain-postgres/pull/40 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

yindo added the pull-request label 2026-02-16 05:16:43 -05:00

yindo closed this issue

2026-02-16 05:16:43 -05:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: langchain-ai/langchain-postgres#136