langchain-ai/langchain-postgres
1
0
Fork 0
mirror of https://github.com/langchain-ai/langchain-postgres.git synced 2026-07-16 01:33:18 -04:00
Code Issues 85 Packages Projects Releases 11 Wiki Activity

[PR #206] [CLOSED] chore: Make the private variable __vs to semi private #232

New Issue
Closed
opened 2026-02-16 05:17:03 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 05:17:03 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/langchain-ai/langchain-postgres/pull/206
Author: @dishaprakash
Created: 4/28/2025
Status: ❌ Closed

Base: main ← Head: private-variable

📝 Commits (2)

  • 1a894e0 chore: Make the private variable __vs to semi private
  • 03450db format

📊 Changes

1 file changed (+38 additions, -40 deletions)

View changed files

📝 langchain_postgres/v2/vectorstores.py (+38 -40)

📄 Description

chore: Make the private variable __vs to semi private

This change is being done as the AsyncPGVectorStore was being stored in the PGVectorStore as a private variable which hides it from the child class.
This PR converts it into a semi private variable

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/langchain-ai/langchain-postgres/pull/206 **Author:** [@dishaprakash](https://github.com/dishaprakash) **Created:** 4/28/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `private-variable` --- ### 📝 Commits (2) - [`1a894e0`](https://github.com/langchain-ai/langchain-postgres/commit/1a894e06aebb5cb8d82fb6052954878258c811da) chore: Make the private variable __vs to semi private - [`03450db`](https://github.com/langchain-ai/langchain-postgres/commit/03450dbd902653755019d8ffd654f7a4d42aa94b) format ### 📊 Changes **1 file changed** (+38 additions, -40 deletions) <details> <summary>View changed files</summary> 📝 `langchain_postgres/v2/vectorstores.py` (+38 -40) </details> ### 📄 Description chore: Make the private variable __vs to semi private This change is being done as the AsyncPGVectorStore was being stored in the PGVectorStore as a private variable which hides it from the child class. This PR converts it into a semi private variable --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-16 05:17:03 -05:00
yindo closed this issue 2026-02-16 05:17:03 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
help wanted
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langchain-ai/langchain-postgres#232
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?