Wrong async position #75

Closed
opened 2026-02-16 05:16:27 -05:00 by yindo · 0 comments
Owner

Originally created by @zhcn000000 on GitHub (Jun 9, 2025).

    async def drop_table(
        self,
        table_name: str,
        *,
        schema_name: str = "public",
    ) -> None:
        self._run_as_sync(
            self._adrop_table(table_name=table_name, schema_name=schema_name)
        )

in langchain_postgres/v2/engine.py line 402 ~ 410 Is the async added here incorrect?
Should it be changed to

    def drop_table(
        self,
        table_name: str,
        *,
        schema_name: str = "public",
    ) -> None:
        self._run_as_sync(
            self._adrop_table(table_name=table_name, schema_name=schema_name)
        )
Originally created by @zhcn000000 on GitHub (Jun 9, 2025). ```python async def drop_table( self, table_name: str, *, schema_name: str = "public", ) -> None: self._run_as_sync( self._adrop_table(table_name=table_name, schema_name=schema_name) ) ``` in langchain_postgres/v2/engine.py line 402 ~ 410 Is the async added here incorrect? Should it be changed to ```python def drop_table( self, table_name: str, *, schema_name: str = "public", ) -> None: self._run_as_sync( self._adrop_table(table_name=table_name, schema_name=schema_name) ) ```
yindo closed this issue 2026-02-16 05:16:27 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langchain-ai/langchain-postgres#75