mirror of
https://github.com/langchain-ai/langchain-postgres.git
synced 2026-07-16 01:33:18 -04:00
PostgresChatMessageHistory API break the usage of LCEL and Langserv #8
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @pprados on GitHub (Apr 25, 2024).
The constructor of
PostgresChatMessageHistoryaccepts only sync or async connection, and not an Engine.First, the connection was open in get_session_history, and pending during the life cycle of
RunnableWithMessageHistory.So, it's impossible to use it in a "singleton" approach.
With langserv, you must declare the API with
You must have a global variable
chain.The
get_session_historycannot be async. ThePostgresChatMessageHistory.async_connection()can not be used.PostgresChatMessageHistorymust be used if the singleton form, to be use with langserv. The engine must be set, without connection.@eyurtsev commented on GitHub (Apr 29, 2024):
I'm hoping to avoid using too much SQLAlchemy. Would a psycopg pool object work for your use case?
@pprados commented on GitHub (May 21, 2024):
Yes. The idea is to use the same approach as for the other integrations with sqlalchemy, exploiting the connection pool and sharing sessions if possible.
the vectorstore proposes
I think this is preferable and usable.
@eyurtsev , I can propose a PR for that, I can propose a PR for this, but I don't want it to remain on hold for several weeks, as with my other PRs.
@pprados commented on GitHub (May 23, 2024):
@eyurtsev
I propose a PR to resolve this problem.
@pprados commented on GitHub (May 27, 2024):
A patch is being applied here