langchain-ai/langchainjs-mcp-adapters
1
0
Fork 0
mirror of https://github.com/langchain-ai/langchainjs-mcp-adapters.git synced 2026-07-01 12:27:48 -04:00
Code Issues Packages Projects Releases 10 Wiki Activity

[PR #5] [MERGED] Fix issue #3: Document React agent compatibility issues #34

New Issue
Closed
opened 2026-02-16 08:17:21 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 08:17:21 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/langchain-ai/langchainjs-mcp-adapters/pull/5
Author: @vrknetha
Created: 3/8/2025
Status: ✅ Merged
Merged: 3/8/2025
Merged by: @vrknetha

Base: main ← Head: bugfix/tool-invocation-result-structure

📝 Commits (1)

  • 9282fcb Fix issue #3: Document React agent compatibility issues with MCP tools

📊 Changes

9 files changed (+746 additions, -0 deletions)

View changed files

📝 README.md (+31 -0)
➕ __tests__/agent-integration.test.ts (+115 -0)
📝 __tests__/client.test.ts (+185 -0)
📝 __tests__/tools.test.ts (+100 -0)
➕ examples/react_agent_bug_test.ts (+120 -0)
➕ examples/react_agent_openai_test.ts (+112 -0)
📝 package-lock.json (+72 -0)
📝 package.json (+1 -0)
📝 src/tools.ts (+10 -0)

📄 Description

This PR addresses issue #3 by: 1. Adding warnings in tools.ts when a tool has an empty schema; 2. Adding documentation about limitations in the README; 3. Creating example files demonstrating both approaches; 4. Adding comprehensive tests. This fix provides documentation and warnings about React agent limitations with certain LLMs.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/langchain-ai/langchainjs-mcp-adapters/pull/5 **Author:** [@vrknetha](https://github.com/vrknetha) **Created:** 3/8/2025 **Status:** ✅ Merged **Merged:** 3/8/2025 **Merged by:** [@vrknetha](https://github.com/vrknetha) **Base:** `main` ← **Head:** `bugfix/tool-invocation-result-structure` --- ### 📝 Commits (1) - [`9282fcb`](https://github.com/langchain-ai/langchainjs-mcp-adapters/commit/9282fcbce293898f8b3823ad460ce5a1788187d1) Fix issue #3: Document React agent compatibility issues with MCP tools ### 📊 Changes **9 files changed** (+746 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+31 -0) ➕ `__tests__/agent-integration.test.ts` (+115 -0) 📝 `__tests__/client.test.ts` (+185 -0) 📝 `__tests__/tools.test.ts` (+100 -0) ➕ `examples/react_agent_bug_test.ts` (+120 -0) ➕ `examples/react_agent_openai_test.ts` (+112 -0) 📝 `package-lock.json` (+72 -0) 📝 `package.json` (+1 -0) 📝 `src/tools.ts` (+10 -0) </details> ### 📄 Description This PR addresses issue #3 by: 1. Adding warnings in tools.ts when a tool has an empty schema; 2. Adding documentation about limitations in the README; 3. Creating example files demonstrating both approaches; 4. Adding comprehensive tests. This fix provides documentation and warnings about React agent limitations with certain LLMs. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-16 08:17:21 -05:00
yindo closed this issue 2026-02-16 08:17:21 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
bug
enhancement
invalid
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langchain-ai/langchainjs-mcp-adapters#34
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?