[PR #32] [MERGED] fix: build issues #55

Closed
opened 2026-02-16 08:17:25 -05:00 by yindo · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/langchain-ai/langchainjs-mcp-adapters/pull/32
Author: @benjamincburns
Created: 3/21/2025
Status: Merged
Merged: 3/21/2025
Merged by: @benjamincburns

Base: mainHead: ben/build-fixes


📝 Commits (2)

  • 74ba222 fix: add missing JSON export & import assertion
  • a06cca8 fix: convert to langchain build, adds cjs build

📊 Changes

31 files changed (+10465 additions, -9353 deletions)

View changed files

.eslintrc.cjs (+68 -0)
📝 .github/workflows/main.yml (+8 -8)
📝 .github/workflows/npm-publish.yml (+5 -5)
📝 .github/workflows/pr-validation.yml (+7 -7)
📝 .gitignore (+7 -54)
.prettierrc (+19 -0)
.yarn/install-state.gz (+0 -0)
.yarn/plugins/@yarnpkg/plugin-typescript.cjs (+9 -0)
.yarn/releases/yarn-3.5.1.cjs (+873 -0)
.yarnrc.yml (+7 -0)
📝 __tests__/client.basic.test.ts (+223 -172)
eslint.config.mjs (+0 -71)
📝 examples/config_langgraph_test.ts (+74 -49)
📝 examples/filesystem_langgraph_example.ts (+58 -43)
📝 examples/firecrawl_custom_config_example.ts (+30 -26)
📝 examples/firecrawl_default_config_example.ts (+20 -19)
📝 examples/firecrawl_enhanced_config_example.ts (+76 -51)
📝 examples/firecrawl_mixed_loading_example.ts (+75 -47)
📝 examples/firecrawl_multiple_servers_example.ts (+45 -34)
📝 examples/langgraph_example.ts (+46 -35)

...and 11 more files

📄 Description

Updates build pipeline to use the @langchain/scripts build util in order to actually publish a hybrid package. Also removes package.json import in favor of hard-coded package name (as that's unlikely to change).

Note that the first change comes with substantial build pipeline differences, and switches the package manager to use yarn instead of NPM, as this is more aligned with how things are configured in other LangChain packages.

Fixes #30
Fixes #31


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/langchain-ai/langchainjs-mcp-adapters/pull/32 **Author:** [@benjamincburns](https://github.com/benjamincburns) **Created:** 3/21/2025 **Status:** ✅ Merged **Merged:** 3/21/2025 **Merged by:** [@benjamincburns](https://github.com/benjamincburns) **Base:** `main` ← **Head:** `ben/build-fixes` --- ### 📝 Commits (2) - [`74ba222`](https://github.com/langchain-ai/langchainjs-mcp-adapters/commit/74ba2221773d1ae807458d9cac73cdf7fc296c2c) fix: add missing JSON export & import assertion - [`a06cca8`](https://github.com/langchain-ai/langchainjs-mcp-adapters/commit/a06cca81112e7eb78bc9f00ddea483e8f458c70d) fix: convert to langchain build, adds cjs build ### 📊 Changes **31 files changed** (+10465 additions, -9353 deletions) <details> <summary>View changed files</summary> ➕ `.eslintrc.cjs` (+68 -0) 📝 `.github/workflows/main.yml` (+8 -8) 📝 `.github/workflows/npm-publish.yml` (+5 -5) 📝 `.github/workflows/pr-validation.yml` (+7 -7) 📝 `.gitignore` (+7 -54) ➕ `.prettierrc` (+19 -0) ➕ `.yarn/install-state.gz` (+0 -0) ➕ `.yarn/plugins/@yarnpkg/plugin-typescript.cjs` (+9 -0) ➕ `.yarn/releases/yarn-3.5.1.cjs` (+873 -0) ➕ `.yarnrc.yml` (+7 -0) 📝 `__tests__/client.basic.test.ts` (+223 -172) ➖ `eslint.config.mjs` (+0 -71) 📝 `examples/config_langgraph_test.ts` (+74 -49) 📝 `examples/filesystem_langgraph_example.ts` (+58 -43) 📝 `examples/firecrawl_custom_config_example.ts` (+30 -26) 📝 `examples/firecrawl_default_config_example.ts` (+20 -19) 📝 `examples/firecrawl_enhanced_config_example.ts` (+76 -51) 📝 `examples/firecrawl_mixed_loading_example.ts` (+75 -47) 📝 `examples/firecrawl_multiple_servers_example.ts` (+45 -34) 📝 `examples/langgraph_example.ts` (+46 -35) _...and 11 more files_ </details> ### 📄 Description Updates build pipeline to use the `@langchain/scripts` build util in order to actually publish a hybrid package. Also removes package.json import in favor of hard-coded package name (as that's unlikely to change). Note that the first change comes with substantial build pipeline differences, and switches the package manager to use yarn instead of NPM, as this is more aligned with how things are configured in other LangChain packages. Fixes #30 Fixes #31 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-16 08:17:25 -05:00
yindo closed this issue 2026-02-16 08:17:25 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langchain-ai/langchainjs-mcp-adapters#55