[PR #134] [CLOSED] Fix grade_documents and rewrite #1258

Closed
opened 2026-02-20 17:44:18 -05:00 by yindo · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/langchain-ai/langgraph/pull/134
Author: @code-sum
Created: 2/21/2024
Status: Closed

Base: mainHead: lsg/agentic_rag_bugfix


📝 Commits (1)

  • b142308 Fix grade_documents and rewrite

📊 Changes

1 file changed (+111 additions, -23 deletions)

View changed files

📝 examples/rag/langgraph_agentic_rag.ipynb (+111 -23)

📄 Description

Hi, I’m so excited to be using LangGraph !

Yesterday, I found this bug in /examples/langgraph_agentic_rag.ipynb.

The problem is that when it comes to the case of DECISION: DOCS NOT RELEVANT
(e.g. "What does Lilian Weng say about the types of apple?")
some error occurs because of the data type of score and msg.

Developers at LangGraph can fix the bug by applying my solution.

Good luck and have a nice day !

스크린샷 2024-02-21 171452

스크린샷 2024-02-21 171520

스크린샷 2024-02-21 171729

스크린샷 2024-02-21 171812

스크린샷 2024-02-21 171929


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/langchain-ai/langgraph/pull/134 **Author:** [@code-sum](https://github.com/code-sum) **Created:** 2/21/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `lsg/agentic_rag_bugfix` --- ### 📝 Commits (1) - [`b142308`](https://github.com/langchain-ai/langgraph/commit/b142308184a3740d5be83dc7fe1ec600079c451c) Fix `grade_documents` and `rewrite` ### 📊 Changes **1 file changed** (+111 additions, -23 deletions) <details> <summary>View changed files</summary> 📝 `examples/rag/langgraph_agentic_rag.ipynb` (+111 -23) </details> ### 📄 Description Hi, I’m so excited to be using LangGraph ! Yesterday, I found this bug in `/examples/langgraph_agentic_rag.ipynb`. The problem is that when it comes to the case of `DECISION: DOCS NOT RELEVANT` (e.g. "What does Lilian Weng say about the types of apple?") some error occurs because of the data type of `score` and `msg`. Developers at LangGraph can fix the bug by applying my solution. Good luck and have a nice day ! ![스크린샷 2024-02-21 171452](https://github.com/langchain-ai/langgraph/assets/106902415/5c95f053-7399-4464-8ea7-c08bab9d861f) ![스크린샷 2024-02-21 171520](https://github.com/langchain-ai/langgraph/assets/106902415/790e5ad2-2c1d-4f0d-8acf-e316b1891e7a) ![스크린샷 2024-02-21 171729](https://github.com/langchain-ai/langgraph/assets/106902415/a7c7074f-e079-4d50-a05d-8b4c4ea5f628) ![스크린샷 2024-02-21 171812](https://github.com/langchain-ai/langgraph/assets/106902415/6c364d46-6f8a-4417-b2b8-2209a284bbcd) ![스크린샷 2024-02-21 171929](https://github.com/langchain-ai/langgraph/assets/106902415/da25b710-f51a-4426-8940-5d98eb2e8f5f) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-20 17:44:18 -05:00
yindo closed this issue 2026-02-20 17:44:18 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langchain-ai/langgraph#1258