langchain-ai/langgraph
1
0
Fork 0
mirror of https://github.com/langchain-ai/langgraph.git synced 2026-07-15 12:35:43 -04:00
Code Issues 314 Packages Projects Releases 17 Wiki Activity

[PR #626] [MERGED] Accept dead-ends #1581

New Issue
Closed
opened 2026-02-20 17:45:04 -05:00 by yindo · 0 comments
yindo commented 2026-02-20 17:45:04 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/langchain-ai/langgraph/pull/626
Author: @hinthornw
Created: 6/7/2024
Status: ✅ Merged
Merged: 6/8/2024
Merged by: @hinthornw

Base: main ← Head: wfh/unvalidate

📝 Commits (3)

📊 Changes

3 files changed (+62 additions, -81 deletions)

View changed files

📝 langgraph/graph/graph.py (+1 -4)
📝 tests/__snapshots__/test_pregel.ambr (+46 -46)
📝 tests/test_pregel.py (+15 -31)

📄 Description

Plus fix a small bug.

Previously, we validated that nodes explicitly route to END.
This feels a bit unnecessary, since graphs are expected to keep processing until no work is left to be done

This decision is a bit of a 1-way door, since once we relax it, if we change our minds, it would break otherwise working code. LMK if you have reservations

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/langchain-ai/langgraph/pull/626 **Author:** [@hinthornw](https://github.com/hinthornw) **Created:** 6/7/2024 **Status:** ✅ Merged **Merged:** 6/8/2024 **Merged by:** [@hinthornw](https://github.com/hinthornw) **Base:** `main` ← **Head:** `wfh/unvalidate` --- ### 📝 Commits (3) - [`2c60585`](https://github.com/langchain-ai/langgraph/commit/2c60585a51afaa60c501a0289fa611279c24003c) Accept dead-ends - [`85fd752`](https://github.com/langchain-ai/langgraph/commit/85fd7528f68e2e6251539920a01180ff84d845d8) sort - [`dda3a46`](https://github.com/langchain-ai/langgraph/commit/dda3a4696edee6af9640225491a6e085285ab3e8) Move tests ### 📊 Changes **3 files changed** (+62 additions, -81 deletions) <details> <summary>View changed files</summary> 📝 `langgraph/graph/graph.py` (+1 -4) 📝 `tests/__snapshots__/test_pregel.ambr` (+46 -46) 📝 `tests/test_pregel.py` (+15 -31) </details> ### 📄 Description Plus fix a small bug. Previously, we validated that nodes explicitly route to END. This feels a bit unnecessary, since graphs are expected to keep processing until no work is left to be done This decision is a bit of a 1-way door, since once we relax it, if we change our minds, it would break otherwise working code. LMK if you have reservations --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-20 17:45:04 -05:00
yindo closed this issue 2026-02-20 17:45:04 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
agents
awaiting author revision
bug
change
chat models
checkpointer
ci
code quality
code quality
dependencies
documentation
drawing
duplicate
enhancement
good first issue
help wanted
invalid
maintainer
meta
missing information
not maintained by langchain
open-swe-auto
open-swe-max
open-swe-max-auto
pending
performance
pull-request
Mirrored from GitHub Pull Request
 question
requires design
sdk
server
stale
studio
tests
type checking
usage question
v0.5
v1.1
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langchain-ai/langgraph#1581
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?