langchain-ai/langgraph
1
0
Fork 0
mirror of https://github.com/langchain-ai/langgraph.git synced 2026-07-15 12:35:43 -04:00
Code Issues 314 Packages Projects Releases 17 Wiki Activity

[PR #1481] [CLOSED] Removes trailing slashes from apiUrl's to prevent erroneous 404s #2094

New Issue
Closed
opened 2026-02-20 17:46:16 -05:00 by yindo · 0 comments
yindo commented 2026-02-20 17:46:16 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/langchain-ai/langgraph/pull/1481
Author: @SomethingNew71
Created: 8/26/2024
Status: ❌ Closed

Base: main ← Head: trailing-slash-fix

📝 Commits (1)

  • 5195dfe Removes trailing slashes from apiUrl's to prevent eronious 404s

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 libs/sdk-js/src/client.mts (+1 -1)

📄 Description

Hey Langgraph folks, I noticed a little issue when I was putting my base apiUrl in for my client in the JS SDK. I left the trailing slash on and was getting 404s. I couldn't figure out why, so I removed the slash locally and it resolved it. I decided to open a PR to fix this minor bug that could save some people's sanity later.

Example of the regex I used - https://regexr.com/856tn

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/langchain-ai/langgraph/pull/1481 **Author:** [@SomethingNew71](https://github.com/SomethingNew71) **Created:** 8/26/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `trailing-slash-fix` --- ### 📝 Commits (1) - [`5195dfe`](https://github.com/langchain-ai/langgraph/commit/5195dfecdb96363ee697428bd314ef90d773c625) Removes trailing slashes from apiUrl's to prevent eronious 404s ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `libs/sdk-js/src/client.mts` (+1 -1) </details> ### 📄 Description Hey Langgraph folks, I noticed a little issue when I was putting my base `apiUrl` in for my client in the JS SDK. I left the trailing slash on and was getting 404s. I couldn't figure out why, so I removed the slash locally and it resolved it. I decided to open a PR to fix this minor bug that could save some people's sanity later. Example of the regex I used - https://regexr.com/856tn --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-20 17:46:16 -05:00
yindo closed this issue 2026-02-20 17:46:16 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
agents
awaiting author revision
bug
change
chat models
checkpointer
ci
code quality
code quality
dependencies
documentation
drawing
duplicate
enhancement
good first issue
help wanted
invalid
maintainer
meta
missing information
not maintained by langchain
open-swe-auto
open-swe-max
open-swe-max-auto
pending
performance
pull-request
Mirrored from GitHub Pull Request
 question
requires design
sdk
server
stale
studio
tests
type checking
usage question
v0.5
v1.1
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langchain-ai/langgraph#2094
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?