[PR #1693] [MERGED] kafka: Expose finally_send as public api #2235

Closed
opened 2026-02-20 17:46:37 -05:00 by yindo · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/langchain-ai/langgraph/pull/1693
Author: @nfcampos
Created: 9/11/2024
Status: Merged
Merged: 9/11/2024
Merged by: @nfcampos

Base: mainHead: nc/11sep/kafka-finally-send


📝 Commits (2)

  • dd68bab kafka: Expose finally_send as public api
  • 5716234 Avoid closing drain before seeing first message in either topic

📊 Changes

8 files changed (+333 additions, -277 deletions)

View changed files

📝 libs/scheduler-kafka/langgraph/scheduler/kafka/executor.py (+9 -4)
📝 libs/scheduler-kafka/langgraph/scheduler/kafka/orchestrator.py (+18 -11)
📝 libs/scheduler-kafka/langgraph/scheduler/kafka/types.py (+8 -2)
📝 libs/scheduler-kafka/tests/drain.py (+4 -2)
📝 libs/scheduler-kafka/tests/test_fanout.py (+4 -4)
📝 libs/scheduler-kafka/tests/test_fanout_sync.py (+4 -4)
📝 libs/scheduler-kafka/tests/test_subgraph.py (+143 -125)
📝 libs/scheduler-kafka/tests/test_subgraph_sync.py (+143 -125)

📄 Description

  • Enables attaching a list of messages (topic/key/value) to send when run finishes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/langchain-ai/langgraph/pull/1693 **Author:** [@nfcampos](https://github.com/nfcampos) **Created:** 9/11/2024 **Status:** ✅ Merged **Merged:** 9/11/2024 **Merged by:** [@nfcampos](https://github.com/nfcampos) **Base:** `main` ← **Head:** `nc/11sep/kafka-finally-send` --- ### 📝 Commits (2) - [`dd68bab`](https://github.com/langchain-ai/langgraph/commit/dd68babac7012c33f4f74c451d5c6fa9481bf9db) kafka: Expose finally_send as public api - [`5716234`](https://github.com/langchain-ai/langgraph/commit/571623442ab307c7a92f718a49f6af6f383b8cb3) Avoid closing drain before seeing first message in either topic ### 📊 Changes **8 files changed** (+333 additions, -277 deletions) <details> <summary>View changed files</summary> 📝 `libs/scheduler-kafka/langgraph/scheduler/kafka/executor.py` (+9 -4) 📝 `libs/scheduler-kafka/langgraph/scheduler/kafka/orchestrator.py` (+18 -11) 📝 `libs/scheduler-kafka/langgraph/scheduler/kafka/types.py` (+8 -2) 📝 `libs/scheduler-kafka/tests/drain.py` (+4 -2) 📝 `libs/scheduler-kafka/tests/test_fanout.py` (+4 -4) 📝 `libs/scheduler-kafka/tests/test_fanout_sync.py` (+4 -4) 📝 `libs/scheduler-kafka/tests/test_subgraph.py` (+143 -125) 📝 `libs/scheduler-kafka/tests/test_subgraph_sync.py` (+143 -125) </details> ### 📄 Description - Enables attaching a list of messages (topic/key/value) to send when run finishes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-20 17:46:37 -05:00
yindo closed this issue 2026-02-20 17:46:37 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langchain-ai/langgraph#2235