Should the comments here be updated? #317

Closed
opened 2026-02-20 17:36:20 -05:00 by yindo · 0 comments
Owner

Originally created by @leild on GitHub (Nov 25, 2024).

Checked other resources

  • I added a very descriptive title to this issue.
  • I searched the LangGraph/LangChain documentation with the integrated search.
  • I used the GitHub search to find a similar question and didn't find it.
  • I am sure that this is a bug in LangGraph/LangChain rather than my code.
  • I am sure this is better as an issue rather than a GitHub discussion, since this is a LangGraph bug and not a design question.

Example Code

def attach_edge(self, starts: Union[str, Sequence[str]], end: str) -> None:
        if isinstance(starts, str):
            if starts == START:
                channel_name = f"start:{end}"
                # register channel
                self.channels[channel_name] = EphemeralValue(Any)
                # subscribe to channel
                self.nodes[end].triggers.append(channel_name)
                # publish to channel
                self.nodes[START] |= ChannelWrite(
                    [ChannelWriteEntry(channel_name, START)], tags=[TAG_HIDDEN]
                )
            elif end != END:
                # subscribe to start channel
                self.nodes[end].triggers.append(starts)
        elif end != END:
            channel_name = f"join:{'+'.join(starts)}:{end}"
            # register channel
            self.channels[channel_name] = NamedBarrierValue(str, set(starts))
            # subscribe to channel
            self.nodes[end].triggers.append(channel_name)
            # publish to channel
            for start in starts:
                self.nodes[start] |= ChannelWrite(
                    [ChannelWriteEntry(channel_name, start)], tags=[TAG_HIDDEN]
                )

Error Message and Stack Trace (if applicable)

# publish to channel 
this comments is not Precisely ,MapBe should be "use channel to update"?

Description

publish to channel

this comments is not Precisely ,MapBe should be "use channel to update"?

System Info

publish to channel

this comments is not Precisely ,MapBe should be "use channel to update"?

Originally created by @leild on GitHub (Nov 25, 2024). ### Checked other resources - [X] I added a very descriptive title to this issue. - [X] I searched the [LangGraph](https://langchain-ai.github.io/langgraph/)/LangChain documentation with the integrated search. - [X] I used the GitHub search to find a similar question and didn't find it. - [X] I am sure that this is a bug in LangGraph/LangChain rather than my code. - [X] I am sure this is better as an issue [rather than a GitHub discussion](https://github.com/langchain-ai/langgraph/discussions/new/choose), since this is a LangGraph bug and not a design question. ### Example Code ```python def attach_edge(self, starts: Union[str, Sequence[str]], end: str) -> None: if isinstance(starts, str): if starts == START: channel_name = f"start:{end}" # register channel self.channels[channel_name] = EphemeralValue(Any) # subscribe to channel self.nodes[end].triggers.append(channel_name) # publish to channel self.nodes[START] |= ChannelWrite( [ChannelWriteEntry(channel_name, START)], tags=[TAG_HIDDEN] ) elif end != END: # subscribe to start channel self.nodes[end].triggers.append(starts) elif end != END: channel_name = f"join:{'+'.join(starts)}:{end}" # register channel self.channels[channel_name] = NamedBarrierValue(str, set(starts)) # subscribe to channel self.nodes[end].triggers.append(channel_name) # publish to channel for start in starts: self.nodes[start] |= ChannelWrite( [ChannelWriteEntry(channel_name, start)], tags=[TAG_HIDDEN] ) ``` ### Error Message and Stack Trace (if applicable) ```shell # publish to channel this comments is not Precisely ,MapBe should be "use channel to update"? ``` ### Description # publish to channel this comments is not Precisely ,MapBe should be "use channel to update"? ### System Info # publish to channel this comments is not Precisely ,MapBe should be "use channel to update"?
yindo closed this issue 2026-02-20 17:36:20 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langchain-ai/langgraph#317